ca430b715311fd26c1709f9ef07ac19d741f6ca8: bug 1218576 - Request an immediate batch send when the batch size hits a high water mark. r=gfritzsche
Chris H-C <chutten@mozilla.com> - Thu, 08 Sep 2016 10:15:15 -0400 - rev 314454
Push 20574 by cbook@mozilla.com at Tue, 20 Sep 2016 10:05:16 +0000
bug 1218576 - Request an immediate batch send when the batch size hits a high water mark. r=gfritzsche We've now seen an OOM trying to grow the accumulations array during a test suite. The g*Accumulations arrays do grow unboundedly in size waiting for the IPC timer to fire, so we should put a size bound as well as a time bound to trigger the batch send. The current size bound is 5K elements. This was chosen out of a hat. MozReview-Commit-ID: 5HeWdbLfN03
1b498933da3ae553f8a965c4b20e40fbe57fd1bf: bug 1218576 - Ensure accumulations are for valid IDs. r=gfritzsche
Chris H-C <chutten@mozilla.com> - Thu, 08 Sep 2016 10:09:54 -0400 - rev 314453
Push 20574 by cbook@mozilla.com at Tue, 20 Sep 2016 10:05:16 +0000
bug 1218576 - Ensure accumulations are for valid IDs. r=gfritzsche We're seeing occasional failures of the isValid assert on the parent side where the ID we're being asked to accumulate on is invalid. Check the IDs on both sides to ensure that they're valid heading in. MozReview-Commit-ID: 4gLG54Tx64s
fcfa94c81e0a437817caff6497ef2ace29b92ccb: bug 1218576 - Ensure IPCTimer is on the main thread. r=froydnj f=gfritzsche
Chris H-C <chutten@mozilla.com> - Wed, 31 Aug 2016 13:31:30 -0400 - rev 314452
Push 20574 by cbook@mozilla.com at Tue, 20 Sep 2016 10:05:16 +0000
bug 1218576 - Ensure IPCTimer is on the main thread. r=froydnj f=gfritzsche nsTimer fires on the thread that created the timer. An nsTimer instance should only be manipulated on its target thread (it isn't threadsafe). IPC using PContent must be on the main thread. Thus, everything to do with the gIPCTimer must be on the main thread. This also takes care of bug 1299312. MozReview-Commit-ID: IcVRYsoX2R9
f3b858440d0112e121efd0080e2eaf9f081d6d36: bug 1218576 - Change unused.h to Unused.h, which matters to some filesystems. r=gfritzsche
Chris H-C <chutten@mozilla.com> - Tue, 30 Aug 2016 12:07:18 -0400 - rev 314451
Push 20574 by cbook@mozilla.com at Tue, 20 Sep 2016 10:05:16 +0000
bug 1218576 - Change unused.h to Unused.h, which matters to some filesystems. r=gfritzsche MozReview-Commit-ID: GOy5Xz2Pxta
762e238a73d064a497891f997347f10b6c2e8921: bug 1277504 - Support aggregated child histograms in about:telemetry r=gfritzsche
Chris H-C <chutten@mozilla.com> - Tue, 23 Aug 2016 14:11:31 -0400 - rev 314450
Push 20574 by cbook@mozilla.com at Tue, 20 Sep 2016 10:05:16 +0000
bug 1277504 - Support aggregated child histograms in about:telemetry r=gfritzsche Throw some process selectors in the Histograms and Keyed Histograms sections to allow users to choose which process type's histograms they'd like to see.
5d3383a8df5f53550e54f8132fdb69b4479f721c: bug 1218576 - Test child categorical histogram aggregation r=gfritzsche
Chris H-C <chutten@mozilla.com> - Fri, 19 Aug 2016 11:53:17 -0400 - rev 314449
Push 20574 by cbook@mozilla.com at Tue, 20 Sep 2016 10:05:16 +0000
bug 1218576 - Test child categorical histogram aggregation r=gfritzsche It's new, it wasn't tested, and my patches broke it earlier so we should have coverage for it. MozReview-Commit-ID: B25bFOJHMSQ
c97a5b2b086accd52fb5dd0b27eb6d5127fb6fc8: bug 1218576 - Aggregate child categorical histograms in the parent process. r=gfritzsche
Chris H-C <chutten@mozilla.com> - Fri, 12 Aug 2016 14:51:48 -0400 - rev 314448
Push 20574 by cbook@mozilla.com at Tue, 20 Sep 2016 10:05:16 +0000
bug 1218576 - Aggregate child categorical histograms in the parent process. r=gfritzsche Rewrite the categorical histogram accumulation code to use the common path. This way it gets remote accumulation for cheap. MozReview-Commit-ID: 3q6gdSvBix
6e20455447661423af908193c9458895df211c7e: bug 1218576 - Ensure we can record before trying to record categorical histograms. r=gfritzsche
Chris H-C <chutten@mozilla.com> - Fri, 12 Aug 2016 09:09:18 -0400 - rev 314447
Push 20574 by cbook@mozilla.com at Tue, 20 Sep 2016 10:05:16 +0000
bug 1218576 - Ensure we can record before trying to record categorical histograms. r=gfritzsche Every other Accumulate call has it :S MozReview-Commit-ID: 8uWtADebuJ1
02bee0c4865ad16db50a47b25c6410dd1b1b3dce: bug 1218576 - Ensure Telemetry IDs coming from IPC are valid r=gfritzsche
Chris H-C <chutten@mozilla.com> - Thu, 28 Jul 2016 12:22:06 -0400 - rev 314446
Push 20574 by cbook@mozilla.com at Tue, 20 Sep 2016 10:05:16 +0000
bug 1218576 - Ensure Telemetry IDs coming from IPC are valid r=gfritzsche I saw a one-off crash on try in internal_GetHistogramByEnumId. Not reproducible but maybe possible if we're trying to accumulate using an invalid ID. So let's guard against that. MozReview-Commit-ID: Ei6eTlV91mJ
83d24a3dc1a99dd5669cc718e459996e26ad44e2: bug 1218576 - Ensure remaining batched telemetry is flushed on content process shutdown r=gfritzsche
Chris H-C <chutten@mozilla.com> - Tue, 12 Jul 2016 11:49:38 -0400 - rev 314445
Push 20574 by cbook@mozilla.com at Tue, 20 Sep 2016 10:05:16 +0000
bug 1218576 - Ensure remaining batched telemetry is flushed on content process shutdown r=gfritzsche On content process shutdown we send a content process ping to ensure we have up-to-date data from the content process before it goes away. Now we need to also flush the batched telemetry accumulations to the parent so that it can be present in the ping. No attempt is made to synchronize access to IPCTimerFired. It is safe to re-enter. No attempt is made to cancel the timer as its firing is benign. MozReview-Commit-ID: 1gjNH9IPhKf
92ed900459dfcf59a3a28263d0855ee279d74f49: bug 1218576 - Assert we're the parent process when clearing histograms. r=gfritzsche
Chris H-C <chutten@mozilla.com> - Tue, 05 Jul 2016 09:51:49 -0400 - rev 314444
Push 20574 by cbook@mozilla.com at Tue, 20 Sep 2016 10:05:16 +0000
bug 1218576 - Assert we're the parent process when clearing histograms. r=gfritzsche Clear isn't generally called at all, and isn't dispatched to the parent process for child telemetry aggregation. Clear should only be called on the parent process. MozReview-Commit-ID: stIutvAO6h
021273dad9aead8dbc1455018bcd6d6d1566483e: bug 1218576 - Update test browser_use_counters.js to use aggregated child telemetry r=gfritzsche
Chris H-C <chutten@mozilla.com> - Tue, 05 Jul 2016 09:34:33 -0400 - rev 314443
Push 20574 by cbook@mozilla.com at Tue, 20 Sep 2016 10:05:16 +0000
bug 1218576 - Update test browser_use_counters.js to use aggregated child telemetry r=gfritzsche waitOnCondition is used to wait for the telemetry batch to be processed (roughly every 2s). It resolves and rejects to the same value as there are a couple of xfail tests that need the wrong answer. MozReview-Commit-ID: I1JqEXQSL7d
4b674e3249ecab5caf4d7a10bc1f40a1615ea84e: bug 1218576 - Update test_ChildHistograms for child telemetry aggregation r=gfritzsche
Chris H-C <chutten@mozilla.com> - Mon, 04 Jul 2016 11:17:07 -0400 - rev 314442
Push 20574 by cbook@mozilla.com at Tue, 20 Sep 2016 10:05:16 +0000
bug 1218576 - Update test_ChildHistograms for child telemetry aggregation r=gfritzsche No more requestChildPayloads (or need for it). MozReview-Commit-ID: AmPuT04HjWx
206ce3f7b0cde047a5b4f1b8f4b61b3b33f77d0b: bug 1218576 - Support remote accumulation via JS histograms. r=gfritzsche
Chris H-C <chutten@mozilla.com> - Mon, 04 Jul 2016 11:16:05 -0400 - rev 314441
Push 20574 by cbook@mozilla.com at Tue, 20 Sep 2016 10:05:16 +0000
bug 1218576 - Support remote accumulation via JS histograms. r=gfritzsche The JS histograms, too, need to dispatch their accumulations from child to parent. JSHistograms_Add now only supports histograms that are in gHistogramsMap or that were created in the parent process. After bug 1288745, maybe we'll be able to change this to be less convoluted. MozReview-Commit-ID: 3qTH89YKbGP
f5a08bea2e1704e656b21a14079537931da77c5e: bug 1218576 - Move aggregated child telemetry to processes.content r=gfritzsche
Chris H-C <chutten@mozilla.com> - Wed, 29 Jun 2016 15:46:22 -0400 - rev 314440
Push 20574 by cbook@mozilla.com at Tue, 20 Sep 2016 10:05:16 +0000
bug 1218576 - Move aggregated child telemetry to processes.content r=gfritzsche Take the opportunity presented through changing child telemetry accumulation to bring the ping form closer to the ideas expressed in bug 1281795. childPayloads still exists, but without histograms or keyedHistograms which are now at root.processes.content.{keyedH|h}istograms. This will require coordinated changes in the aggregator and moztelemetry libraries. MozReview-Commit-ID: AqG2jmBBC2W
712681439306713ccaf6cab6c7e3098ef995390b: bug 1218576 - Remove requestChildPayloads r=gfritzsche
Chris H-C <chutten@mozilla.com> - Wed, 29 Jun 2016 15:43:37 -0400 - rev 314439
Push 20574 by cbook@mozilla.com at Tue, 20 Sep 2016 10:05:16 +0000
bug 1218576 - Remove requestChildPayloads r=gfritzsche To simplify using child telemetry from the parent process, only allow child telemetry payloads to be generated once per child process, on shut down. This will allow us to use the child telemetry's subsession information to leave childPayloads the way it currently is. Will need to update test_ChildHistograms.js as it is the only consumer. MozReview-Commit-ID: 2qSztg0QHV5
1b2b8973c8a2debe79803db16ebd514629a8df2c: bug 1218576 - Pre-allocate child keyed histograms in the parent process r=gfritzsche
Chris H-C <chutten@mozilla.com> - Wed, 29 Jun 2016 15:38:35 -0400 - rev 314438
Push 20574 by cbook@mozilla.com at Tue, 20 Sep 2016 10:05:16 +0000
bug 1218576 - Pre-allocate child keyed histograms in the parent process r=gfritzsche I originally thought we'd be able to avoid the previous implementation's waste of a map full of every kind of keyed histogram. Unfortunately, other code (TelemetrySession at the very least) depends on this (and will throw if a keyed histogram isn't present, even if it is empty) MozReview-Commit-ID: 8MCGVa595UB
832793e20c54a1fc6a2c6573e9205e2e783a3676: bug 1218576 - Support subsession hgrams for child aggregation r=gfritzsche
Chris H-C <chutten@mozilla.com> - Wed, 29 Jun 2016 15:36:07 -0400 - rev 314437
Push 20574 by cbook@mozilla.com at Tue, 20 Sep 2016 10:05:16 +0000
bug 1218576 - Support subsession hgrams for child aggregation r=gfritzsche The original commit didn't properly support subsession histograms, so rectify that lapse by adding support for stripping out the base name of a histogram when trying to determine its id. MozReview-Commit-ID: LvUek6f5WUx
9b792ae11734c602485896031a6d3400a3f603b3: bug 1218576 - Accumulate child histograms in the parent process r=froydnj
Chris H-C <chutten@mozilla.com> - Wed, 22 Jun 2016 10:16:40 -0400 - rev 314436
Push 20574 by cbook@mozilla.com at Tue, 20 Sep 2016 10:05:16 +0000
bug 1218576 - Accumulate child histograms in the parent process r=froydnj Batch the accumulations to only transmit every so often, so we don't incur too much in the way of IPC overhead penalties. What this doesn't do: * remove or restructure child telemetry code to adapt to the new way * send the telemetry anywhere * allow for the child process to clear child histograms * support anything but histograms (but this is expected and okay) MozReview-Commit-ID: JnUkcmN3Ya7
e81f8c1e38fbcd3763bf0bb87f17133ddf36d8b4: merge fx-team to mozilla-central a=merge
Carsten "Tomcat" Book <cbook@mozilla.com> - Tue, 20 Sep 2016 12:00:36 +0200 - rev 314435
Push 20574 by cbook@mozilla.com at Tue, 20 Sep 2016 10:05:16 +0000
merge fx-team to mozilla-central a=merge
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 tip