c456c1797299e5dfc39187992e30c323f7d92ee1: Bug 1299411 - Error messages for native messaging r=aswan
Rob Wu <rob@robwu.nl> - Sat, 24 Sep 2016 13:45:02 +0200 - rev 320067
Push 20749 by ryanvm@gmail.com at Sat, 29 Oct 2016 13:21:21 +0000
Bug 1299411 - Error messages for native messaging r=aswan - Combine the errors for a non-existing app and lacking permissions to avoid information leakage. - Do not treat normal application exit as an error. - Create errors in the right context. - Add tests that check the error messages. MozReview-Commit-ID: HxBpeCSyyGN
ed1afd2aad61c64bb938cf1647975b4fda846d66: Bug 1299411 - Move native messaging to child process r=kmag
Rob Wu <rob@robwu.nl> - Sat, 24 Sep 2016 13:25:56 +0200 - rev 320066
Push 20749 by ryanvm@gmail.com at Sat, 29 Oct 2016 13:21:21 +0000
Bug 1299411 - Move native messaging to child process r=kmag Move `runtime.connectNative` and `runtime.sendNativeMessage` to `addon_child`. Note: This does not change the behavior for launching the native app, it is still launched from the main process. Now ExtensionUtils's Port is also used for native messaging ports. Now the behavior of `runtime.connect` and `runtime.connectNative` are identical from the extension's perspective. In particular: - `disconnect()` does not throw when called again (bug 1287229). - `onDisconnect` is called with error messages (tests will be added in the next commit). MozReview-Commit-ID: AyU9amiLeoL
24d81c7b335e8cb1949efb2b27a978cf108de705: Bug 1299411 - s/on/once/ in NativeApp's sendMessage r=aswan
Rob Wu <rob@robwu.nl> - Sat, 24 Sep 2016 13:22:31 +0200 - rev 320065
Push 20749 by ryanvm@gmail.com at Sat, 29 Oct 2016 13:21:21 +0000
Bug 1299411 - s/on/once/ in NativeApp's sendMessage r=aswan This communicates more clearly that we expect only one message/event. MozReview-Commit-ID: 8jDYBVwqQtz
2829c46a636d7a2b77a88df0b9fbe36182fa836d: Bug 1299411 - Remove extension param from NativeApp r=aswan
Rob Wu <rob@robwu.nl> - Sat, 24 Sep 2016 13:18:48 +0200 - rev 320064
Push 20749 by ryanvm@gmail.com at Sat, 29 Oct 2016 13:21:21 +0000
Bug 1299411 - Remove extension param from NativeApp r=aswan The extension is always available as `context.extension`, so do not unnecessarily pass the extension as a separate parameter. MozReview-Commit-ID: 9OaestUAGVk
57f7a5c7044db9fba2cd039773ac058b7269aac5: Bug 1299411 - Deduplicate context getter logic in ParentAPIManager r=aswan
Rob Wu <rob@robwu.nl> - Sat, 24 Sep 2016 13:10:39 +0200 - rev 320063
Push 20749 by ryanvm@gmail.com at Sat, 29 Oct 2016 13:21:21 +0000
Bug 1299411 - Deduplicate context getter logic in ParentAPIManager r=aswan MozReview-Commit-ID: E9MpHhal7WF
a9c19ee017a44aeb9953858b663a100a85ccffab: Bug 1299411 - separate serialization from sending r=aswan
Rob Wu <rob@robwu.nl> - Sat, 24 Sep 2016 13:03:20 +0200 - rev 320062
Push 20749 by ryanvm@gmail.com at Sat, 29 Oct 2016 13:21:21 +0000
Bug 1299411 - separate serialization from sending r=aswan Serialization of the message should happen in the same process as the extension context, whereas sending the message should be in the same process as the owner of the native messaging host. With webext-oop, the former is an addon process and the latter the main process. Therefore it is necessary to separate the two roles. MozReview-Commit-ID: 8BJZmn2QjLJ
0ce4a6653d1966333fa72a29f762fdde5614d02f: Bug 1299411 - Propagate errors to port.onDisconnect via port.error r=kmag
Rob Wu <rob@robwu.nl> - Fri, 30 Sep 2016 22:42:28 +0200 - rev 320061
Push 20749 by ryanvm@gmail.com at Sat, 29 Oct 2016 13:21:21 +0000
Bug 1299411 - Propagate errors to port.onDisconnect via port.error r=kmag In Chrome, runtime.lastError is set when the port is disconnected due to an error. Here in Firefox we choose to set a new property "error" on the port if the port disconnected due to an error. Since onDisconnect fires at most once, port.error is set only once. MozReview-Commit-ID: EPaVtV4WkcQ
e08ee4c2b1e2a0f9020f9a02f5c0ded4b1aa4ab2: Bug 1299411 - Unify fire and fireWithoutClone. r=kmag
Rob Wu <rob@robwu.nl> - Sat, 24 Sep 2016 11:48:43 +0200 - rev 320060
Push 20749 by ryanvm@gmail.com at Sat, 29 Oct 2016 13:21:21 +0000
Bug 1299411 - Unify fire and fireWithoutClone. r=kmag Unify implementation of fire and fireWithoutClone. `fireWithoutClone` was running the callbacks synchronously. After this commit the callback is run asynchronously. This is safe because the only user of this method is `Port`'s `onDisconnect`. MozReview-Commit-ID: 1kiYavsu3e7
502aaf0691ccecb5988d719cf904fb52c992dce3: Bug 1299411 - Pass port parameter to port.onMessage r=kmag
Rob Wu <rob@robwu.nl> - Sat, 24 Sep 2016 11:34:26 +0200 - rev 320059
Push 20749 by ryanvm@gmail.com at Sat, 29 Oct 2016 13:21:21 +0000
Bug 1299411 - Pass port parameter to port.onMessage r=kmag This should have been a part of bug 1298810, but that only set the argument for native messaging ports, which does not use Port from ExtensionUtils. The port parameter must also be included in runtime's Port.onMessage to avoid regressions when the port implementations are unified and native messaging starts using runtime's Port. Note that starting from this commit, multiple onMessage listeners receive the same (cloned) message instead of a new clone per listener. This is a side effect of using `fire.withoutClone` instead of `fire`: `fire` clones all parameters, but ports are not cloneable so we have to use `fire.withoutClone` instead. This change with regards to message cloning is fully compatible with Chrome's messaging API (which also passes the same message object to all `port.onMessage` calls). MozReview-Commit-ID: AUDuUKHkXCM
a41f871e2d1b37754bbd1001c36c075511b49342: Bug 1299411 - Decouple Port implementation from API r=aswan
Rob Wu <rob@robwu.nl> - Sat, 24 Sep 2016 11:16:32 +0200 - rev 320058
Push 20749 by ryanvm@gmail.com at Sat, 29 Oct 2016 13:21:21 +0000
Bug 1299411 - Decouple Port implementation from API r=aswan Decoupled the API from the implementation. From now on it is possible to create Port instances without generating an API. This allows us to internally use Ports to pass around messages with minimal overhead (in the form of unnecessary clones of messages). This will be used by native messaging. This commit has no behavioral change, it is mostly moving around some code and storing the internal message listener in a set. MozReview-Commit-ID: 4h0LNJvTH9R
657c36b85c688b9f77a79f796157edf87bc75a86: Bug 1311426 - Handle Grip with wrapped value in Reps. r=Honza;
Nicolas Chevobbe <chevobbe.nicolas@gmail.com> - Mon, 24 Oct 2016 07:32:32 +0200 - rev 320057
Push 20749 by ryanvm@gmail.com at Sat, 29 Oct 2016 13:21:21 +0000
Bug 1311426 - Handle Grip with wrapped value in Reps. r=Honza; Handle object created from a constructor function, like `new Boolean(true)`, `new Number(42)` or `new String("foo")`. It displays the wrapped value using Rep so the primitives are displayed like expected. MozReview-Commit-ID: JrJVeV0C0wO
b7e94b82004ec38beaf69fce2176433745b277c7: Bug 1310608 - Add a Rep for Promises. r=Honza;
Nicolas Chevobbe <chevobbe.nicolas@gmail.com> - Mon, 24 Oct 2016 19:24:10 +0200 - rev 320056
Push 20749 by ryanvm@gmail.com at Sat, 29 Oct 2016 13:21:21 +0000
Bug 1310608 - Add a Rep for Promises. r=Honza; MozReview-Commit-ID: BkeHonHQ28M
bcccdc43232ba3b6b44924605e98bff5e04af64f: Bug 1309641: only store a single pre-answer request per 5 tuple. r=bwc
Nils Ohlmeier [:drno] <drno@ohlmeier.org> - Wed, 26 Oct 2016 21:43:27 -0700 - rev 320055
Push 20749 by ryanvm@gmail.com at Sat, 29 Oct 2016 13:21:21 +0000
Bug 1309641: only store a single pre-answer request per 5 tuple. r=bwc MozReview-Commit-ID: KzrGGRRU28J
b3a08a040c8a870eb9902998d7909918cff32e2a: Bug 1252871 - Add support for runtime.onInstalled r=aswan
Matthew Wein <mwein@mozilla.com> - Wed, 19 Oct 2016 10:38:29 +0100 - rev 320054
Push 20749 by ryanvm@gmail.com at Sat, 29 Oct 2016 13:21:21 +0000
Bug 1252871 - Add support for runtime.onInstalled r=aswan MozReview-Commit-ID: 3wDtv0g0BpO
c2a511511a72010f07159a768a268c53e3090389: Bug 1252871 - Move promiseFindAddonUpdates to AddonTestUtils r=aswan
Matthew Wein <mwein@mozilla.com> - Mon, 26 Sep 2016 10:49:05 -0700 - rev 320053
Push 20749 by ryanvm@gmail.com at Sat, 29 Oct 2016 13:21:21 +0000
Bug 1252871 - Move promiseFindAddonUpdates to AddonTestUtils r=aswan MozReview-Commit-ID: 9lmpuQSQWw1
9c2c3780aa4c599699b7bc87ef15566cadc8ccf0: Bug 1252871 - Move and sort methods imported from AddonTestUtils r=aswan
Matthew Wein <mwein@mozilla.com> - Mon, 26 Sep 2016 10:36:51 -0700 - rev 320052
Push 20749 by ryanvm@gmail.com at Sat, 29 Oct 2016 13:21:21 +0000
Bug 1252871 - Move and sort methods imported from AddonTestUtils r=aswan MozReview-Commit-ID: EvffSUxQkWQ
5cb98008b3e36900ae4e786052d945c1001cb488: Bug 1309516 part 8 - modify MDSM::RecomputeDuration();r=jwwang
Kaku Kuo <kaku@mozilla.com> - Mon, 24 Oct 2016 15:04:52 +0800 - rev 320051
Push 20749 by ryanvm@gmail.com at Sat, 29 Oct 2016 13:21:21 +0000
Bug 1309516 part 8 - modify MDSM::RecomputeDuration();r=jwwang MozReview-Commit-ID: 6pM7Kn3kZco
9ddc65900391f0bdf1c42cde846cce304dd44fef: Bug 1309516 part 7 - modify the seek operation;r=jwwang
Kaku Kuo <kaku@mozilla.com> - Sun, 16 Oct 2016 22:15:29 +0800 - rev 320050
Push 20749 by ryanvm@gmail.com at Sat, 29 Oct 2016 13:21:21 +0000
Bug 1309516 part 7 - modify the seek operation;r=jwwang MozReview-Commit-ID: AZ9yK050ElM
a876261d2d38eae83fad1f84f49734ec200341ef: Bug 1309516 part 6 - remove unused MediaDecoderReaderWrapper::mStartTimeRendezvous;r=jwwang
Kaku Kuo <kaku@mozilla.com> - Fri, 14 Oct 2016 19:22:41 +0800 - rev 320049
Push 20749 by ryanvm@gmail.com at Sat, 29 Oct 2016 13:21:21 +0000
Bug 1309516 part 6 - remove unused MediaDecoderReaderWrapper::mStartTimeRendezvous;r=jwwang MozReview-Commit-ID: 6ukwUWpIJFF
a154fa107dd382275c79602102a278523c0987c2: Bug 1309516 part 5 - remove unused MediaDecoderReaderWrapper::AwaitStartTime();r=jwwang
Kaku Kuo <kaku@mozilla.com> - Fri, 14 Oct 2016 17:45:59 +0800 - rev 320048
Push 20749 by ryanvm@gmail.com at Sat, 29 Oct 2016 13:21:21 +0000
Bug 1309516 part 5 - remove unused MediaDecoderReaderWrapper::AwaitStartTime();r=jwwang MozReview-Commit-ID: CcybQMPz47i
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 tip