bfc36cc31ae93c801d600d1010692a4769d3eaff: Bug 1256589 part.4 Move the implementation of PreventDefault() and add PreventDefaultBeforeDispatch() from dom::Event to WidgetEvent r=smaug
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 22 Mar 2016 16:26:27 +0900 - rev 289988
Push 18337 by cbook@mozilla.com at Wed, 23 Mar 2016 15:30:25 +0000
Bug 1256589 part.4 Move the implementation of PreventDefault() and add PreventDefaultBeforeDispatch() from dom::Event to WidgetEvent r=smaug mDefaultPreventedByChrome is hacky. When PresShell handles Escape key events in fullscreen mode, it prevents default of every Escape key events and dispatch it only into chrome. After that, it check mDefaultPreventedByChrome if at least one call of preventDefault() occurred in chrome. Therefore, if we shouldn't set both mDefaultPreventedByChrome and mDefaultPreventedByContent to true before dispatching an event. This the reason why we need a special method, PreventDefaultBeforeDispatch() is needed for setting only mDefaultPrevented to true. MozReview-Commit-ID: BPSq68GnWw6
93b3ea492ea730775bd5c8023195a3e0a1504019: Bug 1256589 part.3 Move the implementation of StopCrossProcessForwarding() from dom::Event to WidgetEvent r=smaug
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 22 Mar 2016 16:01:46 +0900 - rev 289987
Push 18337 by cbook@mozilla.com at Wed, 23 Mar 2016 15:30:25 +0000
Bug 1256589 part.3 Move the implementation of StopCrossProcessForwarding() from dom::Event to WidgetEvent r=smaug MozReview-Commit-ID: KXeVxCJ05Mo
e8b19f55d829528f41f25a08dc8b1d18cfbbfb2b: Bug 1256589 part.2 Move the implementation of StopImmediatePropagation() from dom::Event to WidgetEvent r=smaug
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 17 Mar 2016 11:57:42 +0900 - rev 289986
Push 18337 by cbook@mozilla.com at Wed, 23 Mar 2016 15:30:25 +0000
Bug 1256589 part.2 Move the implementation of StopImmediatePropagation() from dom::Event to WidgetEvent r=smaug MozReview-Commit-ID: ERTfIhS8bBi
87b0d12a4d1c1c046b67098aad80c9089ae6f7a9: Bug 1256589 part.1 Move the implementation of StopPropagation() from dom::Event to WidgetEvent r=smaug
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 17 Mar 2016 11:17:42 +0900 - rev 289985
Push 18337 by cbook@mozilla.com at Wed, 23 Mar 2016 15:30:25 +0000
Bug 1256589 part.1 Move the implementation of StopPropagation() from dom::Event to WidgetEvent r=smaug MozReview-Commit-ID: Br5eBgC8TbW
eb458f5d7b326bd0befe11f503b592b15b10e9e7: Bug 1258175 - Remove broken -Wunreachable-code-return and -Wunreachable-code-aggressive checks. r=glandium
Chris Peterson <cpeterson@mozilla.com> - Sat, 19 Mar 2016 00:10:37 -0700 - rev 289984
Push 18337 by cbook@mozilla.com at Wed, 23 Mar 2016 15:30:25 +0000
Bug 1258175 - Remove broken -Wunreachable-code-return and -Wunreachable-code-aggressive checks. r=glandium compiler-opts.m4's check for `MOZ_CXX_SUPPORTS_WARNING(-W, unreachable-code-return, ac_cxx_has_wunreachable_code_return)` is broken. The C/C++ code that configure emits for MOZ_CXX_SUPPORTS_WARNING() actually contains a -Wunreachable-code-return warning and, thus, doesn't actually detect that clang supports the -Wunreachable-code-return flag. This configure code in MOZ_CXX_SUPPORTS_WARNING(): AC_TRY_COMPILE([], [return(0);], $3="yes", $3="no") generates something like: int main() { return(0); ; return 0; } where the second return, automatically emitted by configure, is unreachable and causes a -Wunreachable-code-return warning. The fix is to remove the redundant return(0) from MOZ_CXX_SUPPORTS_WARNING(). This allows clang's -Wunreachable-code-return flag to be detected, but then -Wunreachable-code-return breaks other configure checks, including third-party libraries' configure checks (in particular jemalloc) that also have redundant `return(0)`. So all the third-party libraries' configure checks would need to be fixed upstream, which seems like more hassle than the value of the -Wunreachable-code-return warnings.
6fd69516a3213ec6bf4c3e57b82faa40201bb6f1: Bug 1258087 - Fix -Wunreachable-code warning in StartupCache.cpp on macosx64-mulet. r=froydnj
Chris Peterson <cpeterson@mozilla.com> - Sat, 19 Mar 2016 00:10:16 -0700 - rev 289983
Push 18337 by cbook@mozilla.com at Wed, 23 Mar 2016 15:30:25 +0000
Bug 1258087 - Fix -Wunreachable-code warning in StartupCache.cpp on macosx64-mulet. r=froydnj
bbfbdaa25c6cc26f122a4eafbe84c61d381682d8: Bug 1258619 - Properly sandbox functions inside a template. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Tue, 22 Mar 2016 15:31:37 +0900 - rev 289982
Push 18337 by cbook@mozilla.com at Wed, 23 Mar 2016 15:30:25 +0000
Bug 1258619 - Properly sandbox functions inside a template. r=chmanchester The way functions are being sandboxed in moz.configure land is that their global namespace is being replaced with a limited and identifiable dict. And we avoid re-wrapping a function that already received this treatment. The problem is that template functions have their global namespace replaced, and any function that is defined within the template inherits that global namespace. So when it comes time to wrap those functions defined in templates with e.g. depends, we detect that they're already wrapped although they are not, because we look if their global namespace is of the recognizable type we use when replacing it. So instead of looking at the global namespace type, keep track of all functions that are wrapped.
9056b43dc7b12acb9a1bf9178561f28b3ffccf51: Bug 1258785 - Return a None value when check_prog doesn't find a program. r=ted
Mike Hommey <mh+mozilla@glandium.org> - Wed, 23 Mar 2016 09:48:38 +0900 - rev 289981
Push 18337 by cbook@mozilla.com at Wed, 23 Mar 2016 15:30:25 +0000
Bug 1258785 - Return a None value when check_prog doesn't find a program. r=ted
22615a6fd646b7eb53cd2d1a3be5bf3d22aa0906: Bug 1254761 - Part 3: Add tests for AnimationFilter. r=birtles
Daisuke Akatsuka <daisuke@mozilla-japan.org> - Tue, 22 Mar 2016 09:33:09 +0900 - rev 289980
Push 18337 by cbook@mozilla.com at Wed, 23 Mar 2016 15:30:25 +0000
Bug 1254761 - Part 3: Add tests for AnimationFilter. r=birtles
e5233a84bd57c99fd367bc96c286ed14bb849fd9: Bug 1254761 - Part 2: Removes extra whitespaces. r=birtles
Daisuke Akatsuka <daisuke@mozilla-japan.org> - Tue, 22 Mar 2016 09:33:05 +0900 - rev 289979
Push 18337 by cbook@mozilla.com at Wed, 23 Mar 2016 15:30:25 +0000
Bug 1254761 - Part 2: Removes extra whitespaces. r=birtles
b2bc470bfbc3409702c24838d1a0029aa961fb96: Bug 1254761 - Part 1: Implement getAnimations({ subtree: true }). r=smaug
Daisuke Akatsuka <daisuke@mozilla-japan.org> - Tue, 22 Mar 2016 09:33:02 +0900 - rev 289978
Push 18337 by cbook@mozilla.com at Wed, 23 Mar 2016 15:30:25 +0000
Bug 1254761 - Part 1: Implement getAnimations({ subtree: true }). r=smaug
038c00218cf4afd880152ecbb2f9924aaf678e3b: Bug 1258847 - Set PTHREAD_MUTEX_ERRORCHECK for js::Mutex in debug builds. r=sfink
Nick Fitzgerald <fitzgen@gmail.com> - Tue, 22 Mar 2016 15:51:00 -0400 - rev 289977
Push 18337 by cbook@mozilla.com at Wed, 23 Mar 2016 15:30:25 +0000
Bug 1258847 - Set PTHREAD_MUTEX_ERRORCHECK for js::Mutex in debug builds. r=sfink
9daacc9d25600491dacef965c3927d306deef931: Bug 1258818 - Fix bad search/replace from b411b94f8d91 (from bug 956899). r=terrence
Nick Fitzgerald <fitzgen@gmail.com> - Tue, 22 Mar 2016 12:58:00 -0400 - rev 289976
Push 18337 by cbook@mozilla.com at Wed, 23 Mar 2016 15:30:25 +0000
Bug 1258818 - Fix bad search/replace from b411b94f8d91 (from bug 956899). r=terrence
5d3a8a8f017842b11d0c2b969586b59280e20f4c: Bug 1253108 - Enable ESLint "strict" rule for PSM. r=keeler
Cykesiopka <cykesiopka.bmo@gmail.com> - Sat, 19 Mar 2016 03:07:13 -0700 - rev 289975
Push 18337 by cbook@mozilla.com at Wed, 23 Mar 2016 15:30:25 +0000
Bug 1253108 - Enable ESLint "strict" rule for PSM. r=keeler MozReview-Commit-ID: 4wElZ8Guq9z
422d5142ae422a67797f9d04488b538ebf90cbb5: Bug 772528 - Remove nsFileInputStream::Seek() from nsPartialFileInputStream::Init(). r=baku
Eden Chuang <echuang@mozilla.com> - Mon, 21 Mar 2016 10:48:59 +0800 - rev 289974
Push 18337 by cbook@mozilla.com at Wed, 23 Mar 2016 15:30:25 +0000
Bug 772528 - Remove nsFileInputStream::Seek() from nsPartialFileInputStream::Init(). r=baku
81ba35b38dc1626863841170cf5293e6d238b6bf: Bug 1257934 - Make the GeckoPreferences pref handler a static class; r=sebastian
Jim Chen <nchen@mozilla.com> - Tue, 22 Mar 2016 22:26:19 -0400 - rev 289973
Push 18337 by cbook@mozilla.com at Wed, 23 Mar 2016 15:30:25 +0000
Bug 1257934 - Make the GeckoPreferences pref handler a static class; r=sebastian The pref handler class in GeckoPreferences doesn't need a reference back to GeckoPreferences, so it's better to make it a static class rather than a (non-static) anonymous inner class, in order to avoid leaking the GeckoPreferences instance inadvertently. To avoid confusion, the patch also renames the class to "PrefCallbacks", because GeckoPreferences already has an unrelated interface named "PrefHandler".
48d6faa3bf0f8d032a43b6898222fea27eae4216: Bug 1257319 - Remove BROADCAST GeckoEvent; r=me
Jim Chen <nchen@mozilla.com> - Tue, 22 Mar 2016 22:24:32 -0400 - rev 289972
Push 18337 by cbook@mozilla.com at Wed, 23 Mar 2016 15:30:25 +0000
Bug 1257319 - Remove BROADCAST GeckoEvent; r=me Remove the now-obsolete BROADCAST GeckoEvent.
9d6577fd74f3cd1fb026623a53d18dccd4588e53: Bug 1257319 - Don't use broadcast event in AndroidContentController; r=rbarker
Jim Chen <nchen@mozilla.com> - Tue, 22 Mar 2016 22:24:31 -0400 - rev 289971
Push 18337 by cbook@mozilla.com at Wed, 23 Mar 2016 15:30:25 +0000
Bug 1257319 - Don't use broadcast event in AndroidContentController; r=rbarker We should use observer service directly instead of broadcast event.
ba16cc23d7c44fb323bab01225019740f33c046d: Bug 1257319 - Convert broadcast event usage in HomeConfig.java; r=margaret
Jim Chen <nchen@mozilla.com> - Tue, 22 Mar 2016 22:24:31 -0400 - rev 289970
Push 18337 by cbook@mozilla.com at Wed, 23 Mar 2016 15:30:25 +0000
Bug 1257319 - Convert broadcast event usage in HomeConfig.java; r=margaret HomeConfig.java saved a list of events to be sent later in a batch. This patch makes it save a pair of strings instead, and the strings are later used to make calls to GeckoAppShell. The patch also makes two small optimizations. It makes the queue an ArrayList instead of a LinkedList to save memory. It also makes copying the queue a swap instead of a true copy.
3e80b5052d0b33bdbdeb7b670d38bfeea03ac7ae: Bug 1257319 - Convert existing broadcast events to calls; r=margaret
Jim Chen <nchen@mozilla.com> - Tue, 22 Mar 2016 22:24:31 -0400 - rev 289969
Push 18337 by cbook@mozilla.com at Wed, 23 Mar 2016 15:30:25 +0000
Bug 1257319 - Convert existing broadcast events to calls; r=margaret Convert existing places where we use broadcast events to use new GeckoAppShell calls.
(0) -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip