b53e804d0aab84101e73895ee9835789818f0120: Bug 1286476 part 2 - Respect the playback rate when calculating phase boundaries; r=hiro
Brian Birtles <birtles@gmail.com> - Wed, 17 Aug 2016 08:28:41 +0900 - rev 310008
Push 20348 by ryanvm@gmail.com at Fri, 19 Aug 2016 13:56:01 +0000
Bug 1286476 part 2 - Respect the playback rate when calculating phase boundaries; r=hiro This implements the spec change in https://github.com/w3c/web-animations/commit/21de090dacc56efcc1ef7a7d04913126f96024ae The spec change refers to a binary 'animation direction' flag. Instead of that, however, we just pass the playback rate along and use it inside GetComputedTimingAt since this seems simpler. Also, this patch moves the implementation of KeyframeEffectReadOnly::GetComputedTiming from the header file into the .cpp file. This is because with this change, GetComputedTiming needs to call mAnimation->PlaybackRate() and so mozilla::dom::Animation needs to be a complete type. However, simply including Animation.h doesn't work because of a cyclic dependency between KeyframeEffect.h and Animation.h. We might be able to fix this later but since yet-to-land bug 1049975 moves this code around a lot, I'd rather not touch it too much just now. MozReview-Commit-ID: 1h6XRh4xmfI
0efdbade2f1896e0efc3a8d3de4d308f70712bb2: Bug 1286476 part 1 - Add tests for calculating animation effect phases; r=hiro
Brian Birtles <birtles@gmail.com> - Wed, 17 Aug 2016 08:23:09 +0900 - rev 310007
Push 20348 by ryanvm@gmail.com at Fri, 19 Aug 2016 13:56:01 +0000
Bug 1286476 part 1 - Add tests for calculating animation effect phases; r=hiro This test overlaps somewhat with the tests in web-animations/timing-model/animation-effects/simple-iteration-progress.html. However, these tests are more specific to just covering the phase calculation algorithm. Ultimately the tests in simple-iteration-progress.html should be broken down into separate tests for the different algorithms being tested. There is also some redundancy in these tests. For example, instead of writing: .forEach(function(test) { assert_phase_at_time(animation, test.phase, test.currentTime); }); we could just define an assert_phases_at_times function that takes the array of test cases and iterates over them. However, I think writing the test like this makes it easier to read since it requires less imagination about what assert_phases_at_times might be doing. One concern is that this test requires the setter for AnimationEffectTiming.fill to be implemented. We could rewrite this to create a new animation with the appropriate fill mode each time but I think this is probably ok. MozReview-Commit-ID: 82uvBB8bizI
5eae9f661764851b0e4599f22e5d3e09c419e1c9: Bug 1286476 part 0 - Tidy up MANIFEST.json; r=hiro
Brian Birtles <birtles@gmail.com> - Wed, 17 Aug 2016 08:23:09 +0900 - rev 310006
Push 20348 by ryanvm@gmail.com at Fri, 19 Aug 2016 13:56:01 +0000
Bug 1286476 part 0 - Tidy up MANIFEST.json; r=hiro I guess some people still aren't using ./mach web-platform-tests --manifest-update MozReview-Commit-ID: 82uvBB8bizI
96cf1604d2270859b08f59b7d53fedd4644b0b70: Bug 1294753: Flush WebM clusters if the timecode offset will over/underflow r=rillian
Randell Jesup <rjesup@jesup.org> - Thu, 18 Aug 2016 00:31:13 -0400 - rev 310005
Push 20348 by ryanvm@gmail.com at Fri, 19 Aug 2016 13:56:01 +0000
Bug 1294753: Flush WebM clusters if the timecode offset will over/underflow r=rillian
09d9b633e33568cd134efff7cc7e1432e743e381: Bug 1294753: encode all available audio on each cycle instead of one 'packet' r=rillian
Randell Jesup <rjesup@jesup.org> - Thu, 18 Aug 2016 00:31:11 -0400 - rev 310004
Push 20348 by ryanvm@gmail.com at Fri, 19 Aug 2016 13:56:01 +0000
Bug 1294753: encode all available audio on each cycle instead of one 'packet' r=rillian
252ff19cd7466770c25f0b1853fb5985670b1120: Backed out 10 changesets (bug 1290116, bug 1293690) for build bustage
Phil Ringnalda <philringnalda@gmail.com> - Wed, 17 Aug 2016 21:16:43 -0700 - rev 310003
Push 20348 by ryanvm@gmail.com at Fri, 19 Aug 2016 13:56:01 +0000
Backed out 10 changesets (bug 1290116, bug 1293690) for build bustage CLOSED TREE Backed out changeset bbc14d107fca (bug 1290116) Backed out changeset a81b6ce5c25f (bug 1290116) Backed out changeset e0b9c25b6125 (bug 1290116) Backed out changeset 8e9a9ba04ce5 (bug 1290116) Backed out changeset 2d5ad5e9ed20 (bug 1290116) Backed out changeset eb7da0dbfc72 (bug 1290116) Backed out changeset 6a4e8c92faae (bug 1290116) Backed out changeset 0342d98afa10 (bug 1293690) Backed out changeset d84b0768f0ce (bug 1293690) Backed out changeset f9f62ade9508 (bug 1293690)
aeb1e15857b375d8aa2c7b0d5d6e83965228e5c5: Bug 1291709 Make PdfjsChromeUtils.jsm use a WeakSet for tracking browsers. r=bdahl
Ben Kelly <ben@wanderview.com> - Wed, 17 Aug 2016 20:04:48 -0700 - rev 310002
Push 20348 by ryanvm@gmail.com at Fri, 19 Aug 2016 13:56:01 +0000
Bug 1291709 Make PdfjsChromeUtils.jsm use a WeakSet for tracking browsers. r=bdahl
bbc14d107fcaea5902aa9f9435a8d534448e216c: Bug 1290116 P7 Fixed activation races in push service worker tests. r=kitcambridge
Ben Kelly <ben@wanderview.com> - Wed, 17 Aug 2016 20:03:21 -0700 - rev 310001
Push 20348 by ryanvm@gmail.com at Fri, 19 Aug 2016 13:56:01 +0000
Bug 1290116 P7 Fixed activation races in push service worker tests. r=kitcambridge
a81b6ce5c25f6825cfe545afd8880df6204750f1: Bug 1290116 P6 Add a wpt test case verifying getRegistrations() does not return registrations with a pending uninstall. r=asuth
Ben Kelly <ben@wanderview.com> - Wed, 17 Aug 2016 20:03:21 -0700 - rev 310000
Push 20348 by ryanvm@gmail.com at Fri, 19 Aug 2016 13:56:01 +0000
Bug 1290116 P6 Add a wpt test case verifying getRegistrations() does not return registrations with a pending uninstall. r=asuth
e0b9c25b6125957a4148891a34cdd0c574dd9b35: Bug 1290116 P5 Make navigator.serviceWorker.getRegistrations() ignore uninstalling registrations. r=asuth
Ben Kelly <ben@wanderview.com> - Wed, 17 Aug 2016 20:03:21 -0700 - rev 309999
Push 20348 by ryanvm@gmail.com at Fri, 19 Aug 2016 13:56:01 +0000
Bug 1290116 P5 Make navigator.serviceWorker.getRegistrations() ignore uninstalling registrations. r=asuth
8e9a9ba04ce57dd5d8217336f2a982dc61555940: Bug 1290116 P4 Verify that unregister waits for active worker to go idle. r=asuth
Ben Kelly <ben@wanderview.com> - Wed, 17 Aug 2016 20:03:21 -0700 - rev 309998
Push 20348 by ryanvm@gmail.com at Fri, 19 Aug 2016 13:56:01 +0000
Bug 1290116 P4 Verify that unregister waits for active worker to go idle. r=asuth
2d5ad5e9ed200a03facf9da83f359370c767c1d1: Bug 1290116 P3 Delay removing registration until active worker is idle. r=asuth
Ben Kelly <ben@wanderview.com> - Wed, 17 Aug 2016 20:03:21 -0700 - rev 309997
Push 20348 by ryanvm@gmail.com at Fri, 19 Aug 2016 13:56:01 +0000
Bug 1290116 P3 Delay removing registration until active worker is idle. r=asuth
eb7da0dbfc72afb09e4fc0a452938af78c2047ca: Bug 1290116 P2 Clean up ServiceWorkerManager::StopControllingADocument(). r=asuth
Ben Kelly <ben@wanderview.com> - Wed, 17 Aug 2016 20:03:20 -0700 - rev 309996
Push 20348 by ryanvm@gmail.com at Fri, 19 Aug 2016 13:56:01 +0000
Bug 1290116 P2 Clean up ServiceWorkerManager::StopControllingADocument(). r=asuth
6a4e8c92faae09e2499010c73748bf40d036bcf5: Bug 1290116 P1 Expose a ServiceWorkerRegistrationInfo::IsIdle() method. r=asuth
Ben Kelly <ben@wanderview.com> - Wed, 17 Aug 2016 20:03:20 -0700 - rev 309995
Push 20348 by ryanvm@gmail.com at Fri, 19 Aug 2016 13:56:01 +0000
Bug 1290116 P1 Expose a ServiceWorkerRegistrationInfo::IsIdle() method. r=asuth
0342d98afa10d1d4d7403bb4ab3242fe5415ddb4: Bug 1293690 P3 Force all callers of HoldWorker to provide an explicit status code that triggers failure. r=baku
Ben Kelly <ben@wanderview.com> - Wed, 17 Aug 2016 20:01:35 -0700 - rev 309994
Push 20348 by ryanvm@gmail.com at Fri, 19 Aug 2016 13:56:01 +0000
Bug 1293690 P3 Force all callers of HoldWorker to provide an explicit status code that triggers failure. r=baku
d84b0768f0ce3939b847fb65fcbaff3b8b255d99: Bug 1293690 P2 Set explicit status levels to fail at when calling WorkerHolder::HoldWorker. r=baku
Ben Kelly <ben@wanderview.com> - Wed, 17 Aug 2016 20:01:35 -0700 - rev 309993
Push 20348 by ryanvm@gmail.com at Fri, 19 Aug 2016 13:56:01 +0000
Bug 1293690 P2 Set explicit status levels to fail at when calling WorkerHolder::HoldWorker. r=baku
f9f62ade9508990ab40c6110c1a048e58bda9a8f: Bug 1293690 P1 Allow WorkerHolder::HoldWorker() callers to specify the status value they consider to be a failure. r=baku
Ben Kelly <ben@wanderview.com> - Wed, 17 Aug 2016 20:01:35 -0700 - rev 309992
Push 20348 by ryanvm@gmail.com at Fri, 19 Aug 2016 13:56:01 +0000
Bug 1293690 P1 Allow WorkerHolder::HoldWorker() callers to specify the status value they consider to be a failure. r=baku
60d87f0123753020660ee74cfc447df859593339: Bug 1295079 - check if FcPattern creation fails in gfxFontconfigFontEntry::CreateFontInstance. r=jfkthame
Lee Salzman <lsalzman@mozilla.com> - Wed, 17 Aug 2016 12:01:01 -0400 - rev 309991
Push 20348 by ryanvm@gmail.com at Fri, 19 Aug 2016 13:56:01 +0000
Bug 1295079 - check if FcPattern creation fails in gfxFontconfigFontEntry::CreateFontInstance. r=jfkthame MozReview-Commit-ID: 1dFKnP4rQgx
df38e89c572044e53ef457b0446adf92b40745dd: Merge m-c to inbound a=merge
Wes Kocher <wkocher@mozilla.com> - Wed, 17 Aug 2016 17:24:02 -0700 - rev 309990
Push 20348 by ryanvm@gmail.com at Fri, 19 Aug 2016 13:56:01 +0000
Merge m-c to inbound a=merge
0f4e45fb0783fa00590bf1cced405ed15cba76d7: Bug 1240134 - Fixup TarFinder test on Windows by closing the TarFile after the test. r=me
Chris Manchester <cmanchester@mozilla.com> - Wed, 17 Aug 2016 16:12:14 -0700 - rev 309989
Push 20348 by ryanvm@gmail.com at Fri, 19 Aug 2016 13:56:01 +0000
Bug 1240134 - Fixup TarFinder test on Windows by closing the TarFile after the test. r=me MozReview-Commit-ID: EbP4o5XLCeB
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 tip