Backed out changeset 73c0af3f3693 (bug 1251855) because the fix is no longer needed since bug 1232639 landed on Gecko 47+.
authorRyan VanderMeulen <ryanvm@gmail.com>
Thu, 31 Mar 2016 23:07:18 -0400
changeset 291184 fceee99ec164f23f18b5f88649912ada60dd0e41
parent 291183 2bcb11fae866b7d1446f6f0d2334f20bc6985c5b
child 291185 abe2031a710e675ca6407af0ea168960f2ac8d04
push id19656
push usergwagner@mozilla.com
push dateMon, 04 Apr 2016 13:43:23 +0000
treeherderb2g-inbound@e99061fde28a [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1251855, 1232639
milestone48.0a1
backs out73c0af3f36939971564f1210aeee2cfbbfddc3b0
Backed out changeset 73c0af3f3693 (bug 1251855) because the fix is no longer needed since bug 1232639 landed on Gecko 47+.
js/xpconnect/tests/chrome/test_xrayToJS.xul
--- a/js/xpconnect/tests/chrome/test_xrayToJS.xul
+++ b/js/xpconnect/tests/chrome/test_xrayToJS.xul
@@ -20,19 +20,16 @@ https://bugzilla.mozilla.org/show_bug.cg
 
   /** Test for ES constructors on Xrayed globals. **/
   SimpleTest.waitForExplicitFinish();
   const Cc = Components.classes;
   const Ci = Components.interfaces;
   const Cu = Components.utils;
   let global = Cu.getGlobalForObject.bind(Cu);
 
-  /** Needed for AppConstants.RELEASE_BUILD usage further down **/
-  Cu.import("resource://gre/modules/AppConstants.jsm")
-
   function checkThrows(f, rgxp, msg) {
     try {
       f();
       ok(false, "Should have thrown: " + msg);
     } catch (e) {
       ok(true, "Threw as expected: " + msg);
       ok(rgxp.test(e), "Message correct: " + e);
     }
@@ -168,29 +165,23 @@ https://bugzilla.mozilla.org/show_bug.cg
     "toISOString", "toJSON", "toSource", "toString", "valueOf", "constructor",
     "toGMTString", Symbol.toPrimitive];
   gConstructorProperties['Date'] = constructorProps(["UTC", "parse", "now"]);
   gPrototypeProperties['Object'] =
     ["constructor", "toSource", "toString", "toLocaleString", "valueOf", "watch",
      "unwatch", "hasOwnProperty", "isPrototypeOf", "propertyIsEnumerable",
      "__defineGetter__", "__defineSetter__", "__lookupGetter__", "__lookupSetter__",
      "__proto__"];
-
-  /** Bug 1251855 - "entries" and "values" are not exposed to release builds **/
   gConstructorProperties['Object'] =
     constructorProps(["setPrototypeOf", "getOwnPropertyDescriptor", "keys",
                       "is", "defineProperty", "defineProperties", "create",
                       "getOwnPropertyNames", "getOwnPropertySymbols",
                       "preventExtensions", "freeze", "isFrozen", "seal",
-                      "isSealed", "assign", "getPrototypeOf", "isExtensible"])
-  if (!AppConstants.RELEASE_BUILD) {
-    gConstructorProperties['Object'] = 
-      gConstructorProperties['Object'].concat(["values", "entries"]);
-  }
-
+                      "isSealed", "assign", "getPrototypeOf", "values",
+                      "entries", "isExtensible"])
   gPrototypeProperties['Array'] =
     ["length", "toSource", "toString", "toLocaleString", "join", "reverse", "sort", "push",
       "pop", "shift", "unshift", "splice", "concat", "slice", "lastIndexOf", "indexOf",
       "includes", "forEach", "map", "reduce", "reduceRight", "filter", "some", "every", "find",
       "findIndex", "copyWithin", "fill", Symbol.iterator, Symbol.unscopables, "entries", "keys",
       "values", "constructor"];
   gConstructorProperties['Array'] =
     constructorProps(["join", "reverse", "sort", "push", "pop", "shift",