Bug 1220309 - Have GeckoApp extend AppCompatActivity. r=sebastian
authorMichael Comella <michael.l.comella@gmail.com>
Fri, 30 Oct 2015 12:14:00 -0700
changeset 289902 dabb7828c1eeffc152bf66f69472d078b4f86964
parent 289901 8f2121d6764a413e0f7e6c004d787be7303d2a7e
child 289903 34227dc37f69cb1d156d401d5cdf5cfb4a4bc91e
push id19656
push usergwagner@mozilla.com
push dateMon, 04 Apr 2016 13:43:23 +0000
treeherderb2g-inbound@e99061fde28a [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerssebastian
bugs1220309
milestone48.0a1
Bug 1220309 - Have GeckoApp extend AppCompatActivity. r=sebastian We're using the Theme.AppCompat styles so we have to extend AppCompatActivity. It is a subclass of the previous class GeckoApp extended so we shouldn't run into an ClassCastExceptions. I tested the home panels, tabs tray, hyperlink long-press context menus, door hangers, the 3-dot menu, and browser search to make sure there was no change in UI appearance. MozReview-Commit-ID: FvaOFTMFOMa
mobile/android/base/java/org/mozilla/gecko/GeckoActivity.java
--- a/mobile/android/base/java/org/mozilla/gecko/GeckoActivity.java
+++ b/mobile/android/base/java/org/mozilla/gecko/GeckoActivity.java
@@ -1,19 +1,19 @@
 /* This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this file,
  * You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 package org.mozilla.gecko;
 
 import android.content.ComponentName;
 import android.content.Intent;
-import android.support.v4.app.FragmentActivity;
+import android.support.v7.app.AppCompatActivity;
 
-public class GeckoActivity extends FragmentActivity implements GeckoActivityStatus {
+public class GeckoActivity extends AppCompatActivity implements GeckoActivityStatus {
     // has this activity recently started another Gecko activity?
     private boolean mGeckoActivityOpened;
 
     /**
      * Display any resources that show strings or encompass locale-specific
      * representations.
      *
      * onLocaleReady must always be called on the UI thread.