Bug 1258594 (Followup) - Rename FrameProperties::IsSet() to FrameProperties::Has(). r=dbaron
authorSeth Fowler <mark.seth.fowler@gmail.com>
Fri, 25 Mar 2016 14:49:42 -0700
changeset 290504 cb8b0d8e3ddfc3fb61c6ca4aa3a1dfb1b5711cee
parent 290503 f87d50f9757747dc07215b022cb993312306e21b
child 290505 2d171d75b7464583358fcfb7524617ad5dce6a6f
push id19656
push usergwagner@mozilla.com
push dateMon, 04 Apr 2016 13:43:23 +0000
treeherderb2g-inbound@e99061fde28a [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdbaron
bugs1258594
milestone48.0a1
Bug 1258594 (Followup) - Rename FrameProperties::IsSet() to FrameProperties::Has(). r=dbaron
layout/base/FramePropertyTable.h
--- a/layout/base/FramePropertyTable.h
+++ b/layout/base/FramePropertyTable.h
@@ -182,21 +182,21 @@ public:
    * you're doing a lookup anyway it would be far more efficient to call Get()
    * or Remove() and check the aFoundResult outparam to find out whether the
    * property is set. Legitimate non-assertion uses include:
    *
    *   - Checking if a frame property is set in cases where that's all we want
    *     to know (i.e., we don't intend to read the actual value or remove the
    *     property).
    *
-   *   - Calling IsSet() before Set() in cases where we don't want to overwrite
+   *   - Calling Has() before Set() in cases where we don't want to overwrite
    *     an existing value for the frame property.
    */
   template<typename T>
-  bool IsSet(const nsIFrame* aFrame, Descriptor<T> aProperty)
+  bool Has(const nsIFrame* aFrame, Descriptor<T> aProperty)
   {
     bool foundResult = false;
     mozilla::Unused << GetInternal(aFrame, aProperty, &foundResult);
     return foundResult;
   }
 
   /**
    * Get a property value for a frame. This requires one hashtable
@@ -384,19 +384,19 @@ public:
 
   template<typename T>
   void Set(Descriptor<T> aProperty, PropertyType<T> aValue) const
   {
     mTable->Set(mFrame, aProperty, aValue);
   }
 
   template<typename T>
-  bool IsSet(Descriptor<T> aProperty) const
+  bool Has(Descriptor<T> aProperty) const
   {
-    return mTable->IsSet(mFrame, aProperty);
+    return mTable->Has(mFrame, aProperty);
   }
 
   template<typename T>
   PropertyType<T> Get(Descriptor<T> aProperty,
                       bool* aFoundResult = nullptr) const
   {
     return mTable->Get(mFrame, aProperty, aFoundResult);
   }