Bug 1260749 - quiet unpacking of Android SDK and NDK downloads; r=nalexander
authorNathan Froyd <froydnj.com>
Wed, 30 Mar 2016 10:46:14 -0400
changeset 291450 cb1e8b892715d0d1377caa9f80f27b2d2000f973
parent 291449 5edbf0d674ed9a0029cdc2c386cf48973eda8f3a
child 291451 4678a49486b3fe0a75c9a8aabc14fd4e43ec4c85
push id19656
push usergwagner@mozilla.com
push dateMon, 04 Apr 2016 13:43:23 +0000
treeherderb2g-inbound@e99061fde28a [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersnalexander
bugs1260749
milestone48.0a1
Bug 1260749 - quiet unpacking of Android SDK and NDK downloads; r=nalexander We send the output to /dev/null or equivalent, but there's no need to generate a bunch of extraneous output and consume cycles unnecessarily.
python/mozboot/mozboot/android.py
--- a/python/mozboot/mozboot/android.py
+++ b/python/mozboot/mozboot/android.py
@@ -162,21 +162,21 @@ def install_mobile_android_sdk_or_ndk(ur
 
         os.chdir(download_path)
         subprocess.check_call(['wget', '--continue', url])
         file = url.split('/')[-1]
 
         os.chdir(path)
         abspath = os.path.join(download_path, file)
         if file.endswith('.tar.gz') or file.endswith('.tgz'):
-            cmd = ['tar', 'zvxf', abspath]
+            cmd = ['tar', 'zxf', abspath]
         elif file.endswith('.tar.bz2'):
-            cmd = ['tar', 'jvxf', abspath]
+            cmd = ['tar', 'jxf', abspath]
         elif file.endswith('.zip'):
-            cmd = ['unzip', abspath]
+            cmd = ['unzip', '-q', abspath]
         elif file.endswith('.bin'):
             # Execute the .bin file, which unpacks the content.
             mode = os.stat(path).st_mode
             os.chmod(abspath, mode | stat.S_IXUSR)
             cmd = [abspath]
         else:
             raise NotImplementedError("Don't know how to unpack file: %s" % file)