Bug 1259428 - part 6 - remove unneeded MessageDecl methods; r=jld
authorNathan Froyd <froydnj.com>
Mon, 28 Mar 2016 11:43:54 -0400
changeset 291449 5edbf0d674ed9a0029cdc2c386cf48973eda8f3a
parent 291448 cb6dee617908f71f565946ca2ee78e446b01948c
child 291450 cb1e8b892715d0d1377caa9f80f27b2d2000f973
push id19656
push usergwagner@mozilla.com
push dateMon, 04 Apr 2016 13:43:23 +0000
treeherderb2g-inbound@e99061fde28a [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjld
bugs1259428
milestone48.0a1
Bug 1259428 - part 6 - remove unneeded MessageDecl methods; r=jld msgCast and replyCast were only used for the dodgy casts we removed in part 2; the msgCxxType was only called by msgCast.
ipc/ipdl/ipdl/lower.py
--- a/ipc/ipdl/ipdl/lower.py
+++ b/ipc/ipdl/ipdl/lower.py
@@ -919,36 +919,26 @@ class MessageDecl(ipdl.ast.MessageDecl):
         return 'Msg_%s'% (self.decl.progname)
 
     def prettyMsgName(self, pfx=''):
         return pfx + self.msgClass()
 
     def pqMsgClass(self):
         return '%s::%s'% (self.namespace, self.msgClass())
 
-    def msgCast(self, msgexpr):
-        return ExprCast(msgexpr, self.msgCxxType(const=1, ptr=1), static=1)
-
-    def msgCxxType(self, const=0, ref=0, ptr=0):
-        return Type(self.pqMsgClass(), const=const, ref=ref, ptr=ptr)
-
     def msgId(self):  return self.msgClass()+ '__ID'
     def pqMsgId(self):
         return '%s::%s'% (self.namespace, self.msgId())
 
     def replyClass(self):
         return 'Reply_%s'% (self.decl.progname)
 
     def pqReplyClass(self):
         return '%s::%s'% (self.namespace, self.replyClass())
 
-    def replyCast(self, replyexpr):
-        return ExprCast(replyexpr, Type(self.pqReplyClass(), const=1, ptr=1),
-                        static=1)
-
     def replyId(self):  return self.replyClass()+ '__ID'
     def pqReplyId(self):
         return '%s::%s'% (self.namespace, self.replyId())
 
     def prettyReplyName(self, pfx=''):
         return pfx + self.replyClass()
 
     def actorDecl(self):