Bug 1261122 - don't needlessly construct nsAutoCString temporaries in dom/indexedDB; r=khuey
We can make ScriptErrorRunnable::DumpLocalized take an nsACString instead.
--- a/dom/indexedDB/ScriptErrorHelper.cpp
+++ b/dom/indexedDB/ScriptErrorHelper.cpp
@@ -62,31 +62,31 @@ public:
, mInnerWindowID(aInnerWindowID)
, mIsChrome(aIsChrome)
{
MOZ_ASSERT(!NS_IsMainThread());
mMessage.SetIsVoid(true);
}
static void
- DumpLocalizedMessage(const nsCString& aMessageName,
+ DumpLocalizedMessage(const nsACString& aMessageName,
const nsAString& aFilename,
uint32_t aLineNumber,
uint32_t aColumnNumber,
uint32_t aSeverityFlag,
bool aIsChrome,
uint64_t aInnerWindowID)
{
MOZ_ASSERT(NS_IsMainThread());
MOZ_ASSERT(!aMessageName.IsEmpty());
nsXPIDLString localizedMessage;
if (NS_WARN_IF(NS_FAILED(
nsContentUtils::GetLocalizedString(nsContentUtils::eDOM_PROPERTIES,
- aMessageName.get(),
+ aMessageName.BeginReading(),
localizedMessage)))) {
return;
}
Dump(localizedMessage,
aFilename,
aLineNumber,
aColumnNumber,
@@ -219,17 +219,17 @@ ScriptErrorHelper::DumpLocalizedMessage(
const nsAString& aFilename,
uint32_t aLineNumber,
uint32_t aColumnNumber,
uint32_t aSeverityFlag,
bool aIsChrome,
uint64_t aInnerWindowID)
{
if (NS_IsMainThread()) {
- ScriptErrorRunnable::DumpLocalizedMessage(nsAutoCString(aMessageName),
+ ScriptErrorRunnable::DumpLocalizedMessage(aMessageName,
aFilename,
aLineNumber,
aColumnNumber,
aSeverityFlag,
aIsChrome,
aInnerWindowID);
} else {
RefPtr<ScriptErrorRunnable> runnable =