Bug 1182769 - about:preferences# is not filtered out on the home page list. r=jaws
authorGiovanny Andres Gongora Granada <gioyik@gmail.com>
Fri, 24 Jul 2015 22:13:00 +0200
changeset 254751 1372fb8872a16321fead0614ba5ede0ac194cbf3
parent 254732 4791b25ea75bfe1ac5259ead3036a03d75824635
child 254752 00bc6fe33be0f4481a52b47d1e1447130e37745b
push id16720
push userryanvm@gmail.com
push dateMon, 27 Jul 2015 19:45:38 +0000
treeherderb2g-inbound@13354b414396 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjaws
bugs1182769
milestone42.0a1
Bug 1182769 - about:preferences# is not filtered out on the home page list. r=jaws
browser/components/preferences/in-content/main.js
--- a/browser/components/preferences/in-content/main.js
+++ b/browser/components/preferences/in-content/main.js
@@ -363,28 +363,28 @@ var gMainPane = {
     win = wm.getMostRecentWindow("navigator:browser");
 
     if (win && win.document.documentElement
                   .getAttribute("windowtype") == "navigator:browser") {
       // We should only include visible & non-pinned tabs
 
       tabs = win.gBrowser.visibleTabs.slice(win.gBrowser._numPinnedTabs);
       
-      tabs = tabs.filter(this.isAboutPreferences);
+      tabs = tabs.filter(this.isNotAboutPreferences);
     }
     
     return tabs;
   },
   
   /**
    * Check to see if a tab is not about:preferences
    */
-  isAboutPreferences: function (aElement, aIndex, aArray)
+  isNotAboutPreferences: function (aElement, aIndex, aArray)
   {
-    return (aElement.linkedBrowser.currentURI.spec != "about:preferences");
+    return (aElement.linkedBrowser.currentURI.spec.startsWith != "about:preferences");
   },
 
   /**
    * Restores the default home page as the user's home page.
    */
   restoreDefaultHomePage: function ()
   {
     var homePage = document.getElementById("browser.startup.homepage");