searching for reviewer(seth)
9adc763aae7608252bb3e9df1ef7888da4f9f2ba: Bug 1260247. In chaos mode randomly decide to start a new image load even if the image is in the image cache when allowed by spec. r=seth
Timothy Nikkel <tnikkel@gmail.com> - Sat, 02 Apr 2016 13:53:12 -0500 - rev 291488
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1260247. In chaos mode randomly decide to start a new image load even if the image is in the image cache when allowed by spec. r=seth If the image load is from the same document that cached the image we are required to use the cached version. Otherwise we should be free to ignore the cached version.
5005b1604f269e2204260bdff4b26a92564e42f6: Bug 1222596. If RasterImage::LookupFrame does (some) sync decoding and encouters an error we don't want to return the surface with an error. r=seth
Timothy Nikkel <tnikkel@gmail.com> - Fri, 01 Apr 2016 12:44:17 -0500 - rev 291288
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1222596. If RasterImage::LookupFrame does (some) sync decoding and encouters an error we don't want to return the surface with an error. r=seth If the sync decoding the LookupFrame does encounters an error it will set mError on the RasterImage, which LookupFrame callers check before calling LookupFrame. But they've called LookupFrame before the error was encountered, so we check if the frame has had Abort called on it to determine if we should return it at all. We only does this if one of the sync decode flags was passed in because IsAborted needs to get the imgFrame's monitor, so we don't want to block consumers that haven't asked for decoding.
0ce8b97e0e6921dde82f2eb30b33ba4042e822df: Bug 1209780. Use the DrawResult return value of imgIContainer::Draw in the cocoa code. r=seth
Timothy Nikkel <tnikkel@gmail.com> - Tue, 29 Mar 2016 01:14:45 -0500 - rev 290902
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1209780. Use the DrawResult return value of imgIContainer::Draw in the cocoa code. r=seth
603181ac9e84f9a4a8dd6471e880860088f1d813: Bug 1242256 - ensure images in patterns and masks animate properly. r=jwatt,seth
Robert Longson <longsonr@gmail.com> - Sat, 26 Mar 2016 16:07:03 +0000 - rev 290571
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1242256 - ensure images in patterns and masks animate properly. r=jwatt,seth
c75b2b195f28a5ed556a7dfc12e9b45bc56c971a: Bug 1257101. imgFrame::IsImageComplete says whether we've had pixels decoded to the whole image rect, but it's used to check if the frame is finished decoding. These are different things when the image has more than one progress pass. r=seth
Timothy Nikkel <tnikkel@gmail.com> - Wed, 23 Mar 2016 19:31:42 -0500 - rev 290221
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1257101. imgFrame::IsImageComplete says whether we've had pixels decoded to the whole image rect, but it's used to check if the frame is finished decoding. These are different things when the image has more than one progress pass. r=seth This means that in RasterImage::LookupFrame when we are asked to do a sync decode (if needed) we use WaitUntilComplete to wait until the frame is finished decoding. But we would actually return after the next progressive pass notified the monitor to wake up. Thus, we would draw a not-fully-decoded image even though the sync decode flag was passed. The change in FrameAnimator means that we won't draw the next frame in an animated image until all progressive passes of that image are complete. This seems like what we want anyways. There is one real use of IsImageComplete left, in imgFrame::Draw, where we need to know if the decoded image data covers the whole image frame. (There are a couple of uses of IsImageComplete in asserts.)
699c1d51d6f340c42501afaaec76129384dd6fb2: Bug 1210745. Change image progress asserts to allow transparency to be posted after the size is posted. r=seth
Timothy Nikkel <tnikkel@gmail.com> - Mon, 21 Mar 2016 16:15:20 -0500 - rev 289772
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1210745. Change image progress asserts to allow transparency to be posted after the size is posted. r=seth The PNG decoder posts the size almost immediately, and later posts transparency (even for non-animated images). It would be nice to still assert what this assert is intending (that transparency of non-animated images is posted during the metadata decode) but we don't have any easy way of telling when a metadata finishes here.
25ce690ffebc8a1a8e2d59038ecf7259606e0348: Bug 1209780. Mark some DrawResult's as unused in layout/svg. r=seth
Timothy Nikkel <tnikkel@gmail.com> - Mon, 21 Mar 2016 16:15:19 -0500 - rev 289768
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1209780. Mark some DrawResult's as unused in layout/svg. r=seth We want to turn on the static analysis so no new violations are introduced. Fixing these is not straight forward.
697e9a5b3ae28bf6b56001dfbf7f90fdb0fccdf8: Bug 1234077 - Test that GIFs are still drawn correctly when their frame rects are truncated - r=seth
Edwin Flores <eflores@mozilla.com> - Tue, 15 Mar 2016 10:31:31 +0000 - rev 288826
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1234077 - Test that GIFs are still drawn correctly when their frame rects are truncated - r=seth
e7b960c2c8e989ff09ab11b2fd9aa725a60fd432: Bug 1234077 - Test that GIFs are still drawn correctly when their frame rects are truncated - r=seth
Edwin Flores <eflores@mozilla.com> - Mon, 14 Mar 2016 18:26:38 +0000 - rev 288671
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1234077 - Test that GIFs are still drawn correctly when their frame rects are truncated - r=seth
eceb5235a54da29b7280153f0a130eece3682d4e: Bug 1230907 - mPixelRowSize added to constructor with 0 value. r=seth
Bogdan Postelnicu <bogdan.postelnicu@softvision.ro> - Mon, 14 Mar 2016 10:36:36 +0200 - rev 288608
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1230907 - mPixelRowSize added to constructor with 0 value. r=seth
0028f61d45266d0fdfe9c597a06274ba2c5eeac0: Bug 1209780. Check DrawResult return value in nsBaseDragService. r=seth
Timothy Nikkel <tnikkel@gmail.com> - Thu, 10 Mar 2016 00:37:18 -0600 - rev 288132
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1209780. Check DrawResult return value in nsBaseDragService. r=seth
7f0d53575f39344b275a420c96eeb11fe813464b: Bug 1203417. Propagate error result from PaintTableFrame. r=seth
Robert O'Callahan <robert@ocallahan.org> - Sat, 13 Feb 2016 09:30:27 +1300 - rev 288042
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1203417. Propagate error result from PaintTableFrame. r=seth MozReview-Commit-ID: 4rRkHXUl9iE
7596f7088006b1580595c4200e436d0ee177c643: Bug 1209780. Propagate the use of MOZ_MUST_USE DrawResult in nsTablePainter. r=seth
Timothy Nikkel <tnikkel@gmail.com> - Wed, 09 Mar 2016 17:56:35 -0600 - rev 288041
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1209780. Propagate the use of MOZ_MUST_USE DrawResult in nsTablePainter. r=seth
82073af0177dab32d1049cf067f6057a4de0ff54: Bug 1209780. Propagate the use of MOZ_MUST_USE DrawResult in nsTreeBodyFrame::PaintText. r=seth
Timothy Nikkel <tnikkel@gmail.com> - Wed, 09 Mar 2016 17:56:35 -0600 - rev 288040
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1209780. Propagate the use of MOZ_MUST_USE DrawResult in nsTreeBodyFrame::PaintText. r=seth
d8190cbce7b0b188ec678da1a1ec1a190c5da636: Bug 1050342. Fix a case where the fast huffman decoder in libjpeg-turbo can produce different results depending on how data is fed to it. r=seth
Noel Gordon <noel.gordon@gmail.com> - Wed, 09 Mar 2016 17:56:35 -0600 - rev 288039
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1050342. Fix a case where the fast huffman decoder in libjpeg-turbo can produce different results depending on how data is fed to it. r=seth This change comes from the blink repo https://codereview.appspot.com/229430043/ and is unlikely to be accepted upstream into libjpeg-turbo.
5d03f2103664bbc4b024fe73213883f32afe8535: Bug 619500: Part 1. Default sizing for specified size of SVG images which have no constraints; r=dholbert r=seth
CJKu <cku@mozilla.com> - Tue, 08 Mar 2016 15:54:13 +0800 - rev 287554
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 619500: Part 1. Default sizing for specified size of SVG images which have no constraints; r=dholbert r=seth MozReview-Commit-ID: 8DI86w6Ni8T
b6c044f6319540c2b939af5d986583c2ec14f8fd: Bug 1220082 - Assign frame ids to animated images so that they get invalidated correctly. r=seth
Matt Woodrow <mwoodrow@mozilla.com> - Tue, 12 Jan 2016 17:14:09 +1300 - rev 287194
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 1220082 - Assign frame ids to animated images so that they get invalidated correctly. r=seth
a5d2e586777cdef660d7e625a5253669fd8b33ec: Bug 1220082 - Assign frame ids to animated images so that they get invalidated correctly. r=seth
Matt Woodrow <mwoodrow@mozilla.com> - Tue, 12 Jan 2016 17:14:09 +1300 - rev 287038
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 1220082 - Assign frame ids to animated images so that they get invalidated correctly. r=seth
25b27835c872681a8e97ba1ba27fd5e0acd398d8: Bug 1192376: Make nsImageBoxFrame check whether image size is available before trying to paint an image. r=seth
Daniel Holbert <dholbert@cs.stanford.edu> - Mon, 29 Feb 2016 15:09:13 -0800 - rev 286536
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 1192376: Make nsImageBoxFrame check whether image size is available before trying to paint an image. r=seth
39a1e216208199904ef3a562eb5d643efc08223d: Bug 1251808 - Construct the SourceSurfaceImage with the correct size in RasterImage::GetCurrentImage(). r=seth
Seth Fowler <mark.seth.fowler@gmail.com> - Fri, 26 Feb 2016 21:01:50 -0800 - rev 286277
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 1251808 - Construct the SourceSurfaceImage with the correct size in RasterImage::GetCurrentImage(). r=seth
ea5b889ec09da916f50cb9af50bbafba8ce7e718: Bug 1230757 - Update the minimum version of libpng to 1.6.21. r=seth
Glenn Randers-Pehrson <glennrp+bmo@gmail.com> - Fri, 26 Feb 2016 08:27:00 -0500 - rev 286192
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 1230757 - Update the minimum version of libpng to 1.6.21. r=seth DONTBUILD
0b3813f906c1fbe669a887801a7b59de87956e6c: Bug 1230757 - Update the minimum version of libpng to 1.6.21. r=seth
Glenn Randers-Pehrson <glennrp+bmo@gmail.com> - Fri, 26 Feb 2016 07:56:00 -0500 - rev 286187
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 1230757 - Update the minimum version of libpng to 1.6.21. r=seth
be199e2f9e395d870a48d6e5bdc20bb12372e6a5: Bug 1230757 - Update in-tree libpng to version 1.6.21. r=seth
Glenn Randers-Pehrson <glennrp+bmo@gmail.com> - Sat, 16 Jan 2016 09:27:00 -0500 - rev 286186
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 1230757 - Update in-tree libpng to version 1.6.21. r=seth
9727cdebb2eeb25a1d9452b7fa5e0583e879d0af: Bug 1228314 - added static_cast<int64> in order to avoid overflow. r=seth
Bogdan Postelnicu <bogdan.postelnicu@softvision.ro> - Mon, 18 Jan 2016 17:23:23 +0200 - rev 286048
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 1228314 - added static_cast<int64> in order to avoid overflow. r=seth MozReview-Commit-ID: KY3qpIlzE5K
7ff06ac4e4c0114ef50dc8418e8d9785d5ab9bf1: Bug 1172796 - Part 1: ImageEncoder can be used on worker thread. r=seth
Morris Tseng <mtseng@mozilla.com> - Fri, 18 Dec 2015 14:52:17 +0800 - rev 276902
Push 19029 by cbook@mozilla.com at Fri, 18 Dec 2015 14:31:22 +0000
Bug 1172796 - Part 1: ImageEncoder can be used on worker thread. r=seth
a69d71324577f4f1b86ee1951ef44fa98c641c92: Bug 1223465 - Clamp GIF frame rects to their screen rects - r=seth
Edwin Flores <eflores@mozilla.com> - Wed, 25 Nov 2015 13:50:13 +0000 - rev 274238
Push 18812 by cbook@mozilla.com at Thu, 26 Nov 2015 15:56:59 +0000
Bug 1223465 - Clamp GIF frame rects to their screen rects - r=seth
e6be119a536c0ea5a1c33a9e4f4437fdd4476a5f: Bug 1224100 - Initialize row buffer to 0 in Downscaler - r=seth
Edwin Flores <eflores@mozilla.com> - Tue, 24 Nov 2015 15:05:01 +0000 - rev 274237
Push 18812 by cbook@mozilla.com at Thu, 26 Nov 2015 15:56:59 +0000
Bug 1224100 - Initialize row buffer to 0 in Downscaler - r=seth
37ecff04dcd1a4bddd218248c2b46c90feab5407: Bug 1220021 (part 2) - Add four reftests. r=seth.
Nicholas Nethercote <nnethercote@mozilla.com> - Mon, 23 Nov 2015 18:20:21 -0800 - rev 274116
Push 18795 by cbook@mozilla.com at Wed, 25 Nov 2015 13:00:44 +0000
Bug 1220021 (part 2) - Add four reftests. r=seth.
0a5b47980443ed37150929e0a477f74aa570185c: Bug 1220021 (part 1) - Don't treat 0RGB ICO files as transparent. r=seth.
Nicholas Nethercote <nnethercote@mozilla.com> - Mon, 23 Nov 2015 15:32:39 -0800 - rev 274115
Push 18795 by cbook@mozilla.com at Wed, 25 Nov 2015 13:00:44 +0000
Bug 1220021 (part 1) - Don't treat 0RGB ICO files as transparent. r=seth. This approach is much the same as the one we had before bug 1062066 caused the regression.
e79cd09c87da4ad08dbabd817e7c97077ad0daa5: Bug 1223319 (part 1) - Remove unused function nsICODecoder::CalcAlphaRowSize(). r=seth.
Nicholas Nethercote <nnethercote@mozilla.com> - Mon, 16 Nov 2015 17:54:11 -0800 - rev 274114
Push 18795 by cbook@mozilla.com at Wed, 25 Nov 2015 13:00:44 +0000
Bug 1223319 (part 1) - Remove unused function nsICODecoder::CalcAlphaRowSize(). r=seth.
9257f9006397eceffe3045e3507ade4c600a5d8e: Bug 1224244 - Update in-tree libpng to version 1.6.19. r=seth
Glenn Randers-Pehrson <glennrp+bmo@gmail.com> - Mon, 23 Nov 2015 20:20:00 +0100 - rev 273947
Push 18784 by kwierso@gmail.com at Wed, 25 Nov 2015 00:58:10 +0000
Bug 1224244 - Update in-tree libpng to version 1.6.19. r=seth
421e725a39d24f60009f191a477ba78399aabe0c: Bug 75077 - Interpolate interlaced PNG images instead of libpng blocky display. r=seth
Glenn Randers-Pehrson <glennrp+bmo@gmail.com> - Sat, 14 Nov 2015 11:33:00 +0100 - rev 273946
Push 18784 by kwierso@gmail.com at Wed, 25 Nov 2015 00:58:10 +0000
Bug 75077 - Interpolate interlaced PNG images instead of libpng blocky display. r=seth
cae5c087063d54c80a13fc3f4914320a17febd97: Bug 1221840. Support repeating images in 1 axis. r=seth
Mason Chang <mchang@mozilla.com> - Mon, 23 Nov 2015 08:17:35 -0800 - rev 273853
Push 18784 by kwierso@gmail.com at Wed, 25 Nov 2015 00:58:10 +0000
Bug 1221840. Support repeating images in 1 axis. r=seth
48011a9ee633d1e65362a5710bda30145f0f2b9b: Bug 1219474 - Replace PRLogModuleInfo w/ LazyLogModule in the 'image/' directory. r=seth
sajitk <sajitk@rocketmail.com> - Mon, 16 Nov 2015 18:21:00 +0100 - rev 272942
Push 18696 by kwierso@gmail.com at Tue, 17 Nov 2015 21:23:39 +0000
Bug 1219474 - Replace PRLogModuleInfo w/ LazyLogModule in the 'image/' directory. r=seth
793133ff5233a8e2cd0a6864b9984f5a9bb31c05: Bug 1210291 - Streamline StreamingLexer's handling of terminal states. r=seth.
Nicholas Nethercote <nnethercote@mozilla.com> - Wed, 28 Oct 2015 01:30:20 -0700 - rev 272919
Push 18696 by kwierso@gmail.com at Tue, 17 Nov 2015 21:23:39 +0000
Bug 1210291 - Streamline StreamingLexer's handling of terminal states. r=seth. This patch introduces TerminalState and changes LexerTransition::mNextState to be a Variant<State, TerminalState>. This means that SUCCESS and FAILURE no longer need to be part of State. Some things to note: - This simplifies the handling of Lex()'s return value, which is nice. - The patch splits Terminate() into TerminateSuccess() and TerminateFailure(). - |const State& aNextState| wouldn't work for the first arg to LexerTransition's ctor due to errors in Variant construction that I didn't understand. I had to change it to |State aNextState|.
951e77fb1760a8f2047fe7f83217f69f480181a2: Bug 1217465 - Fill in missing pixels caused by truncated BMP files. r=seth.
Nicholas Nethercote <nnethercote@mozilla.com> - Sun, 15 Nov 2015 20:31:07 -0800 - rev 272746
Push 18690 by kwierso@gmail.com at Tue, 17 Nov 2015 01:27:55 +0000
Bug 1217465 - Fill in missing pixels caused by truncated BMP files. r=seth. This fixes failures for image/test/reftest/bmp/bmpsuite/b/{badrle.bmp,shortfile.bmp} with the Skia back-end.
2d0012628fce7ad775d48957449c62d23cdb5d1f: Bug 1217571 - fix the imagelib cache to work in e10s; r=seth
Nathan Froyd <froydnj@mozilla.com> - Thu, 12 Nov 2015 15:09:52 -0500 - rev 272404
Push 18658 by cbook@mozilla.com at Fri, 13 Nov 2015 13:39:58 +0000
Bug 1217571 - fix the imagelib cache to work in e10s; r=seth nsICachingChannel isn't available in the child process; we have to use nsICacheInfoChannel instead.
53ace8875ad5c262cb0c38e3c9c58eb24185f1ca: Bug 1222298 - GFX: 2D: Make convolverLS3 more like upstream. r=seth
Heiher <r@hev.cc> - Thu, 12 Nov 2015 19:43:17 +0800 - rev 272314
Push 18642 by kwierso@gmail.com at Fri, 13 Nov 2015 00:27:17 +0000
Bug 1222298 - GFX: 2D: Make convolverLS3 more like upstream. r=seth --- gfx/2d/convolverLS3.cpp | 62 +++++++++++++++++++++++++------------------------ gfx/2d/convolverLS3.h | 4 +--- 2 files changed, 33 insertions(+), 33 deletions(-)
e5f60475c16b0518fd226da2b5823a91bb7cd2a0: Bug 1219501. Limit total number of image decoding threads to 32 regardless of number asked for. r=seth
Timothy Nikkel <tnikkel@gmail.com> - Sun, 01 Nov 2015 11:45:40 -0600 - rev 270674
Push 18433 by cbook@mozilla.com at Mon, 02 Nov 2015 11:06:43 +0000
Bug 1219501. Limit total number of image decoding threads to 32 regardless of number asked for. r=seth
accf0dbda8bb6f8a4509078479ef50e0099060cb: Bug 1219501. In imagelib, initialize the number of cores to at least 1 in case of error. r=seth
Timothy Nikkel <tnikkel@gmail.com> - Sun, 01 Nov 2015 11:45:40 -0600 - rev 270673
Push 18433 by cbook@mozilla.com at Mon, 02 Nov 2015 11:06:43 +0000
Bug 1219501. In imagelib, initialize the number of cores to at least 1 in case of error. r=seth PR_GetNumberOfProcessors returns -1 in case of error, which is MAXUINT32 when turned into an unsigned int like sNumCores.
765d51aa96c7fe3be4d5cb4ec0533481ddfeb7f9: Bug 1219405 - use LazyLogModule for PNG decoder logging; r=seth
Nathan Froyd <froydnj@mozilla.com> - Wed, 28 Oct 2015 16:08:06 -0400 - rev 270582
Push 18433 by cbook@mozilla.com at Mon, 02 Nov 2015 11:06:43 +0000
Bug 1219405 - use LazyLogModule for PNG decoder logging; r=seth This change eliminates some TSan warnings and also eliminates some boilerplate.
e08508d502c88b8f95baa1b8e72f159d6d27934d: Bug 1202085 - Part 6: Clear the entries in the image cache belonging to a controlled document when it gets destroyed; r=seth
Ehsan Akhgari <ehsan@mozilla.com> - Wed, 28 Oct 2015 16:01:07 -0400 - rev 270563
Push 18433 by cbook@mozilla.com at Mon, 02 Nov 2015 11:06:43 +0000
Bug 1202085 - Part 6: Clear the entries in the image cache belonging to a controlled document when it gets destroyed; r=seth
afc27ae3cc45dc1b157c45ce59bca844eac84551: Bug 1202085 - Part 4: Add an ID for controlled document to the image cache key; r=seth
Ehsan Akhgari <ehsan@mozilla.com> - Tue, 27 Oct 2015 14:12:46 -0400 - rev 270561
Push 18433 by cbook@mozilla.com at Mon, 02 Nov 2015 11:06:43 +0000
Bug 1202085 - Part 4: Add an ID for controlled document to the image cache key; r=seth This ID will be null for non-controlled documents and also for image cache entries for which a document is not available, and it will be the numerical value of the document pointer for controlled documents. This effectively makes sure that a controlled document doesn't share its image cache entries with anything else.
0095ad1a7b09099a205cd8a9a9df9cc890ceb0bb: Bug 1202085 - Part 2: Add an optional document argument to imgICache::FindEntryProperties(); r=seth
Ehsan Akhgari <ehsan@mozilla.com> - Mon, 26 Oct 2015 16:03:26 -0400 - rev 270559
Push 18433 by cbook@mozilla.com at Mon, 02 Nov 2015 11:06:43 +0000
Bug 1202085 - Part 2: Add an optional document argument to imgICache::FindEntryProperties(); r=seth
9c5e6d68cc4617b747393ad64e22fb2255899bad: Bug 1202085 - Part 1: Remove imgICache::RemoveEntry(); r=seth
Ehsan Akhgari <ehsan@mozilla.com> - Mon, 26 Oct 2015 16:02:52 -0400 - rev 270558
Push 18433 by cbook@mozilla.com at Mon, 02 Nov 2015 11:06:43 +0000
Bug 1202085 - Part 1: Remove imgICache::RemoveEntry(); r=seth
0f2acb5edb41591a1c109eac293ee16ec3c6e38b: Bug 1214476 - Remove unused code for encoding BMPv2 files. r=seth.
Nicholas Nethercote <nnethercote@mozilla.com> - Wed, 14 Oct 2015 14:47:29 -0700 - rev 270109
Push 18380 by cbook@mozilla.com at Thu, 29 Oct 2015 11:16:36 +0000
Bug 1214476 - Remove unused code for encoding BMPv2 files. r=seth. nsBMPEncoder produces either BMPv3 or BMPv5 files. (See the Version enum which only has VERSION_3 and VERSION_5 values, and ParseOptions()'s handling of the |version| parameter. Nonetheless, there is some code to handle encoding of BMPv2 files. This patch removes this.
625650d1493c70dfec06a77757faf97a99b18bb0: Bug 1218041, part 1: Give nsTreeBodyFrame::PaintImage a fallback codepath for painting SVG images with no explicit height or width. r=seth
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 28 Oct 2015 08:49:07 -0700 - rev 270020
Push 18374 by kwierso@gmail.com at Thu, 29 Oct 2015 00:08:44 +0000
Bug 1218041, part 1: Give nsTreeBodyFrame::PaintImage a fallback codepath for painting SVG images with no explicit height or width. r=seth
6928d7087fedeeeb6cdcff2ddb5eba14ff96163b: Bug 1215361 (part 3) - Deconvolute nsICODecoder's handling of endianness. r=seth.
Nicholas Nethercote <nnethercote@mozilla.com> - Thu, 15 Oct 2015 17:54:41 -0700 - rev 269910
Push 18358 by cbook@mozilla.com at Wed, 28 Oct 2015 09:53:47 +0000
Bug 1215361 (part 3) - Deconvolute nsICODecoder's handling of endianness. r=seth. nsICODecoder's reading and writing of little-endian values can be simplified greatly. Also, ReadBPP() was highly dodgy: BMP's bpp field is 16-bit but ReadBPP() read it as if it's 32-bit. I think this currently works because the bpp field is followed by the 32-bit compression field which is usually 0 for BMPs within ICOs!
1c6abaa798f99f17827cb06088fc371336b3b879: Bug 1215361 (part 2) - Streamline nsBMPDecoder's getters. r=seth.
Nicholas Nethercote <nnethercote@mozilla.com> - Thu, 15 Oct 2015 17:38:32 -0700 - rev 269909
Push 18358 by cbook@mozilla.com at Wed, 28 Oct 2015 09:53:47 +0000
Bug 1215361 (part 2) - Streamline nsBMPDecoder's getters. r=seth. - GetBitsPerPixel() and GetWidth() are no longer used. - GetHeight() is now only used within nsBMPDecoder and can be renamed and inlined into the header. - GetImageData() can be inlined into the header.
a4c60957e505a114a77646670576a03c09033f1c: Bug 1215361 (part 1) - Don't set mBPP twice in nsICODecoder.cpp. r=seth.
Nicholas Nethercote <nnethercote@mozilla.com> - Thu, 15 Oct 2015 17:35:21 -0700 - rev 269908
Push 18358 by cbook@mozilla.com at Wed, 28 Oct 2015 09:53:47 +0000
Bug 1215361 (part 1) - Don't set mBPP twice in nsICODecoder.cpp. r=seth. Seth's "XXX" comment is correct.