searching for reviewer(sebastian)
8afd00a026c41cb6bfbad5a3df8b7fac7f0dcaec: Bug 1255394 - Restrictions: Fix java package. r=sebastian
Mouaad <Aallam.Mouaad@gmail.com> - Thu, 31 Mar 2016 17:30:43 +0200 - rev 291378
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1255394 - Restrictions: Fix java package. r=sebastian MozReview-Commit-ID: XzS7bSaXhW
af73f5dcd1b1d8f13fbf718b223a0e546b8498ff: Bug 1220928 - Update test references to old history panel. r=sebastian
Chenxia Liu <liuche@mozilla.com> - Wed, 30 Mar 2016 17:32:11 -0700 - rev 291332
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1220928 - Update test references to old history panel. r=sebastian MozReview-Commit-ID: 6A2ukiEcBO8
251bd4b73f611357597860acc356d665d5ffcf95: Bug 1220928 - Handle configuration changes. r=sebastian
Chenxia Liu <liuche@mozilla.com> - Mon, 28 Mar 2016 17:02:16 -0700 - rev 291331
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1220928 - Handle configuration changes. r=sebastian MozReview-Commit-ID: E5MoWlcMCdj
c63615d8c252e55111fbb35daec7f0f35a53b73d: Bug 1220928 - Remove old History and Synced Tabs panel for uncustomized home panels. r=sebastian
Chenxia Liu <liuche@mozilla.com> - Mon, 28 Mar 2016 15:58:16 -0700 - rev 291330
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1220928 - Remove old History and Synced Tabs panel for uncustomized home panels. r=sebastian MozReview-Commit-ID: G3hIeoiiNs5
c5cdf619cd2e8f1e6b5891c443f5d9f0ef38466d: Bug 1220928 - Handle back button when in client's child view. r=sebastian
Chenxia Liu <liuche@mozilla.com> - Mon, 28 Mar 2016 12:04:03 -0700 - rev 291329
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1220928 - Handle back button when in client's child view. r=sebastian MozReview-Commit-ID: BDiyR5JCHQD
72040ea10a6105007ce10cee52bb038d3e92a504: Bug 1220928 - Add client hiding/showing. r=sebastian
Chenxia Liu <liuche@mozilla.com> - Tue, 29 Mar 2016 17:10:33 -0700 - rev 291328
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1220928 - Add client hiding/showing. r=sebastian MozReview-Commit-ID: IvyrslMqTOT
d55a8f609a81a1c199232886b94a85419398d5c3: Bug 1220928 - Add context menu. r=sebastian
Chenxia Liu <liuche@mozilla.com> - Wed, 23 Mar 2016 18:36:13 -0700 - rev 291327
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1220928 - Add context menu. r=sebastian MozReview-Commit-ID: CQ01edJs3vP
0242801375876b7f7a711546f543f361282c4ece: Bug 1220928 - Add section headers. r=sebastian
Chenxia Liu <liuche@mozilla.com> - Thu, 17 Mar 2016 00:18:37 -0700 - rev 291326
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1220928 - Add section headers. r=sebastian MozReview-Commit-ID: ItbC1yEJY4D
5539cc5e598073da1b0d53a35596f00bca92cff5: Bug 1220928 - Add empty state. r=sebastian
Chenxia Liu <liuche@mozilla.com> - Tue, 15 Mar 2016 11:45:21 -0700 - rev 291325
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1220928 - Add empty state. r=sebastian MozReview-Commit-ID: Ger04bA0aaC
1ee51352897e5ed2e1d0f1277c35937758c5d42e: Bug 1220928 - Align synced clients with history items. r=sebastian
Chenxia Liu <liuche@mozilla.com> - Thu, 10 Mar 2016 17:29:22 -0800 - rev 291324
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1220928 - Align synced clients with history items. r=sebastian MozReview-Commit-ID: KDz13cm8okc
60cd54c9bf895b1abccc89a3234a149f9277d314: Bug 1220928 - Add dividers. r=sebastian
Chenxia Liu <liuche@mozilla.com> - Wed, 09 Mar 2016 17:49:08 -0800 - rev 291323
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1220928 - Add dividers. r=sebastian MozReview-Commit-ID: KYzvrB1YEsA
fe241494b578e688550de433b8b6d838863af7f8: Bug 1220928 - Add footerbar button. r=sebastian
Chenxia Liu <liuche@mozilla.com> - Thu, 25 Feb 2016 18:25:55 -0800 - rev 291322
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1220928 - Add footerbar button. r=sebastian MozReview-Commit-ID: 6R0RWsSljji
1139e8f7b278942800183d18d10ba17b937b6642: Bug 1220928 - Add remote client children. r=sebastian
Chenxia Liu <liuche@mozilla.com> - Tue, 15 Mar 2016 15:51:56 -0700 - rev 291321
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1220928 - Add remote client children. r=sebastian MozReview-Commit-ID: F5DYHrR5p99
df8b8021d41939f362f013a70239d827d505dffd: Bug 1220928 - Open links for history. r=sebastian
Chenxia Liu <liuche@mozilla.com> - Tue, 29 Mar 2016 17:17:08 -0700 - rev 291320
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1220928 - Open links for history. r=sebastian MozReview-Commit-ID: KCXDHb3UEy9
82af1bb19859da55d3ea73012d02a70d5b428c80: Bug 1220928 - Make static viewType to ItemType converter. r=sebastian
Chenxia Liu <liuche@mozilla.com> - Wed, 24 Feb 2016 16:13:18 -0800 - rev 291319
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1220928 - Make static viewType to ItemType converter. r=sebastian MozReview-Commit-ID: CIOxLFaQIIo
da52ef729a4ba7457bd456f0352f9117ea4cf2fa: Bug 1220928 - Clients and history loading. r=sebastian
Chenxia Liu <liuche@mozilla.com> - Wed, 24 Feb 2016 14:27:55 -0800 - rev 291318
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1220928 - Clients and history loading. r=sebastian MozReview-Commit-ID: 1lCKVQH54C3
c3b0d96c232954b2213768992448ec1391f750ee: Bug 1220928 - Add RecyclerView boilerplate. r=sebastian
Chenxia Liu <liuche@mozilla.com> - Tue, 23 Feb 2016 11:00:42 -0800 - rev 291317
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1220928 - Add RecyclerView boilerplate. r=sebastian MozReview-Commit-ID: xaRLs8JxMs
53b8d9973481a0795c30e6daeac2fae25f8b51ae: Bug 1258450 - Move references to SnackbarHelper out of GeckoAppShell. r=snorp,sebastian
Nick Alexander <nalexander@mozilla.com> - Wed, 30 Mar 2016 10:21:29 -0700 - rev 291307
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1258450 - Move references to SnackbarHelper out of GeckoAppShell. r=snorp,sebastian The existing code assumes an Activity, not just a Context, but doesn't statically guarantee it. This patch is safe because it dynamically type-checks, but it would be better to declare the member to be an Activity. MozReview-Commit-ID: 9AigV055I5j
0476a0d0575b4b07c404eb15bc5a943ae04d0289: Bug 1258450 - Move references to SnackbarHelper out of GeckoAppShell. r=snorp,sebastian
Nick Alexander <nalexander@mozilla.com> - Sun, 20 Mar 2016 14:41:39 -0700 - rev 290843
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1258450 - Move references to SnackbarHelper out of GeckoAppShell. r=snorp,sebastian The existing code assumes an Activity, not just a Context, but doesn't statically guarantee it. This patch is safe because it dynamically type-checks, but it would be better to declare the member to be an Activity. MozReview-Commit-ID: 9AigV055I5j
c1a1079daea1be3b0beb8e63e6d41956a1f5642d: Bug 1220928 - Handle configuration changes. r=sebastian
Chenxia Liu <liuche@mozilla.com> - Mon, 28 Mar 2016 17:02:16 -0700 - rev 290837
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1220928 - Handle configuration changes. r=sebastian MozReview-Commit-ID: E5MoWlcMCdj
ac7d8d5ec09e45261cc73392e65f996fed4df909: Bug 1220928 - Remove old History and Synced Tabs panel for uncustomized home panels. r=sebastian
Chenxia Liu <liuche@mozilla.com> - Mon, 28 Mar 2016 15:58:16 -0700 - rev 290836
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1220928 - Remove old History and Synced Tabs panel for uncustomized home panels. r=sebastian MozReview-Commit-ID: G3hIeoiiNs5
916fb74ed491c4f492d97bb4bbc5b8f786cd223f: Bug 1220928 - Handle back button when in client's child view. r=sebastian
Chenxia Liu <liuche@mozilla.com> - Mon, 28 Mar 2016 12:04:03 -0700 - rev 290835
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1220928 - Handle back button when in client's child view. r=sebastian MozReview-Commit-ID: BDiyR5JCHQD
81b90ed9ff464c38667488a5d4892728a802bdb0: Bug 1220928 - Add client hiding/showing. r=sebastian
Chenxia Liu <liuche@mozilla.com> - Tue, 29 Mar 2016 17:10:33 -0700 - rev 290834
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1220928 - Add client hiding/showing. r=sebastian MozReview-Commit-ID: IvyrslMqTOT
b2828872f3e78911798083fde9b196e7206aaf19: Bug 1220928 - Add context menu. r=sebastian
Chenxia Liu <liuche@mozilla.com> - Wed, 23 Mar 2016 18:36:13 -0700 - rev 290833
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1220928 - Add context menu. r=sebastian MozReview-Commit-ID: CQ01edJs3vP
671ce80172a02706f96b033d188d308e9e369b14: Bug 1220928 - Add section headers. r=sebastian
Chenxia Liu <liuche@mozilla.com> - Thu, 17 Mar 2016 00:18:37 -0700 - rev 290832
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1220928 - Add section headers. r=sebastian MozReview-Commit-ID: ItbC1yEJY4D
4fc2017aee7551aa582577445d9448462f4f7837: Bug 1220928 - Add empty state. r=sebastian
Chenxia Liu <liuche@mozilla.com> - Tue, 15 Mar 2016 11:45:21 -0700 - rev 290831
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1220928 - Add empty state. r=sebastian MozReview-Commit-ID: Ger04bA0aaC
f2a5f6a248ed41b7313a27662c223ed801e0b13c: Bug 1220928 - Align synced clients with history items. r=sebastian
Chenxia Liu <liuche@mozilla.com> - Thu, 10 Mar 2016 17:29:22 -0800 - rev 290830
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1220928 - Align synced clients with history items. r=sebastian MozReview-Commit-ID: KDz13cm8okc
4502901213737dd4a9a6373347b0e396602a4da1: Bug 1220928 - Add dividers. r=sebastian
Chenxia Liu <liuche@mozilla.com> - Wed, 09 Mar 2016 17:49:08 -0800 - rev 290829
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1220928 - Add dividers. r=sebastian MozReview-Commit-ID: KYzvrB1YEsA
297774d61b596cb1fd55bed9de2ba7578f9c81e7: Bug 1220928 - Add footerbar button. r=sebastian
Chenxia Liu <liuche@mozilla.com> - Thu, 25 Feb 2016 18:25:55 -0800 - rev 290828
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1220928 - Add footerbar button. r=sebastian MozReview-Commit-ID: 6R0RWsSljji
875fbe8190d373075e85eaf5dd692f707cdcdcfa: Bug 1220928 - Add remote client children. r=sebastian
Chenxia Liu <liuche@mozilla.com> - Tue, 15 Mar 2016 15:51:56 -0700 - rev 290827
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1220928 - Add remote client children. r=sebastian MozReview-Commit-ID: F5DYHrR5p99
6220841fe652e4711e0a31b4bd0f5f7a358b7a6b: Bug 1220928 - Open links for history. r=sebastian
Chenxia Liu <liuche@mozilla.com> - Tue, 29 Mar 2016 17:17:08 -0700 - rev 290826
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1220928 - Open links for history. r=sebastian MozReview-Commit-ID: KCXDHb3UEy9
f464c44bf88255e4aafe3fa64900aa13c0905339: Bug 1220928 - Make static viewType to ItemType converter. r=sebastian
Chenxia Liu <liuche@mozilla.com> - Wed, 24 Feb 2016 16:13:18 -0800 - rev 290825
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1220928 - Make static viewType to ItemType converter. r=sebastian MozReview-Commit-ID: CIOxLFaQIIo
ceb669fb17f23763eb4f9cfc53ad74d011e842a5: Bug 1220928 - Clients and history loading. r=sebastian
Chenxia Liu <liuche@mozilla.com> - Wed, 24 Feb 2016 14:27:55 -0800 - rev 290824
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1220928 - Clients and history loading. r=sebastian MozReview-Commit-ID: 1lCKVQH54C3
d64938914b3ed77c22ba4559b01d92907056b438: Bug 1220928 - Add RecyclerView boilerplate. r=sebastian
Chenxia Liu <liuche@mozilla.com> - Tue, 23 Feb 2016 11:00:42 -0800 - rev 290823
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1220928 - Add RecyclerView boilerplate. r=sebastian MozReview-Commit-ID: xaRLs8JxMs
ee11a508dd472945960264b5ca777dccc5961bdf: Bug 1249288 - review: Correct concurrency issues with searchEngineManager. r=sebastian
Michael Comella <michael.l.comella@gmail.com> - Thu, 24 Mar 2016 11:18:58 -0700 - rev 290807
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1249288 - review: Correct concurrency issues with searchEngineManager. r=sebastian Additionally, added WeakReferences to the SEM in its callbacks so we can GC ASAP if the Activity (and thus the SEM) gets GC'd. This is important since we hold a reference to Context which can be a rather large object. Furthermore, I added some related thread annotations where I felt they were useful. MozReview-Commit-ID: KaWlw14uOoN
416d7925fc2df25bb85e26bee3fd78605a312566: Bug 1249491 - Add health report client ID migration test. r=sebastian,gfritzche
Michael Comella <michael.l.comella@gmail.com> - Thu, 24 Mar 2016 16:13:40 -0700 - rev 290800
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1249491 - Add health report client ID migration test. r=sebastian,gfritzche MozReview-Commit-ID: 9QbkKwEoNwq
1e683499ef1155866eb34b57d01b0e8c0e337fa3: Bug 1249491 - Write java/js integration test for retrieving telemetry client ID. r=sebastian
Michael Comella <michael.l.comella@gmail.com> - Thu, 24 Mar 2016 15:39:31 -0700 - rev 290799
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1249491 - Write java/js integration test for retrieving telemetry client ID. r=sebastian MozReview-Commit-ID: 4aczKEwRNkD
08685d4867990cf629a57baaeeb24f66575cd296: Bug 1249491 - Move getTestProfile to BaseRobocopTest. r=sebastian
Michael Comella <michael.l.comella@gmail.com> - Mon, 14 Mar 2016 16:44:30 -0700 - rev 290798
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1249491 - Move getTestProfile to BaseRobocopTest. r=sebastian MozReview-Commit-ID: 17IM5fo78no
14c2f0dda69563fabc9a19c6aa1d076ae59592be: Bug 1249491 - Add JavascriptBridgeTest.getBlockingFromJsString and friends. r=sebastian
Michael Comella <michael.l.comella@gmail.com> - Fri, 25 Mar 2016 14:34:19 -0700 - rev 290797
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1249491 - Add JavascriptBridgeTest.getBlockingFromJsString and friends. r=sebastian MozReview-Commit-ID: JzG9WhZcXrp
bc476c66d225412b0aaace0de9e06e3d1eaef15b: Bug 1258703 - avoid null pointer dereference on |subject|. r=sebastian
Andi-Bogdan Postelnicu <bogdan.postelnicu@softvision.ro> - Wed, 23 Mar 2016 13:21:55 +0200 - rev 290102
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1258703 - avoid null pointer dereference on |subject|. r=sebastian MozReview-Commit-ID: 1LIxfWu7jEW
916b9e55af42072542d08f713af748b45c616d36: Bug 1254468 - Post: Remove unused TransitionsTracker r=sebastian
Andrzej Hunt <andrzej@ahunt.org> - Tue, 15 Mar 2016 09:06:46 -0700 - rev 290096
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1254468 - Post: Remove unused TransitionsTracker r=sebastian This is no longer needed - TransitionAwareCursorLoaderCallbacks was the only consumer - it was removed as it caused race conditions. The ideal future solution is probably to use recyclerviews to avoid jank, rather than trying to wait for transitions to happen. It's also extremely difficult to use this correctly - the TransitionAwareCursorLoaderCallbacks simply held the cursor that would usually be swapped in onLoadFinished until transitions have finished (which is incorrect, since cursors need to be swapped in before onLoadFinished returns). It's hard to imagine any alternative solutions, short of avoiding loading cursors in the first place (which isn't too useful, since cursor loading happens in the background, at which point the UI status is irrelevant), or hacking the CursorLoader to not return from its worker thread until UI transitions are done (which would require a new thread-safe implementation of TransitionsTracker), or maybe even hacking Android Framework's AsyncTaskLoader to not run Loader.deliverResult while transitions are running (which seems awfully brittle and hacky). MozReview-Commit-ID: 3JWDcznYL4Y
adb1d935641a9ce58b9ea0d9f7bd06c63fc192b3: Bug 1254468 - Remove broken TransitionAwareCursorLoaderCallbacks r=sebastian
Andrzej Hunt <andrzej@ahunt.org> - Mon, 14 Mar 2016 15:38:53 -0700 - rev 290095
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1254468 - Remove broken TransitionAwareCursorLoaderCallbacks r=sebastian TransitionAwareCursorLoaderCallbacks is fundamentally flawed: old CursorLoader cursors _must_ not be used after onLoadFinished has been called. However we sometimes queue the cursor swapping (which is implemented by subclasses in onLoadFinishedAfterTransitions) until after transitions have finished. CursorLoader.deliverResult() closes the old cursor immediately after calling onLoadFinished (with the new cursor). At this stage the adapter is still holding onto the old (but now closed cursor), and will crash if it tries to read this cursor (which can happen if the adapter is still iterating over the cursor). Instead we should ensure that we swap the cursors during onLoadFinished - the simplest way to do this is by eliminating TransitionAwareCursorLoader and using onLoadFinished the way the Android framework expects. It's worth noting that TransitionAwareCursorLoader is obsolete: at the time it was added, home panels were placed in the HomePagerTabStrip, which notified TransitionsTracker about its transitions. However HomePagerTabStrip no longer exists, hence there's no need for us to care about these transitions anymore. (The crash seems to happen because we try to hide the doorhanger every time we receive LOCATION_CHANGE, and each of these starts a hide transition - even if no doorhanger is shown - hence we often have a transition in progress every time we show topsites.) MozReview-Commit-ID: HsytLpHOrp2
57572ba7a904bde259fa2f5a841cc06e7c816a55: Bug 1256427 - Move to AtomicFile in framework from support lib. r=sebastian
Michael Comella <michael.l.comella@gmail.com> - Wed, 23 Mar 2016 10:30:52 -0700 - rev 290094
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1256427 - Move to AtomicFile in framework from support lib. r=sebastian MozReview-Commit-ID: 6DOKydvvSGJ
358a57aa077a81210fd12e1fb8fa4e6ec0039fdd: Bug 1256427 - Move to LruCache in framework from support lib. r=sebastian
Michael Comella <michael.l.comella@gmail.com> - Wed, 23 Mar 2016 10:29:25 -0700 - rev 290093
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1256427 - Move to LruCache in framework from support lib. r=sebastian MozReview-Commit-ID: HImxvIVjIhw
81ba35b38dc1626863841170cf5293e6d238b6bf: Bug 1257934 - Make the GeckoPreferences pref handler a static class; r=sebastian
Jim Chen <nchen@mozilla.com> - Tue, 22 Mar 2016 22:26:19 -0400 - rev 290028
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1257934 - Make the GeckoPreferences pref handler a static class; r=sebastian The pref handler class in GeckoPreferences doesn't need a reference back to GeckoPreferences, so it's better to make it a static class rather than a (non-static) anonymous inner class, in order to avoid leaking the GeckoPreferences instance inadvertently. To avoid confusion, the patch also renames the class to "PrefCallbacks", because GeckoPreferences already has an unrelated interface named "PrefHandler".
34227dc37f69cb1d156d401d5cdf5cfb4a4bc91e: Bug 1220309 - Correct all caps button text in Button from AppCompat. r=sebastian
Michael Comella <michael.l.comella@gmail.com> - Tue, 15 Dec 2015 11:26:33 -0800 - rev 289903
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1220309 - Correct all caps button text in Button from AppCompat. r=sebastian AppCompat capitalizes all text in `Button`s so we have to override that behavior to maintain the same UI. Ideally, we do this through `android:buttonStyle` but the place I found the issue doesn't inherit from that style so we can't and we change the style directly. There may be issues with other `Button`s, but this is the only one I found. MozReview-Commit-ID: JQoIlPa9oZD
dabb7828c1eeffc152bf66f69472d078b4f86964: Bug 1220309 - Have GeckoApp extend AppCompatActivity. r=sebastian
Michael Comella <michael.l.comella@gmail.com> - Fri, 30 Oct 2015 12:14:00 -0700 - rev 289902
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1220309 - Have GeckoApp extend AppCompatActivity. r=sebastian We're using the Theme.AppCompat styles so we have to extend AppCompatActivity. It is a subclass of the previous class GeckoApp extended so we shouldn't run into an ClassCastExceptions. I tested the home panels, tabs tray, hyperlink long-press context menus, door hangers, the 3-dot menu, and browser search to make sure there was no change in UI appearance. MozReview-Commit-ID: FvaOFTMFOMa
ecf81bf18bdf7939aa0e70e698c40dbcb9dcb7b4: Bug 1256615 - Partially restore removed <activity-alias>. r=sebastian
Nick Alexander <nalexander@mozilla.com> - Mon, 21 Mar 2016 13:42:08 -0700 - rev 289824
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1256615 - Partially restore removed <activity-alias>. r=sebastian Bug 1242213 removed the entire <activity-alias>. Sadly, users who added the Firefox icon to their dock (for example, Samsung's Touchwiz dock) will see the icon disappear when they upgrade, because the intent filter disappears. (That is, the icon is connected to .App and action MAIN, not to the package and action MAIN.) This patch restores the .App <activity-alias> for action MAIN. It doesn't add the launcher and other categories, which could lead to multiple launcher icons. New users that add the Firefox icon to their dock will use .BrowserApp, but sadly we'll need to maintain this alias essentially forever to support existing dock icons. MozReview-Commit-ID: 1o9XS5MEs1s
bca2e4c24f17403364997638d9356c6a63ffafec: Bug 1213147 - Use Roboto Light for title in Share Overlay dialog on API 16+. r=sebastian
Shatur<tushar.saini1285@gmail.com> - Tue, 15 Mar 2016 22:01:15 +0530 - rev 289822
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1213147 - Use Roboto Light for title in Share Overlay dialog on API 16+. r=sebastian MozReview-Commit-ID: 8X8Rv1GCPk2
a42ef90399bd6a848fb839647ea328e9453ffe5f: Bug 1258452 - Explicitly request READ_EXTERNAL_STORAGE permission. r=sebastian
Nick Alexander <nalexander@mozilla.com> - Mon, 14 Mar 2016 14:23:56 -0700 - rev 289646
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1258452 - Explicitly request READ_EXTERNAL_STORAGE permission. r=sebastian This permission was added in API 16, and is only enforced in API 19+. (It's benign to add it to APKs installed on API 15.) We want to declare it explicitly so that the bouncer APK and the main APK have the same permission set. There appears to be some fanciness with Gradle's implied permission system where the bouncer APK does not request READ implicitly where-as the main APK does request READ implicitly. This just makes things explicit (and uniform). MozReview-Commit-ID: LBblAPa0duV