searching for reviewer(rnewman)
a8cb004e06e7c61c6ca3676e2c0d33773882e702: Bug 1201059 - Synchronize catalog of downloadable content from Kinto instance. r=rnewman,mathieu
Sebastian Kaspari <s.kaspari@gmail.com> - Tue, 22 Mar 2016 11:20:18 +0100 - rev 290894
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1201059 - Synchronize catalog of downloadable content from Kinto instance. r=rnewman,mathieu This patch does a couple of things: * Add a SyncAction for synchronizing the catalog from Kinto * Add a CleanupAction for removing files no longer needed * Migrate the data structure of DownloadContentCatalog from a list to a map. * Move the more complex builder code to its own class: DownloadContentBuilder * Introduce a switchboard expriment for staged rollout (download-content-catalog-sync) MozReview-Commit-ID: D733Xx6LxOb
089d27ec5d7c0dfeb1b553a39db431e393000f77: Bug 1250104 - Import the "jsesc" library for escaping JavaScript strings. r=rnewman
Alexis Métaireau <alexis@notmyidea.org> - Wed, 24 Feb 2016 15:40:55 +0100 - rev 290865
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1250104 - Import the "jsesc" library for escaping JavaScript strings. r=rnewman
0568d580c4a79282dd99b3dd8e4013136e1eb794: Bug 1249288 - Update telemetry docs to include defaultSearch. r=gfritzsche,rnewman
Michael Comella <michael.l.comella@gmail.com> - Thu, 10 Mar 2016 16:23:13 -0800 - rev 290806
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1249288 - Update telemetry docs to include defaultSearch. r=gfritzsche,rnewman MozReview-Commit-ID: 4pihITjabns
6ecd4b60ef8ad9fe5517eff40ba4810ca6069a52: Bug 1249288 - Add default search engine to core ping. r=rnewman
Michael Comella <michael.l.comella@gmail.com> - Thu, 10 Mar 2016 16:00:15 -0800 - rev 290804
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1249288 - Add default search engine to core ping. r=rnewman The default search engine attribute may be null in the core ping if we haven't been able to retrieve the value yet. It's unclear when this might be, but the possibility is in the javadoc of `SearchEngineManager.getEngine`. MozReview-Commit-ID: IrJB6GyjyTO
5fc1fd1e170e9a99324a76dd308f53441bf03bd3: Bug 1254491 - Enable downloadable fonts in all release channels. r=rnewman
Sebastian Kaspari <s.kaspari@gmail.com> - Tue, 22 Mar 2016 12:57:11 +0100 - rev 290089
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1254491 - Enable downloadable fonts in all release channels. r=rnewman MozReview-Commit-ID: 7htS1v9jWJq
da1a66f1c4b74c4bd778e91b9589d73763dddfe3: Bug 1254797 - Post: Ensure we ignore deleted sites in pinned query r=rnewman
Andrzej Hunt <andrzej@ahunt.org> - Tue, 15 Mar 2016 14:44:13 -0700 - rev 289643
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1254797 - Post: Ensure we ignore deleted sites in pinned query r=rnewman Pinned sites should be deleted directly, however I'm not confident enough in my knowledge of sync to be certain that we won't end up with deleted pinned sites in our table. (We use normal bookmark deletion for removing pinned sites.) MozReview-Commit-ID: SSLDkSXWlI
54080662c8491231102e0e81144b8fa6ddcee3d7: Bug 1254797 - Intersperse blank sites between pinned sites if needed r=rnewman
Andrzej Hunt <andrzej@ahunt.org> - Tue, 15 Mar 2016 14:41:15 -0700 - rev 289642
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1254797 - Intersperse blank sites between pinned sites if needed r=rnewman This fixes an edge case that is most likely to happen to new users if they pin a site followed by removing one or more suggested sites. This results in the topsites table containing less sites than needed, leading to some pinned sites being displayed in a higher than expected position. This also broke unpinning since our code assumes that a topsites physical position corresponds to its DB position (which prior to this patch was not the case). MozReview-Commit-ID: JgTUa55eXnz
c1f7b417f9e26427dc17e870d0a741bf4d231764: Bug 1254797 - Pre: fix variable name being negation of value r=rnewman
Andrzej Hunt <andrzej@ahunt.org> - Wed, 09 Mar 2016 20:10:34 -0800 - rev 289641
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1254797 - Pre: fix variable name being negation of value r=rnewman This variable was renamed to be positive instead of negative but the value/usage wasn't adapted. MozReview-Commit-ID: H1DeZMmvTXC
0cb496369d8bed3cdc62b5f8113b922ec115131f: Bug 1257555 - Move readermode tools into their own package r=rnewman
Andrzej Hunt <ahunt@mozilla.com> - Mon, 29 Feb 2016 18:03:15 -0800 - rev 289214
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1257555 - Move readermode tools into their own package r=rnewman MozReview-Commit-ID: LaSO3VRUOuA
4a09c0fed0470d8d29542e96b0e665199659269b: Bug 1257555 - Pre: import cleanup r=rnewman
Andrzej Hunt <ahunt@mozilla.com> - Wed, 24 Feb 2016 11:23:44 -0800 - rev 289213
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1257555 - Pre: import cleanup r=rnewman MozReview-Commit-ID: IQQXo7qWokY
8ed64dabb118de86c28e2f6a05c61d42f3e7e096: Bug 1224531 - Provide a mechanism for the updater to drive kinto collection sync r=rnewman,mossop
Mark Goodwin <mgoodwin@mozilla.com> - Tue, 15 Mar 2016 08:55:23 +0000 - rev 288843
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1224531 - Provide a mechanism for the updater to drive kinto collection sync r=rnewman,mossop There are two parts to this change. The first is a module to drive kinto collection sync. This gives server-provided last-update times to each module managing collection information so that data is only fetched when updates are necessary. This also keeps track of when pings last took place (for future use) and any apparent difference between client and server clock (we need this later for the content signing work). Currently only one module (the kinto version of the OneCRL client) consumes this information, though more will follow. The second is a minor change to nsBlocklistService.js to ensure that this ping takes place whenever the existing blocklist ping happens. MozReview-Commit-ID: 7SN03AOJ4Wc
eb2c4646b5a6a3d8b2c5f86d47d0d32fc2be771c: Bug 744626 - ensure default prefs are synced such that they remain as default on other devices. r=rnewman
Mark Hammond <mhammond@skippinet.com.au> - Tue, 15 Mar 2016 16:24:15 +1100 - rev 288773
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 744626 - ensure default prefs are synced such that they remain as default on other devices. r=rnewman
c8d1f83532a7fe4289a473e3528c04b8b2f85a64: Bug 1254089 - LoadFaviconTask: Add proxy support. r=rnewman
Sebastian Kaspari <s.kaspari@gmail.com> - Mon, 07 Mar 2016 19:09:05 +0100 - rev 287411
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 1254089 - LoadFaviconTask: Add proxy support. r=rnewman MozReview-Commit-ID: lc8ufeTQ1Z
d8c0657ff5d34dd1a62d63830f967e0d215b9e2b: Bug 1254089 - LoadFaviconTask: Use HttpUrlConnection instead of HttpClient. r=rnewman,nalexander
Sebastian Kaspari <s.kaspari@gmail.com> - Mon, 07 Mar 2016 12:47:48 +0100 - rev 287410
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 1254089 - LoadFaviconTask: Use HttpUrlConnection instead of HttpClient. r=rnewman,nalexander HttpUrlConnection supports SNI and LoadFaviconTask does not require fancy HTTP features. MozReview-Commit-ID: IuDyU4xk7qI
34aa49e08c1749da907373f33b6f6a2f8123cc60: Bug 1250085 - watch for tab navigations so we know to re-fetch the list of tabs to sync. r=rnewman
Mark Hammond <mhammond@skippinet.com.au> - Tue, 08 Mar 2016 17:47:26 +1100 - rev 287397
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 1250085 - watch for tab navigations so we know to re-fetch the list of tabs to sync. r=rnewman
49acabe9d6b6696cbcdfdb9b406235ffe4e01516: Bug 1214338 - Implement Android GCM-based PushService protocol. r=rnewman r=kitcambridge
Nick Alexander <nalexander@mozilla.com> - Fri, 04 Mar 2016 15:48:09 -0800 - rev 287288
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 1214338 - Implement Android GCM-based PushService protocol. r=rnewman r=kitcambridge MozReview-Commit-ID: 1KV7CZBuosx
0d112a6d618c9730bddd665f65d75eb60873e9b6: Bug 1207714 - Part 4: Add singleton PushService. r=rnewman
Nick Alexander <nalexander@mozilla.com> - Wed, 02 Mar 2016 16:44:23 -0800 - rev 286975
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 1207714 - Part 4: Add singleton PushService. r=rnewman MozReview-Commit-ID: CFSINSP7uFp
15826b103fd0ac87294bc8c0e913f9916aa0283c: Bug 1207714 - Part 3: Implement push manager. r=rnewman
Nick Alexander <nalexander@mozilla.com> - Wed, 02 Mar 2016 16:04:02 -0800 - rev 286974
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 1207714 - Part 3: Implement push manager. r=rnewman MozReview-Commit-ID: LkUaGFA6YlF
f869f0c13f9062fe26a9bafd63392205581673c4: Bug 1207714 - Part 2: Add storage for App-wide push state. r=rnewman
Nick Alexander <nalexander@mozilla.com> - Wed, 02 Mar 2016 15:48:37 -0800 - rev 286973
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 1207714 - Part 2: Add storage for App-wide push state. r=rnewman MozReview-Commit-ID: GOP4F6N2Mht
8d8c291c2f65bb20b8904eec27a2e68846346de0: Bug 1207714 - Part 1: Register no-op GCM message listeners. r=rnewman
Nick Alexander <nalexander@mozilla.com> - Wed, 02 Mar 2016 15:45:24 -0800 - rev 286972
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 1207714 - Part 1: Register no-op GCM message listeners. r=rnewman MozReview-Commit-ID: 4n7IcTuGQVE
be96c33be89b0e88259926b25295ff9e898dc25d: Bug 1207714 - Pre: Expose synchronous executor to product code. r=rnewman
Nick Alexander <nalexander@mozilla.com> - Thu, 25 Feb 2016 09:30:28 -0800 - rev 286970
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 1207714 - Pre: Expose synchronous executor to product code. r=rnewman MozReview-Commit-ID: 3eDVh0nk7Nc
6a355b46c68b43c0df96978a25b36b661dd98737: Bug 1249574 - send the notification about synced tab state changing as the tabs engine is enabled or disabled. r=rnewman
Mark Hammond <mhammond@skippinet.com.au> - Thu, 03 Mar 2016 12:20:41 +1100 - rev 286797
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 1249574 - send the notification about synced tab state changing as the tabs engine is enabled or disabled. r=rnewman
82e8f730b3e18f3be117c5a202f9fead8e7a9e78: Bug 1252501 - Coalesce topsites position with rowid to ensure a valid position r=rnewman
Andrzej Hunt <ahunt@mozilla.com> - Tue, 01 Mar 2016 14:00:22 -0800 - rev 286785
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 1252501 - Coalesce topsites position with rowid to ensure a valid position r=rnewman MozReview-Commit-ID: BFcs3sUT0Ff
ac846629e1df216445858e18057d0ef4e912fad2: Bug 1249092 - Log profile path in debug mode. r=rnewman
Michael Comella <michael.l.comella@gmail.com> - Tue, 01 Mar 2016 11:44:53 -0800 - rev 286690
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 1249092 - Log profile path in debug mode. r=rnewman MozReview-Commit-ID: BhK3YFbglee
9aefc0d2d3b4e787b94fb88469d04f100ef32754: Bug 1252610 - Don't insert suggested sites into topsites table unless they actually exist r=rnewman
Andrzej Hunt <ahunt@mozilla.com> - Tue, 01 Mar 2016 13:54:24 -0800 - rev 286679
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 1252610 - Don't insert suggested sites into topsites table unless they actually exist r=rnewman MozReview-Commit-ID: 8MPLvxQ0FWu
234cb08281c0e3dc01fb751ed0cf7e4b07a77166: Bug 1252500 - Provide all the necessary columns when retrieving topsites r=rnewman
Andrzej Hunt <ahunt@mozilla.com> - Tue, 01 Mar 2016 10:10:47 -0800 - rev 286678
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 1252500 - Provide all the necessary columns when retrieving topsites r=rnewman MozReview-Commit-ID: IYeQ3Z6LLPy
446932a345fe1631718eb0b6bcb3e098c2958265: Bug 760956 - Part 7: only add single blank tile to top sites grid r=rnewman
Andrzej Hunt <ahunt@mozilla.com> - Thu, 25 Feb 2016 16:56:15 -0800 - rev 286396
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 760956 - Part 7: only add single blank tile to top sites grid r=rnewman MozReview-Commit-ID: 42DuTEJZgum
045c87312d9a21b4b6b9c3fb8f84e680e6203ee8: Bug 760956 - Post: Cleanup TopSitesCursorWrapper remainders r=rnewman
Andrzej Hunt <ahunt@mozilla.com> - Wed, 17 Feb 2016 09:47:06 -0800 - rev 286394
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 760956 - Post: Cleanup TopSitesCursorWrapper remainders r=rnewman MozReview-Commit-ID: ExIkvmfJO5O
94b25f1233ddb1df2975a39e02ee8637846ba25b: Bug 760956 - Part 6: Introduce basic topsites retrieval test r=rnewman
Andrzej Hunt <ahunt@mozilla.com> - Thu, 25 Feb 2016 16:59:07 -0800 - rev 286393
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 760956 - Part 6: Introduce basic topsites retrieval test r=rnewman This is a quick sanity check: a clean profile should return all the suggested sites directly. We should probably add further tests making sure that history items appear in front of the suggested sites, that pinned sites work correctly, and that suggested sites don't appear outside of the grid. MozReview-Commit-ID: Ai8gTkv9E9w
86d110d3d0eb17bfbaa3f8d4a7287466621ad710: Bug 760956 - Part 5: use BrowserProvider TopSites query instead of TopSitesCursorWrapper r=rnewman
Andrzej Hunt <ahunt@mozilla.com> - Thu, 25 Feb 2016 16:54:50 -0800 - rev 286392
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 760956 - Part 5: use BrowserProvider TopSites query instead of TopSitesCursorWrapper r=rnewman This means we now have only one open cursor for the topsites query, instead of 2 real cursors (and one MatrixCursor). We still need a MergeCursor and MatrixCursor to supply blank tiles, this will disappear as soon as the user has sufficient history items to fill the suggested sites grid. MozReview-Commit-ID: LnJaSMIDM2O
613f1eb88443821b3a7c3787d14e1f0238e4a4d0: Bug 760956 - Part 4: Implement single-cursor topsite-retrieval in BrowserProvider r=rnewman
Andrzej Hunt <ahunt@mozilla.com> - Thu, 25 Feb 2016 16:43:13 -0800 - rev 286391
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 760956 - Part 4: Implement single-cursor topsite-retrieval in BrowserProvider r=rnewman Note that this version only returns topsites, pinned sites, and suggested sites. Blank tiles aren't supplied, and need to be added separately. MozReview-Commit-ID: 5Vc5pXTewHi
633a0cff7f55ec82a3b75b22e424dc5f68779912: Bug 760956 - Part 3: Add getSuggestedSites to BrowserDB r=rnewman
Andrzej Hunt <ahunt@mozilla.com> - Wed, 17 Feb 2016 09:28:13 -0800 - rev 286390
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 760956 - Part 3: Add getSuggestedSites to BrowserDB r=rnewman We'll need access to the SuggestedSites in BrowserProvider when assembling the topsites query there, hence we need to allow access via BrowserDB. MozReview-Commit-ID: BkZghDhQGxr
d6e7971cd98b8db5ed78421652e52848d29f71fa: Bug 760956 - Part 2: Introduce numbers table r=rnewman
Andrzej Hunt <ahunt@mozilla.com> - Mon, 29 Feb 2016 11:33:05 -0800 - rev 286389
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 760956 - Part 2: Introduce numbers table r=rnewman We'll need this to provide a number sequence for the single-query/cursor TopSites implementation. MozReview-Commit-ID: 8m21gNmY50D
f0d9ab6ffd64bd61e90dc2a13120df985c91c823: Bug 760956 - Part 1: Introduce variadic concatenateSelectionArgs r=rnewman
Andrzej Hunt <ahunt@mozilla.com> - Wed, 17 Feb 2016 09:13:34 -0800 - rev 286388
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 760956 - Part 1: Introduce variadic concatenateSelectionArgs r=rnewman This allows us to more easily append multiple sets of args. TODO: is it worth naming this appendSelectionArgs? We should keep the 2-param version appendSelectionArgs since it's more efficient for that case (and the vast majority of uses are with 2-params) - it's probably simpler for development to have both versions have the same name, and as far as I can tell the compiler will prefer the non varargs version when possible. MozReview-Commit-ID: LcI6zNwpIxh
e93550cee4886e3904ca91842ed477924365e2e9: Bug 1240500 - Early return on empty pattern to avoid an infinte loop and OOM r=rnewman
Andrzej Hunt <ahunt@mozilla.com> - Thu, 25 Feb 2016 15:28:08 -0800 - rev 286108
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 1240500 - Early return on empty pattern to avoid an infinte loop and OOM r=rnewman MozReview-Commit-ID: 7GlsZjfmE0y
26bbd4cee816104657dde905a76f5e355af3b321: Bug 1250104 - Import the "jsesc" library for escaping JavaScript strings. r=rnewman
Alexis Métaireau <alexis@notmyidea.org> - Wed, 24 Feb 2016 15:40:55 +0100 - rev 286102
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 1250104 - Import the "jsesc" library for escaping JavaScript strings. r=rnewman
e0453757fb6c350712189d7fb5e2165ff5802ef9: Bug 1248765 - allow syncing of FxA password and don't delete it on unlink. r=rnewman
Mark Hammond <mhammond@skippinet.com.au> - Tue, 23 Feb 2016 09:41:59 +1100 - rev 285479
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 1248765 - allow syncing of FxA password and don't delete it on unlink. r=rnewman
dbb6c118f854db9492438957af5765115b8411fe: Bug 1246076 (part 1) - include the favicon in synced tabs records and optionally display it in the synced tabs UI. r=rnewman
Mark Hammond <mhammond@skippinet.com.au> - Mon, 22 Feb 2016 15:43:46 +1100 - rev 285377
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 1246076 (part 1) - include the favicon in synced tabs records and optionally display it in the synced tabs UI. r=rnewman
d6c06db9e3d49ff30f0670b8e8aef1eb90197978: Bug 1249096 - Use a more forgiving URL parser when getting the fallback favicon r=rnewman
Mark Finkle <mfinkle@mozilla.com> - Sun, 21 Feb 2016 11:54:34 -0500 - rev 285367
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 1249096 - Use a more forgiving URL parser when getting the fallback favicon r=rnewman
f43052add92f5571b0879401f6de8829babd5d5b: Bug 1244861 - Gzip outgoing telemetry pings. r=rnewman
Michael Comella <michael.l.comella@gmail.com> - Wed, 17 Feb 2016 18:20:20 -0800 - rev 284913
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 1244861 - Gzip outgoing telemetry pings. r=rnewman This commit adds the GzipNonChunkedCompressingEntity which is necessary because the telemetry servers don't support chunked uploading, which the built in GzipCompressingEntity does. I tested this on my local device and logs for successful uploads were sent for both the testing gzip server as well as the official telemetry server. My data correctly appears on the former and I did not check the latter. MozReview-Commit-ID: 4bCNiRYyqFD
b11a13c9b75082b4beee2e738e23da8f5f917c4d: Bug 1233799 - Enable DownloadContentService (and exclude fonts) in Nightly. r=rnewman
Sebastian Kaspari <s.kaspari@gmail.com> - Tue, 16 Feb 2016 16:43:27 +0000 - rev 284579
Push 19537 by kwierso@gmail.com at Wed, 17 Feb 2016 19:16:23 +0000
Bug 1233799 - Enable DownloadContentService (and exclude fonts) in Nightly. r=rnewman MozReview-Commit-ID: G7zDhHVt67C
4fcce95b7993fe8f8107dde4323403aaf5054093: Bug 1244944 - Don't stick an org.json.JSONArray into an ExtendedJSONObject. r=rnewman
Nick Alexander <nalexander@mozilla.com> - Mon, 01 Feb 2016 16:57:24 -0800 - rev 284085
Push 19537 by kwierso@gmail.com at Wed, 17 Feb 2016 19:16:23 +0000
Bug 1244944 - Don't stick an org.json.JSONArray into an ExtendedJSONObject. r=rnewman This works due to string conversions, but it's not elegant. Let's just define the API we want, and work to improve the implementation when we remove org.json.simple entirely. MozReview-Commit-ID: GseI427PeDi
1702bbc7c171e7766449f9be5c7c254f87393f95: Bug 1244944 - Don't catch or throw ParseException. r=rnewman
Nick Alexander <nalexander@mozilla.com> - Wed, 20 Jan 2016 17:18:55 -0800 - rev 284084
Push 19537 by kwierso@gmail.com at Wed, 17 Feb 2016 19:16:23 +0000
Bug 1244944 - Don't catch or throw ParseException. r=rnewman MozReview-Commit-ID: G7gIlAOFy7k
db376a7a4b31f02480ac039b8a97dc880916bfca: Bug 1244944 - Don't throw ParseException from ExtendedJSONObject. r=rnewman
Nick Alexander <nalexander@mozilla.com> - Wed, 20 Jan 2016 17:02:55 -0800 - rev 284083
Push 19537 by kwierso@gmail.com at Wed, 17 Feb 2016 19:16:23 +0000
Bug 1244944 - Don't throw ParseException from ExtendedJSONObject. r=rnewman One step further on the path of removing dependence on org.json.simple: don't expose its exceptions to consumers of EJO. We re-purpose the existing UnexpectedJSONException classes to incorporate what were once ParseException instances. MozReview-Commit-ID: KOwM3cf0fm
367586933a6a28061a82467402bdb878024cd5e4: Bug 1244944 - Inline ExtendedJSONObject.parseJSONObject. r=rnewman
Nick Alexander <nalexander@mozilla.com> - Wed, 20 Jan 2016 16:40:32 -0800 - rev 284082
Push 19537 by kwierso@gmail.com at Wed, 17 Feb 2016 19:16:23 +0000
Bug 1244944 - Inline ExtendedJSONObject.parseJSONObject. r=rnewman MozReview-Commit-ID: 5J46KlYoLx6
c1993405f2ca6bb88bed7bc39787d47152efa704: Bug 1244944 - Use typed put() variants. r=rnewman
Nick Alexander <nalexander@mozilla.com> - Mon, 01 Feb 2016 16:55:36 -0800 - rev 284081
Push 19537 by kwierso@gmail.com at Wed, 17 Feb 2016 19:16:23 +0000
Bug 1244944 - Use typed put() variants. r=rnewman MozReview-Commit-ID: 2Uxk9jcxQ7F
31dacd6cfb7907d5cc2286769d78334b33361cb2: Bug 1244944 - Fix test. r=rnewman
Nick Alexander <nalexander@mozilla.com> - Wed, 20 Jan 2016 16:24:01 -0800 - rev 284080
Push 19537 by kwierso@gmail.com at Wed, 17 Feb 2016 19:16:23 +0000
Bug 1244944 - Fix test. r=rnewman MozReview-Commit-ID: AKOcras22LX
e6bd866b645727d885b1362bf1006c8808ef45ce: Bug 1244944 - Remove untyped EJO.putAll. r=rnewman
Nick Alexander <nalexander@mozilla.com> - Wed, 20 Jan 2016 16:23:44 -0800 - rev 284079
Push 19537 by kwierso@gmail.com at Wed, 17 Feb 2016 19:16:23 +0000
Bug 1244944 - Remove untyped EJO.putAll. r=rnewman MozReview-Commit-ID: 2TQNGErFAMv
13f78bc15919d05e0a402661a4cd78964afe0e1c: Bug 1244944 - Remove unused deepCopy method. r=rnewman
Nick Alexander <nalexander@mozilla.com> - Tue, 19 Jan 2016 18:02:56 -0800 - rev 284078
Push 19537 by kwierso@gmail.com at Wed, 17 Feb 2016 19:16:23 +0000
Bug 1244944 - Remove unused deepCopy method. r=rnewman MozReview-Commit-ID: 5LAtdJ5W3fX
c85b2e0480791a3e0799645d4a7213cb51a81532: Bug 1244944 - Remove old and crufty defer{Get,Put}. r=rnewman
Nick Alexander <nalexander@mozilla.com> - Tue, 19 Jan 2016 16:20:37 -0800 - rev 284077
Push 19537 by kwierso@gmail.com at Wed, 17 Feb 2016 19:16:23 +0000
Bug 1244944 - Remove old and crufty defer{Get,Put}. r=rnewman This is safe because the single consumer of `MetaGlobal.fetch` is `FetchMetaGlobalStage.execute`, which already expects to be called on a thread and have another thread waiting for the callback. MozReview-Commit-ID: 5XXd5aBkljc