searching for reviewer(jld)
5edbf0d674ed9a0029cdc2c386cf48973eda8f3a: Bug 1259428 - part 6 - remove unneeded MessageDecl methods; r=jld
Nathan Froyd <froydnj.com> - Mon, 28 Mar 2016 11:43:54 -0400 - rev 291449
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1259428 - part 6 - remove unneeded MessageDecl methods; r=jld msgCast and replyCast were only used for the dodgy casts we removed in part 2; the msgCxxType was only called by msgCast.
cb6dee617908f71f565946ca2ee78e446b01948c: Bug 1259428 - part 5 - convert Message subclasses to constructor functions; r=jld
Nathan Froyd <froydnj.com> - Mon, 28 Mar 2016 11:42:47 -0400 - rev 291448
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1259428 - part 5 - convert Message subclasses to constructor functions; r=jld All we use our Message subclasses for nowadays is the constructor, so we might as well strip the class away and just have functions that perform the construction for us. This change eliminates unnecessary vtables as well as making the included headers somewhat smaller, which is always nice.
850eb4d63ebed929469d2803b864b63ec0f436b5: Bug 1259428 - part 4 - remove prtime.h from generated protocol headers; r=jld
Nathan Froyd <froydnj.com> - Fri, 25 Mar 2016 18:27:11 -0400 - rev 291447
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1259428 - part 4 - remove prtime.h from generated protocol headers; r=jld This include was only needed for PR_Now(), which is no longer called by the headers.
9878927b10f4d472ab919330f6875ead04dcbc58: Bug 1259428 - part 3 - remove Log() methods from generated message subclasses; r=jld
Nathan Froyd <froydnj.com> - Fri, 25 Mar 2016 17:09:41 -0400 - rev 291446
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1259428 - part 3 - remove Log() methods from generated message subclasses; r=jld These are no longer called by anything. The generated Message subclasses now have no behavior of their own, and can be removed in subsequent patches.
1349ec62f2411520c6c1120d00f6ea7e957f7ad1: Bug 1259428 - part 2 - remove dodgy static_cast downcasts from logging statements; r=jld
Nathan Froyd <froydnj.com> - Fri, 25 Mar 2016 17:07:26 -0400 - rev 291445
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1259428 - part 2 - remove dodgy static_cast downcasts from logging statements; r=jld Various bits of IPDL code would do something like: Message* m = ...; if (m.type() == particular message type) { static_cast<ParticularMessageType*>(m)->name(); } The static_cast is a remnant of having to do the downcast to access the Log() method on the concrete subclass. Since name() is defined on Message, there's no need for these casts anymore, so let's remove them.
234de0ccd39ba2cf18cf9da6e55a0ccb6033fa58: Bug 1259428 - part 1 - don't call Log methods of generated method classes; r=jld
Nathan Froyd <froydnj.com> - Fri, 25 Mar 2016 17:02:38 -0400 - rev 291444
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1259428 - part 1 - don't call Log methods of generated method classes; r=jld The first step to eliminating all the generated Message subclasses the IPDL compiler spits out is to move the functionality of their Log methods someplace else. In addition to eliminating the need for the Log methods, this change has the welcome effect of moving a bunch of code that would be generated hundreds of times into a single place, which should reduce code size a bit (debug builds only). We don't actually remove the generation of the Log methods; that change will be done for a future patch.
8f29950faaa3c187b19aeffe12359cdbd86dc2d4: Bug 1260806: Remove some more dead MessageLoop code. r=jld
Kyle Huey <khuey@kylehuey.com> - Fri, 01 Apr 2016 11:28:53 -0700 - rev 291412
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1260806: Remove some more dead MessageLoop code. r=jld
114cfe94d3060efb268ee6d7eb9e0a3c1840ec3f: Bug 1253123 - Remove message_router (r=jld) a=kwierso
Bill McCloskey <billm@mozilla.com> - Mon, 15 Feb 2016 10:12:39 -0800 - rev 291105
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1253123 - Remove message_router (r=jld) a=kwierso MozReview-Commit-ID: KYiLsnFFJMA
e107f7eea6cf84c155e79b0230055b920be851f9: Bug 1253123 - Remove ipc_channel_proxy (r=jld) a=kwierso
Bill McCloskey <billm@mozilla.com> - Mon, 15 Feb 2016 10:13:46 -0800 - rev 291104
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1253123 - Remove ipc_channel_proxy (r=jld) a=kwierso MozReview-Commit-ID: CwO2Ufog5qX
62f68029c49a1cdab61b2db68dd46828e67bbfce: Bug 1253123 - Remove ipc_sync_message (r=jld) a=kwierso
Bill McCloskey <billm@mozilla.com> - Mon, 15 Feb 2016 10:09:02 -0800 - rev 291103
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1253123 - Remove ipc_sync_message (r=jld) a=kwierso MozReview-Commit-ID: 9xTyGYXyuTY
c91015c43d5556059210a2cffac02e7a5c547ed5: Bug 1222101 - Reorder some thread code (r=jld) a=kwierso
Bill McCloskey <billm@mozilla.com> - Wed, 30 Mar 2016 12:20:20 -0700 - rev 291102
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1222101 - Reorder some thread code (r=jld) a=kwierso MozReview-Commit-ID: Alg40mu9aU3
00f8c8fde8ca0e3d2816cf3ddc3f6e26b5070c52: Bug 1222101 - Reorder some thread code (r=jld)
Bill McCloskey <billm@mozilla.com> - Tue, 01 Mar 2016 16:22:44 -0800 - rev 291090
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1222101 - Reorder some thread code (r=jld)
f0dd577131c74afcd7118f64a138be78c39ec786: Bug 1253123 - Remove message_router (r=jld)
Bill McCloskey <billm@mozilla.com> - Mon, 15 Feb 2016 10:12:39 -0800 - rev 291089
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1253123 - Remove message_router (r=jld)
d345149b216921e65dfe6c1ed86cc7c61941bb78: Bug 1253123 - Remove ipc_channel_proxy (r=jld)
Bill McCloskey <billm@mozilla.com> - Mon, 15 Feb 2016 10:13:46 -0800 - rev 291088
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1253123 - Remove ipc_channel_proxy (r=jld)
6c8278e8047ee59720ecafffe1a3c568e10a22e7: Bug 1253123 - Remove ipc_sync_message (r=jld)
Bill McCloskey <billm@mozilla.com> - Mon, 15 Feb 2016 10:09:02 -0800 - rev 291087
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1253123 - Remove ipc_sync_message (r=jld)
360754dc00f6be0cfef2543f0db4fccfc8dffe11: Bug 1258908: Rename TYPE_MOZILLA_UI to TYPE_MOZILLA_PARENT. r=jld
Kyle Huey <khuey@kylehuey.com> - Mon, 28 Mar 2016 10:28:14 -0700 - rev 290733
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1258908: Rename TYPE_MOZILLA_UI to TYPE_MOZILLA_PARENT. r=jld
4d6500208358f342d24b25e5ef32117e73138327: Bug 1258905: Remove a bunch of dead IPC code. r=jld
Kyle Huey <khuey@kylehuey.com> - Mon, 28 Mar 2016 10:28:14 -0700 - rev 290732
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1258905: Remove a bunch of dead IPC code. r=jld
84f912382f78363398ad538abbe0fadb5100020a: Bug 1233275 - Copy environment for IPC using NSPR. r=jld
Jan Beich <jbeich@FreeBSD.org> - Thu, 24 Mar 2016 17:52:40 +0000 - rev 290545
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1233275 - Copy environment for IPC using NSPR. r=jld MozReview-Commit-ID: J2kBklLfnib
e57d1fa1f7710ad79fe6e9644e921ae0b73e444c: Bug 1259218 - don't use arc4random_addrandom on Android, since NDK r11 doesn't provide it; r=jld
Nathan Froyd <froydnj.com> - Wed, 23 Mar 2016 16:34:22 -0400 - rev 290359
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1259218 - don't use arc4random_addrandom on Android, since NDK r11 doesn't provide it; r=jld
c3383af0d94476f06ecfeb233b276db884124226: Bug 1236358 - Improper reading of string16 in Pickle::ReadString16. r=jld
Haik Aftandilian <haftandilian@mozilla.com> - Thu, 10 Mar 2016 07:49:41 -0800 - rev 288202
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1236358 - Improper reading of string16 in Pickle::ReadString16. r=jld
734e3856f443e0b7e65f017483a8a7a8abf6b5b2: Bug 1237458 - Use MOZ_RELEASE_ASSERT for IPC assertions (r=jld)
Bill McCloskey <billm@mozilla.com> - Thu, 04 Feb 2016 16:09:11 -0800 - rev 283459
Push 19510 by gwagner@mozilla.com at Mon, 08 Feb 2016 15:56:48 +0000
Bug 1237458 - Use MOZ_RELEASE_ASSERT for IPC assertions (r=jld)
0e54a3a870e9abbb39d85620204e05f33341c475: Bug 1210099 - Use diagnostic assert for union discriminator checks (r=jld)
Bill McCloskey <billm@mozilla.com> - Thu, 04 Feb 2016 15:12:39 -0800 - rev 283315
Push 19510 by gwagner@mozilla.com at Mon, 08 Feb 2016 15:56:48 +0000
Bug 1210099 - Use diagnostic assert for union discriminator checks (r=jld)
0d358cdf1ce4cec60ada9f70ef18ede566098237: Bug 1237458 - Use MOZ_RELEASE_ASSERT for IPC assertions (r=jld)
Bill McCloskey <billm@mozilla.com> - Thu, 04 Feb 2016 16:09:11 -0800 - rev 283314
Push 19510 by gwagner@mozilla.com at Mon, 08 Feb 2016 15:56:48 +0000
Bug 1237458 - Use MOZ_RELEASE_ASSERT for IPC assertions (r=jld)
7ae2adc4bb4400d9f6bf52eee2b046c3644c8776: Bug 1243643 - Don't pass unsafe CPOWs to saveImageURL when offering to save media to disk. r=jld
Mike Conley <mconley@mozilla.com> - Thu, 28 Jan 2016 16:24:39 -0500 - rev 282536
Push 19510 by gwagner@mozilla.com at Mon, 08 Feb 2016 15:56:48 +0000
Bug 1243643 - Don't pass unsafe CPOWs to saveImageURL when offering to save media to disk. r=jld
eb1acf2e2d72f120874f8d624d54e34d8a7ddeec: Bug 1243643 - Deprecate unsafe CPOW usage in contentAreaUtils' saveImage. r=jld
Mike Conley <mconley@mozilla.com> - Thu, 28 Jan 2016 16:23:30 -0500 - rev 282535
Push 19510 by gwagner@mozilla.com at Mon, 08 Feb 2016 15:56:48 +0000
Bug 1243643 - Deprecate unsafe CPOW usage in contentAreaUtils' saveImage. r=jld
19ab70a7137cf42e827083f5186f5f6de944b7c9: Bug 1240985 - IPC glib deadlock fix (r=jld)
Bill McCloskey <billm@mozilla.com> - Tue, 19 Jan 2016 17:19:22 -0800 - rev 281026
Push 19398 by kwierso@gmail.com at Fri, 22 Jan 2016 01:37:23 +0000
Bug 1240985 - IPC glib deadlock fix (r=jld)
fddcf8b3b08835eb75c1bd986df3af677bae3f34: Bug 1240985 - IPC glib deadlock fix (r=jld)
Bill McCloskey <billm@mozilla.com> - Tue, 19 Jan 2016 17:19:22 -0800 - rev 280860
Push 19387 by cbook@mozilla.com at Thu, 21 Jan 2016 11:31:52 +0000
Bug 1240985 - IPC glib deadlock fix (r=jld)
a5abb03da5a4ed038451a89e8967932c904b3db7: Bug 1240589 - Import Chromium's upstream rand_util_win.cc to avoid rand_s() crash. r=jld
Chris Peterson <cpeterson@mozilla.com> - Thu, 14 Jan 2016 00:53:52 -0800 - rev 280749
Push 19387 by cbook@mozilla.com at Thu, 21 Jan 2016 11:31:52 +0000
Bug 1240589 - Import Chromium's upstream rand_util_win.cc to avoid rand_s() crash. r=jld
4ad4623f38408bb19c1b4e5e8b4a61d3aa06a1d4: Bug 1237458 - Use release assertions in IPC (r=jld)
Bill McCloskey <billm@mozilla.com> - Wed, 06 Jan 2016 16:12:11 -0800 - rev 278933
Push 19216 by cbook@mozilla.com at Thu, 07 Jan 2016 11:23:39 +0000
Bug 1237458 - Use release assertions in IPC (r=jld)
e6a87d3e65549566886183d95e29fcdea5a43e93: Bug 1236635 - Fix compile error in IPC unit tests (r=jld)
Bill McCloskey <billm@mozilla.com> - Tue, 05 Jan 2016 14:19:43 -0800 - rev 278730
Push 19200 by ryanvm@gmail.com at Wed, 06 Jan 2016 14:51:47 +0000
Bug 1236635 - Fix compile error in IPC unit tests (r=jld)
742d85ac5b33c7b02ddb00a203b4163115f6a188: Bug 1223240 - Make it easier to set up top-level protocols (r=jld)
Bill McCloskey <billm@mozilla.com> - Sat, 31 Oct 2015 20:02:08 -0700 - rev 277545
Push 19101 by ryanvm@gmail.com at Sat, 26 Dec 2015 01:50:32 +0000
Bug 1223240 - Make it easier to set up top-level protocols (r=jld)
bf2c46cbeeb32087da013f805975c6f0cdf9c515: Bug 1231123 - Simplify LaunchApp on BSDs by dropping fork/exec version. r=jld
Jan Beich <jbeich@FreeBSD.org> - Thu, 03 Dec 2015 12:55:41 +0000 - rev 276812
Push 19029 by cbook@mozilla.com at Fri, 18 Dec 2015 14:31:22 +0000
Bug 1231123 - Simplify LaunchApp on BSDs by dropping fork/exec version. r=jld
401c10d24183485f5a88ecc5a57e607cd2834139: Bug 1231109 - Drop FreeBSD checks for unsupported versions. r=jld r=jesup
Jan Beich <jbeich@FreeBSD.org> - Thu, 03 Dec 2015 12:28:22 +0000 - rev 276810
Push 19029 by cbook@mozilla.com at Fri, 18 Dec 2015 14:31:22 +0000
Bug 1231109 - Drop FreeBSD checks for unsupported versions. r=jld r=jesup
62a5376b5872f56e6ca5f066707e9a51bb6f3cac: Bug 1231256 (part 2) - Remove unused BlobDirState parameters from SetLazyData(). r=jld.
Nicholas Nethercote <nnethercote@mozilla.com> - Mon, 07 Dec 2015 14:00:51 -0800 - rev 276442
Push 18981 by cbook@mozilla.com at Tue, 15 Dec 2015 13:55:56 +0000
Bug 1231256 (part 2) - Remove unused BlobDirState parameters from SetLazyData(). r=jld.
d8b6ab130caa9b9d1ec974aa9b0c86a4fec8683c: Bug 1215303 - Part 2 - automatically enable broker when in permissive mode r=jld
Julian Hector <julian.r.hector@gmail.com> - Fri, 13 Nov 2015 12:29:47 +0000 - rev 273952
Push 18784 by kwierso@gmail.com at Wed, 25 Nov 2015 00:58:10 +0000
Bug 1215303 - Part 2 - automatically enable broker when in permissive mode r=jld
97e94e27af5239618257616269c37d5a36ae6a7f: Bug 1215303 - Part 1 - add permissive mode r=jld
Julian Hector <julian.r.hector@gmail.com> - Fri, 13 Nov 2015 12:27:45 +0000 - rev 273951
Push 18784 by kwierso@gmail.com at Wed, 25 Nov 2015 00:58:10 +0000
Bug 1215303 - Part 1 - add permissive mode r=jld
7686821fd178b148a624c10b7a0d69017761c17c: Bug 1221371 - Remove unused Chromium callback code (r=jld)
Bill McCloskey <billm@mozilla.com> - Mon, 02 Nov 2015 19:17:54 -0800 - rev 271806
Push 18568 by kwierso@gmail.com at Tue, 10 Nov 2015 01:35:43 +0000
Bug 1221371 - Remove unused Chromium callback code (r=jld)
9567dbd464b88e5a919304f44a5a9d793f75fd06: Bug 1221371 - Switch chromium IPC code to use mozilla::Tuple (r=jld,cpearce,kats)
Bill McCloskey <billm@mozilla.com> - Mon, 02 Nov 2015 16:50:45 -0800 - rev 271805
Push 18568 by kwierso@gmail.com at Tue, 10 Nov 2015 01:35:43 +0000
Bug 1221371 - Switch chromium IPC code to use mozilla::Tuple (r=jld,cpearce,kats)
a50c676caf7f12198f892e01ca1fb74fe0753df6: Bug 1221371 - Remove unused Chromium callback code (r=jld)
Bill McCloskey <billm@mozilla.com> - Mon, 02 Nov 2015 19:17:54 -0800 - rev 271689
Push 18556 by cbook@mozilla.com at Mon, 09 Nov 2015 14:01:11 +0000
Bug 1221371 - Remove unused Chromium callback code (r=jld)
bd99e5060e1e3ecf627a7d5419dda8620c6b5fa6: Bug 1221371 - Switch chromium IPC code to use mozilla::Tuple (r=jld,cpearce,kats)
Bill McCloskey <billm@mozilla.com> - Mon, 02 Nov 2015 16:50:45 -0800 - rev 271688
Push 18556 by cbook@mozilla.com at Mon, 09 Nov 2015 14:01:11 +0000
Bug 1221371 - Switch chromium IPC code to use mozilla::Tuple (r=jld,cpearce,kats)
239a8e8c626b2186f2fae3b546a6d56e3117be35: Bug 1222167 - fix initialization order in GeckoChildProcessHost; r=jld
Nathan Froyd <froydnj@mozilla.com> - Thu, 05 Nov 2015 15:15:19 -0500 - rev 271458
Push 18534 by cbook@mozilla.com at Fri, 06 Nov 2015 13:00:49 +0000
Bug 1222167 - fix initialization order in GeckoChildProcessHost; r=jld Member fields are supposed to be initialized in the order they are declared, but the constructor of GeckoChildProcessHost initialized mDelegate prior to mSandboxLevel. This is probably harmless, but it does cause a warning on clang-cl, so let's fix it.
4a87f75e1316e10ee5fad087762cb944d54ca0c1: Bug 1217640 - MessageChannel::Call() should delete aMsg when the channel is not connected. r=jld
Andrew McCreight <continuation@gmail.com> - Mon, 26 Oct 2015 12:38:19 -0700 - rev 269656
Push 18335 by cbook@mozilla.com at Tue, 27 Oct 2015 10:03:03 +0000
Bug 1217640 - MessageChannel::Call() should delete aMsg when the channel is not connected. r=jld Otherwise, the message will leak.
05868efaa702fa95499e0f491305af36f02c2fe6: Bug 1089837 - Make IPC::Message use MOZ_COUNT_CTOR/DTOR. r=jld
Andrew McCreight <continuation@gmail.com> - Mon, 26 Oct 2015 12:38:19 -0700 - rev 269655
Push 18335 by cbook@mozilla.com at Tue, 27 Oct 2015 10:03:03 +0000
Bug 1089837 - Make IPC::Message use MOZ_COUNT_CTOR/DTOR. r=jld
944fe260a35c0799e90774f4529778e6c839a978: Bug 1215151 - Add XPCOM leak checking for base::Thread. r=jld
Andrew McCreight <continuation@gmail.com> - Fri, 16 Oct 2015 09:02:00 -0700 - rev 268243
Push 18139 by cbook@mozilla.com at Mon, 19 Oct 2015 09:45:22 +0000
Bug 1215151 - Add XPCOM leak checking for base::Thread. r=jld
81fda6d6373d86f2aee4d439597464235ca4ce13: Bug 1212027 - part 7 - modify IPDL codegen to store sub-protocols in a hashtable rather than an array; r=jld,nical,cpearce,billm
Nathan Froyd <froydnj@mozilla.com> - Wed, 07 Oct 2015 14:30:33 -0400 - rev 268136
Push 18127 by philringnalda@gmail.com at Sun, 18 Oct 2015 03:03:20 +0000
Bug 1212027 - part 7 - modify IPDL codegen to store sub-protocols in a hashtable rather than an array; r=jld,nical,cpearce,billm
19c5de45a704d1a8233b9326b670220fb938832c: Bug 1212027 - part 5 - add LoneManagedOrNull for simplifying a lot of upcoming code; r=jld
Nathan Froyd <froydnj@mozilla.com> - Wed, 07 Oct 2015 20:15:56 -0400 - rev 268134
Push 18127 by philringnalda@gmail.com at Sun, 18 Oct 2015 03:03:20 +0000
Bug 1212027 - part 5 - add LoneManagedOrNull for simplifying a lot of upcoming code; r=jld A lot of existing code has variations on: if (ManagedPFooChild().Length()) { ...(ManagedPFooChild()[0])... } // Do something with nullptr, or some other action. It's pretty reasonable to repeat this code when the managed protocols are stored in an array; the code gets much less nice when managed protocols are stored in a hashtable. Let's write a small utility function to handle those details for us. Then when we change the underlying storage, we only need to update this function, rather than a bunch of callsites. ProtocolUtils.h is included by all the generated IPDL headers, so LoneManagedOrNull should be available everywhere the above pattern would be encountered.
34aca18145b486a9d9b797e4d8ea91b517452bd7: Bug 1212027 - part 4 - use class interfaces when destroying managees; r=jld
Nathan Froyd <froydnj@mozilla.com> - Wed, 07 Oct 2015 00:02:27 -0400 - rev 268133
Push 18127 by philringnalda@gmail.com at Sun, 18 Oct 2015 03:03:20 +0000
Bug 1212027 - part 4 - use class interfaces when destroying managees; r=jld Similar to the last patch, we copy any sub-protocols a protocol owns before destroying the sub-protocols. We do this to ensure a stable iteration over the sub-protocols, as destroying a sub-protocol may trigger other sub-protocol deletions. Let's permit an existing interface method to do the copying for us, so if the details of how we store sub-protocols change, this call site is insulated from the details.
7552c079ae399c1b74a1c284dbb13a0cbf526177: Bug 1212027 - part 3 - use class interfaces when cloning managees; r=jld
Nathan Froyd <froydnj@mozilla.com> - Tue, 06 Oct 2015 23:59:32 -0400 - rev 268132
Push 18127 by philringnalda@gmail.com at Sun, 18 Oct 2015 03:03:20 +0000
Bug 1212027 - part 3 - use class interfaces when cloning managees; r=jld In $PROTOCOL::CloneManages, we reach directly into the other protocol's sub-protocol arrays to copy them. It would be better, from a fewer-places-to-modify-when-things-change point of view if we used the $PROTOCOL::Managed$SUBPROTOCOL array getter that already exists for this purpose. A good compiler should be able to remove the function call overhead...but cloning managees is probably expensive anyway, so a function call here doesn't matter much. It's not immediately obvious to me why we clone and then iterate over the clone, rather than iterating directly, but perhaps there are subtle IPDL dragons lurking hereabouts.
184d0872bf883ed1c651651e5e3fb1947a8ecb64: Bug 1212027 - part 2 - add a C++ AST type for 'auto'; r=jld
Nathan Froyd <froydnj@mozilla.com> - Tue, 06 Oct 2015 21:33:13 -0400 - rev 268131
Push 18127 by philringnalda@gmail.com at Sun, 18 Oct 2015 03:03:20 +0000
Bug 1212027 - part 2 - add a C++ AST type for 'auto'; r=jld This type will come in handy when we have to add iteration over hashtables, since it would be a pain to write out the iterator type.
6bbd5af4df15330d119e25627c001a16e7cb2ea4: Bug 1212027 - part 1 - rename ipdl lowering helpers to reflect intent, not function; r=jld
Nathan Froyd <froydnj@mozilla.com> - Tue, 06 Oct 2015 21:20:07 -0400 - rev 268130
Push 18127 by philringnalda@gmail.com at Sun, 18 Oct 2015 03:03:20 +0000
Bug 1212027 - part 1 - rename ipdl lowering helpers to reflect intent, not function; r=jld The functions: - _callCxxArrayInsertSorted - _callCxxArrayRemoveSorted - _callCxxArrayClear - _cxxArrayHasElementSorted are only ever used to touch the managed sub-protocol arrays of a protocol. It would be better if they reflected the *intent* of what they were doing, rather than what C++ function they were calling, since we're about to change that.