searching for reviewer(jesup)
c3fb02405b68aca36fdc60e556e13e49fe5482b0: Bug 1260950 - Set mInitialSizeFound to true when the initial size id found. r=jesup, r=pehrsons a=kwierso
ctai <ctai@mozilla.com> - Thu, 31 Mar 2016 10:13:04 +0800 - rev 291114
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1260950 - Set mInitialSizeFound to true when the initial size id found. r=jesup, r=pehrsons a=kwierso MozReview-Commit-ID: Ch3jCR4pFYN
88df6d5a1f21bd9c8298f3503620a9647ef3d857: Bug 1259728 - minimal fix for reentrancy in pc.close(). r=jesup
Jan-Ivar Bruaroey <jib@mozilla.com> - Tue, 29 Mar 2016 16:27:03 -0400 - rev 291065
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1259728 - minimal fix for reentrancy in pc.close(). r=jesup MozReview-Commit-ID: Dji4d2bYTcj
0ff7a5a4b24f76859762f1e93ad9c617b8f3c643: Bug 1256430: start AEC log independently of webrtc TRACE r=jesup,pkerr
Randell Jesup <rjesup@jesup.org> - Tue, 29 Mar 2016 11:32:54 -0400 - rev 290944
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1256430: start AEC log independently of webrtc TRACE r=jesup,pkerr
1b22933d97f20bc351b9576499aab7448cdb2373: Bug 1251502 - Use `devid` instead of `device_id` when getting the ID for a cubeb device. r=jesup
Alex Chronopoulos <achronop@gmail.com> - Fri, 25 Mar 2016 17:41:45 +0100 - rev 290636
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1251502 - Use `devid` instead of `device_id` when getting the ID for a cubeb device. r=jesup MozReview-Commit-ID: JojzRPFhYJ
9f87c2e8231ea589e6f3913309756ff825500bff: bug 1250492 - include sstream in SdpMediaSection.h instead of iostream r=jesup
Trevor Saunders <tbsaunde@tbsaunde.org> - Tue, 23 Feb 2016 09:32:01 -0500 - rev 290109
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
bug 1250492 - include sstream in SdpMediaSection.h instead of iostream r=jesup It gets rid of a couple static constructors, and should make the build slightly faster since we compile less code.
432cfb0bde31aa38664862d6371812141007110c: bug 1250492 - use tl::Max instead of std::max to get rid of a static constructor r=jesup
Trevor Saunders <tbsaunde@tbsaunde.org> - Tue, 23 Feb 2016 09:28:21 -0500 - rev 290108
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
bug 1250492 - use tl::Max instead of std::max to get rid of a static constructor r=jesup std::max is only constexpr in c++14 and >, but we build as c++11 so initializing a constant with std::max ends up with a static constructor. Fortunately we have tl::Max around which forces evaluation of the math at compile time.
6e2f198c3cfd84b7c5072c54db3a63348e18bc6b: Bug 1256750: Remove unnecessary sscanf_s parameter on windows, and fix format string everywhere else. r=jesup
Byron Campen [:bwc] <docfaraday@gmail.com> - Tue, 15 Mar 2016 14:10:28 -0500 - rev 289736
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1256750: Remove unnecessary sscanf_s parameter on windows, and fix format string everywhere else. r=jesup MozReview-Commit-ID: 3YFhTbGg5ec
affd6e75efcc015df869459f05cec8bb3e739b32: Bug 1243857: enable full_duplex audio for webrtc via cubeb rs=jesup
Randell Jesup <rjesup@jesup.org> - Thu, 17 Mar 2016 20:45:29 -0400 - rev 289348
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1243857: enable full_duplex audio for webrtc via cubeb rs=jesup
aa73de576cecfe9c403adabbd637c0be41f5c001: Bug 1254905: reduced default video size on Android to 320x240 @ 10 FPS. r=jesup
Nils Ohlmeier [:drno] <drno@ohlmeier.org> - Tue, 08 Mar 2016 13:58:31 -0800 - rev 289294
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1254905: reduced default video size on Android to 320x240 @ 10 FPS. r=jesup MozReview-Commit-ID: H440cYzCGhi
1ffc09b6908f450f96b3504b2b2b7cfe5f9bf6c2: Bug 1254102 - Add "blackout" mode. If the window is not legal, output a black square. r=jesup
Gian-Carlo Pascutto <gcp@mozilla.com> - Wed, 16 Mar 2016 19:21:17 +0100 - rev 289256
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1254102 - Add "blackout" mode. If the window is not legal, output a black square. r=jesup MozReview-Commit-ID: GlBy8fUZwIE
a0a16898e8db0ded551630b2dae95be9a268ef1c: Bug 1254102 - Don't skip Tab sources if the camera is in use. r=jesup
Gian-Carlo Pascutto <gcp@mozilla.com> - Tue, 15 Mar 2016 20:39:37 +0100 - rev 289255
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1254102 - Don't skip Tab sources if the camera is in use. r=jesup MozReview-Commit-ID: 7ZaebdnWj3R
463b44507a7fc91fbff7b1d9342c57c66cda1f9d: Bug 1256555: Wrap "shouldAEC" variable-usage in #ifdef for consistency & to fix --disable-webrtc build failure. r=jesup
Daniel Holbert <dholbert@cs.stanford.edu> - Tue, 15 Mar 2016 10:03:43 -0700 - rev 288860
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1256555: Wrap "shouldAEC" variable-usage in #ifdef for consistency & to fix --disable-webrtc build failure. r=jesup
df2429673c945e1fe476c8056547cca787e727d7: Bug 1256482 - Disable C4312 to unblock compilation on VS2015; r=jesup
Gregory Szorc <gps@mozilla.com> - Mon, 14 Mar 2016 16:05:06 -0700 - rev 288746
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1256482 - Disable C4312 to unblock compilation on VS2015; r=jesup As part of unblocking building with VS2015u1 in automation, I'm mass disabling compiler warnings that are turned into errors. This is not the preferred mechanism to fix compilation warnings, of course. Given that the warning is in WebRTC which is third party code, there isn't much we can do about the warning. However, Google is building Chrome with Visual Studio 2015, so I wouldn't be surprised if this were fixed upstream or will be fixed upstream. Then again, we allow warnings when building WebRTC. So perhaps not. MozReview-Commit-ID: G6JP9fkCzfn
3c4a045fe05f3e69e9454ab87199673da0b16dd9: Bug 820972 - Comment out colorTable[] because we don't need it. r=jesup.
Nicholas Nethercote <nnethercote@mozilla.com> - Fri, 11 Mar 2016 12:41:30 +1100 - rev 288721
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 820972 - Comment out colorTable[] because we don't need it. r=jesup. This saves 64 KiB of static data.
3ffa45c6352e94c9a01dca98f52427dcd05e6ff8: Bug 1254507 - Fix leak in WebRTC DesktopApplication class. r=jesup
Gian-Carlo Pascutto <gcp@mozilla.com> - Tue, 08 Mar 2016 14:14:05 +0100 - rev 287908
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1254507 - Fix leak in WebRTC DesktopApplication class. r=jesup MozReview-Commit-ID: FLuQZcPyv0d
bca82ee20a78bcb93c0ae72885e461ded33fbcb0: Bug 1217677: increase UDP socket receive buffer for <= Win7. r=jesup,mcmanus
Nils Ohlmeier [:drno] <drno@ohlmeier.org> - Tue, 01 Mar 2016 21:46:50 -0800 - rev 287228
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 1217677: increase UDP socket receive buffer for <= Win7. r=jesup,mcmanus MozReview-Commit-ID: A3yCZZ3Pwcu
181f18c5d1adeb37fec7cf68e43803e2fa1629ba: Bug 1251714 - use UniquePtr instead of ScopedDeletePtr in media/; r=jesup
Nathan Froyd <froydnj@mozilla.com> - Wed, 02 Mar 2016 15:28:27 -0500 - rev 287028
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 1251714 - use UniquePtr instead of ScopedDeletePtr in media/; r=jesup UniquePtr is more standard than ScopedDeletePtr; using standard constructs whenever possible is preferable. This patch merits a couple explanations: - Where it made sense, I tried to convert: T* foo() { UniquePtr<T> x = ...; ... return x.release(); } into: UniquePtr<T> foo() with corresponding changes inside |foo|'s body. - The attentive reader will note that: auto x = MakeUnique<T>(...); is used sometimes and: UniquePtr<T> x(new T(...)); is used sometimes. I would prefer to use the former, but was stymied in several places due to protected constructors. (MakeUnique doesn't have access to those protected constructors, natch.)
2f3de0b4e8fce877da2a541d569a18eeaa8532d9: Bug 1252755: increase maximum UDP packet size to 9216 bytes for jumbo frames. r=jesup
Nils Ohlmeier [:drno] <drno@ohlmeier.org> - Tue, 01 Mar 2016 22:13:14 -0800 - rev 286999
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 1252755: increase maximum UDP packet size to 9216 bytes for jumbo frames. r=jesup MozReview-Commit-ID: 9aNARxTIdyr
b9a420d13d5cc7e6c23896dd468c9f087fa16c55: Bug 1252737 - use size_t instead of uint32_t for InitEncode(). r=jesup
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Wed, 02 Mar 2016 13:05:43 +0900 - rev 286989
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 1252737 - use size_t instead of uint32_t for InitEncode(). r=jesup Although 3rd parameter VideoEncodeer::InitEncode() is defiend as size_t, WebrtcIMXH264VideoCodec and WebrtcMediaCodecVP8VideoCodec uses uint32_t. This will cause build error for 64bit platform. MozReview-Commit-ID: 20NgE5e7Cuz
29dec7e96a9c87e54b5ec1b169df10c94c299f53: Bug 1252901 - don't use ScopedFreePtrTraits in MediaEngineWrapper.h; r=jesup
Nathan Froyd <froydnj@mozilla.com> - Wed, 02 Mar 2016 11:43:58 -0500 - rev 286918
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 1252901 - don't use ScopedFreePtrTraits in MediaEngineWrapper.h; r=jesup ScopedFreePtrTraits is somewhat of an internal implementation detail of Scoped.h, and it's not hard to write out the two static functions we need from ScopedFreePtrTraits anyway. Removing this means that we can clear the way for ScopedFreePtr to be removed.
2cfe0596c5e9cef4adc8a60de3d5c012198f2beb: Bug 1252699 - Set WEBRTC_DETECT_ARM_NEON when optional neon is requested. r=jesup
Mike Hommey <mh+mozilla@glandium.org> - Wed, 02 Mar 2016 10:01:15 +0900 - rev 286877
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 1252699 - Set WEBRTC_DETECT_ARM_NEON when optional neon is requested. r=jesup
8f1b196cd97344aca962d35e58fb62b57dc2b80f: Bug 1250990 - Make RTCRtpEncodingParameters.scaleResolutionDownBy work with H.264 unicast. r=jesup
Jan-Ivar Bruaroey <jib@mozilla.com> - Sun, 28 Feb 2016 09:19:23 -0500 - rev 286834
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 1250990 - Make RTCRtpEncodingParameters.scaleResolutionDownBy work with H.264 unicast. r=jesup MozReview-Commit-ID: 2j8rRzZemql
1bbd0cd10f766916115b5d68d388bc3fe78b2b4c: Bug 1251714 - use UniquePtr instead of ScopedDeletePtr in media/; r=jesup
Nathan Froyd <froydnj@mozilla.com> - Fri, 26 Feb 2016 14:52:15 -0500 - rev 286642
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 1251714 - use UniquePtr instead of ScopedDeletePtr in media/; r=jesup UniquePtr is more standard than ScopedDeletePtr; using standard constructs whenever possible is preferable. This patch merits a couple explanations: - Where it made sense, I tried to convert: T* foo() { UniquePtr<T> x = ...; ... return x.release(); } into: UniquePtr<T> foo() with corresponding changes inside |foo|'s body. - The attentive reader will note that: auto x = MakeUnique<T>(...); is used sometimes and: UniquePtr<T> x(new T(...)); is used sometimes. I would prefer to use the former, but was stymied in several places due to protected constructors. (MakeUnique doesn't have access to those protected constructors, natch.)
2c4b0bfe69aaab7299a6edc814a04fa1c78a5254: Bug 818618: Honor (and emit) opus stereo fmtp param. r=jesup
Byron Campen [:bwc] <docfaraday@gmail.com> - Fri, 26 Feb 2016 10:47:03 -0600 - rev 286504
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 818618: Honor (and emit) opus stereo fmtp param. r=jesup MozReview-Commit-ID: IgA305eiu1s
4cc3fae66ffb4e12c855eee78b1df424374de87a: Bug 1250990 - Make RTCRtpEncodingParameters.scaleResolutionDownBy work with H.264 unicast. r=jesup
Jan-Ivar Bruaroey <jib@mozilla.com> - Fri, 26 Feb 2016 16:16:11 -0500 - rev 286315
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 1250990 - Make RTCRtpEncodingParameters.scaleResolutionDownBy work with H.264 unicast. r=jesup MozReview-Commit-ID: 2j8rRzZemql
3ad133741957d08c0afdcbe6eeeabc9fb5a2b9cf: Bug 1251737 - Remove remaining references to MOZILLA_XPCOMRT_API from media. r=jesup
Eric Rahm <erahm@mozilla.com> - Sat, 27 Feb 2016 11:12:07 -0800 - rev 286303
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 1251737 - Remove remaining references to MOZILLA_XPCOMRT_API from media. r=jesup
55e890008b5cb0bf01051325266c6ca0f5843873: Bug 1251494 - Remove remaining references to MOZILLA_XPCOMRT_API from dom. r=jesup
Eric Rahm <erahm@mozilla.com> - Fri, 26 Feb 2016 18:10:56 -0800 - rev 286302
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 1251494 - Remove remaining references to MOZILLA_XPCOMRT_API from dom. r=jesup
f064a5efbb8c8d40bebef0ff0f142cc17ea40ad5: Bug 1251494 - Remove remaining references to MOZILLA_XPCOMRT_API from dom. r=jesup
Eric Rahm <erahm@mozilla.com> - Fri, 26 Feb 2016 15:31:21 -0800 - rev 286260
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 1251494 - Remove remaining references to MOZILLA_XPCOMRT_API from dom. r=jesup
04ee9e8be26f5c4c4bcb264333e17303f3338bcd: Bug 1251357 - fix regression where last MediaStreamTrack.stop did not turn off the camera light. r=jesup
Jan-Ivar Bruaroey <jib@mozilla.com> - Fri, 26 Feb 2016 12:26:47 -0500 - rev 286234
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 1251357 - fix regression where last MediaStreamTrack.stop did not turn off the camera light. r=jesup MozReview-Commit-ID: DvDBKscIjnp
6e6aaff5337b029bd945c8c90e87f094e1625814: Bug 1249098: Support maxplaybackrate for opus. r=jesup
Byron Campen [:bwc] <docfaraday@gmail.com> - Thu, 18 Feb 2016 14:13:35 -0600 - rev 286156
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 1249098: Support maxplaybackrate for opus. r=jesup MozReview-Commit-ID: 7BKVFkbPgV2
3b9317a33f9d888401c07e9ad9fc89a4fc186710: Bug 1251301 - Roll up of new entires to screen sharing whitelist r=jesup
Maire Reavy <mreavy@mozilla.com> - Thu, 25 Feb 2016 23:54:32 -0500 - rev 286043
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 1251301 - Roll up of new entires to screen sharing whitelist r=jesup MozReview-Commit-ID: IDCrLZd0RVd
e3235792878fe0f7b434882f8569be7532c88ab1: Bug 1247619 - add console warning about OAuth for STUN not yet supported. r=jesup,smaug
Jan-Ivar Bruaroey <jib@mozilla.com> - Thu, 25 Feb 2016 00:24:16 -0500 - rev 285972
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 1247619 - add console warning about OAuth for STUN not yet supported. r=jesup,smaug MozReview-Commit-ID: L0nViIWiIDn
ec4f62653a7e801ba3f0c7dda21a4e7931721fce: Bug 1247622 - Make RTCRtpSender.setParameters return a promise. r=jesup,smaug
Jan-Ivar Bruaroey <jib@mozilla.com> - Wed, 24 Feb 2016 19:14:57 -0500 - rev 285960
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 1247622 - Make RTCRtpSender.setParameters return a promise. r=jesup,smaug MozReview-Commit-ID: 6lfmqpKevQl
b1b50935ab45f360774e75a4d814b2f9bf02d916: Bug 1249313 - Don't shut down the entire Cameras IPC if a single source is shut down. r=jesup
Gian-Carlo Pascutto <gcp@mozilla.com> - Tue, 23 Feb 2016 15:20:26 +0100 - rev 285764
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 1249313 - Don't shut down the entire Cameras IPC if a single source is shut down. r=jesup
3a0d8138b2775d90aea43ecdc89e11b19688a92f: Bug 1250540 - test media.getusermedia.screensharing.allowed_domains r=jesup
Jan-Ivar Bruaroey <jib@mozilla.com> - Tue, 23 Feb 2016 16:07:35 -0500 - rev 285763
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 1250540 - test media.getusermedia.screensharing.allowed_domains r=jesup MozReview-Commit-ID: 6qdzXHCi5Mk
637b9871727b0f493a259c78a0b8d5397efc8441: Bug 1250540 - have media.navigator.permission.disabled no longer bypass media.getusermedia.screensharing.allowed_domains. r=jesup
Jan-Ivar Bruaroey <jib@mozilla.com> - Tue, 23 Feb 2016 15:54:00 -0500 - rev 285762
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 1250540 - have media.navigator.permission.disabled no longer bypass media.getusermedia.screensharing.allowed_domains. r=jesup MozReview-Commit-ID: JTxeco3WGVr
8b1a92589f261739d31465457b2bea65f5a16518: Bug 1250540 - fix string-parsing regression that made screen share whitelisting stop working. r=jesup
Jan-Ivar Bruaroey <jib@mozilla.com> - Tue, 23 Feb 2016 11:30:49 -0500 - rev 285761
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 1250540 - fix string-parsing regression that made screen share whitelisting stop working. r=jesup MozReview-Commit-ID: AKux0nBVBEF
5a2fc31ff7897c2f87867dba09b78e1d3109438c: Bug 1244913 - Add test_peerConnection_scaleResolution.html r=bwc,jesup
Jan-Ivar Bruaroey <jib@mozilla.com> - Thu, 18 Feb 2016 01:18:13 -0500 - rev 285746
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 1244913 - Add test_peerConnection_scaleResolution.html r=bwc,jesup MozReview-Commit-ID: 8jeVEoL5JMR
607884f102a7daaf1092ae0ad94373669d4b64e2: Bug 1244913 - resolution-based bitrates for each simulcast layer, scaleResolutionDownBy, and working maxBitrate in unicast. r=bwc,jesup
Jan-Ivar Bruaroey <jib@mozilla.com> - Fri, 12 Feb 2016 19:56:56 -0500 - rev 285745
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 1244913 - resolution-based bitrates for each simulcast layer, scaleResolutionDownBy, and working maxBitrate in unicast. r=bwc,jesup MozReview-Commit-ID: 347J1ElsOEx
4acc0583de33a13a0986a0c53fe5789d890973d1: Bug 1244913 - change SelectBandwidth to SelectBitrates. r=jesup
Jan-Ivar Bruaroey <jib@mozilla.com> - Fri, 12 Feb 2016 16:08:00 -0500 - rev 285744
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 1244913 - change SelectBandwidth to SelectBitrates. r=jesup MozReview-Commit-ID: Gc5WN7JIozV
99a0241ace6b08565e1b8b816e48bb59d39a91e2: Bug 1249365 - Store Loops permission to use the camera so we can check later. r=jesup
Gian-Carlo Pascutto <gcp@mozilla.com> - Tue, 23 Feb 2016 12:09:44 +0100 - rev 285506
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 1249365 - Store Loops permission to use the camera so we can check later. r=jesup
94e55d77578dd3341b035bcfd7bb9a4e578f615b: Bug 1249369 - use UniquePtr instead of nsAutoArrayPtr in MediaPipeline.cpp; r=jesup
Nathan Froyd <froydnj@mozilla.com> - Thu, 18 Feb 2016 14:09:23 -0500 - rev 285151
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 1249369 - use UniquePtr instead of nsAutoArrayPtr in MediaPipeline.cpp; r=jesup
c1ce4aaa358769476f87fb0ad8312bd4bb79c808: Bug 1241153: Stop blocking addTrack on GMP init, and update codecs on existing tracks when GMP init finishes. r=jesup
Byron Campen [:bwc] <docfaraday@gmail.com> - Fri, 12 Feb 2016 14:21:33 -0600 - rev 285128
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 1241153: Stop blocking addTrack on GMP init, and update codecs on existing tracks when GMP init finishes. r=jesup MozReview-Commit-ID: GqUBh0O5Dpk
92827e1743bccc47d56a4dd312e5035f598262b8: Bug 1247236. r=jesup
Gian-Carlo Pascutto <gcp@mozilla.com> - Thu, 18 Feb 2016 17:25:22 +0100 - rev 285113
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 1247236. r=jesup
edd76ca3717f581c9c827396160b4e807fbcb781: Bug 1248770 - change sdp_unittests to cope with diverse c++ standard interpretations; r=jesup
Nathan Froyd <froydnj@mozilla.com> - Tue, 16 Feb 2016 21:09:34 -0500 - rev 285103
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 1248770 - change sdp_unittests to cope with diverse c++ standard interpretations; r=jesup The C++ standard, [facet.num.get.virtuals], defines the method to be used for reading numeric values from an iterator. The core loop is defined thusly in N3242 (the draft for the C++11 standard): Stage 2: If in==end then stage 2 terminates. Otherwise a charT is taken from in and local variables are initialized as if by char_type ct = *in; char c = src[find(atoms, atoms + sizeof(src) - 1, ct) - atoms]; if (ct == use_facet<numpunct<charT> >(loc).decimal_point()) c = '.'; bool discard = ct == use_facet<numpunct<charT> >(loc).thousands_sep() && use_facet<numpunct<charT> >(loc).grouping().length() != 0; where the values src and atoms are defined as if by: static const char src[] = "0123456789abcdefxABCDEFX+-"; char_type atoms[sizeof(src)]; use_facet<ctype<charT> >(loc).widen(src, src + sizeof(src), atoms); for this value of loc. If discard is true, then if '.' has not yet been accumulated, then the position of the character is remembered, but the character is otherwise ignored. Otherwise, if '.' has already been accumulated, the character is discarded and Stage 2 terminates. If the character is either discarded or accumulated then in is advanced by ++in and processing returns to the beginning of stage 2. Stage 3: The sequence of chars accumulated in stage 2 (the field) is converted to a numeric value by the rules of one of the functions declared in the header <cstdlib>: - For a signed integer value, the function strtoll. - For an unsigned integer value, the function strtoull. - For a floating-point value, the function strtold. The important part for our purposes here is the line: char c = src[find(atoms, atoms + sizeof(src) - 1, ct) - atoms]; which implies that we are to accumulate any and all characters that might be numerical constituents. According to the spec text, we might accumulate a long run of numeric constituents, only to decide in stage 3 that our accumulated string cannot be a valid number. Please note that this includes characters like 'x' and 'X' which are only valid as part of a hexadecimal prefix. sdp_unittests has a number of tests that look like: ParseInvalid<SdpImageattrAttributeList::XYRange>("[x", 1); The test converts the input string to a stringstream, and attempts to read an integer from the stream starting after the '[' character. The test expects that no input from the string stream will be consumed, as the character 'x' cannot begin any number, and thus the position of the stream after failure will be 1. This behavior is consistent with MSVC's standard library, libstdc++, and stlport. However, libc++ uses a different algorithm that appears to hew more closely to the letter of the spec, and consumes the 'x' character as being a valid constituent character ("accumulates" in the above text). The string is rejected as an invalid integer, yet the position of the string stream afterwards is different from what the test expects, and we therefore fail. This patch therefore alters a number of tests to use a different invalid character, 'v', that both the incremental algorithm (MSVC, libstdc++, stlport) and the all-at-once algorithm (libc++) will recognize as not being a valid constituent character and stop the parsing early, as expected. You might think that specifying the base for numeric input as std::dec would work, and it partially does, but reading floating-point numbers still reads the 'x' characters (!).
c5d6c3e00c91dd0595a12b145c66cf4f2a890591: Bug 1177242 - Verify whether sandboxed Content process has permissions to access the camera/mic. r=jesup
Gian-Carlo Pascutto <gcp@mozilla.com> - Wed, 17 Feb 2016 18:57:26 +0100 - rev 284959
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 1177242 - Verify whether sandboxed Content process has permissions to access the camera/mic. r=jesup
1aa33a896ebc515751daedf473adb768accc60ae: Bug 957691: Ensure that MediaManager ends all tracks before finishing its source stream r=jib,jesup,pehrsons
Andreas Pehrson <pehrsons@gmail.com> - Fri, 05 Feb 2016 13:20:20 +0100 - rev 284218
Push 19537 by kwierso@gmail.com at Wed, 17 Feb 2016 19:16:23 +0000
Bug 957691: Ensure that MediaManager ends all tracks before finishing its source stream r=jib,jesup,pehrsons This puts all the logic in GetUserMediaCallbackMediaStreamListener and none in MediaOperationTask to make it simpler to reason about what's happening. When we want to stop a track, the gUMCallbackListener will send a MEDIA_STOP_TRACK if other tracks will still be live. If it was the last live track, the gUMCallbackListener will send a MEDIA_STOP instead. The MEDIA_STOP makes sure the passed in devices (we pass in all) are stopped before finishing the stream. MozReview-Commit-ID: E43Iqw491tB
2ebbf6197fea27b6014ce74fcbd3a317d481162a: Bug 1230768. r=jesup
Gian-Carlo Pascutto <gcp@mozilla.com> - Wed, 10 Feb 2016 17:15:28 +0100 - rev 284155
Push 19537 by kwierso@gmail.com at Wed, 17 Feb 2016 19:16:23 +0000
Bug 1230768. r=jesup
39903dd406e14a242823e75094e71ac3ce1bcc24: Bug 1246011: fixed PT comparising for PT's without rtpmap. r=jesup
Nils Ohlmeier [:drno] <drno@ohlmeier.org> - Fri, 05 Feb 2016 11:58:05 -0800 - rev 283538
Push 19510 by gwagner@mozilla.com at Mon, 08 Feb 2016 15:56:48 +0000
Bug 1246011: fixed PT comparising for PT's without rtpmap. r=jesup
ad2838be66f2087cc67a24741b86b897e541c21e: Bug 1224845 - close sockets on errors and don't connect to IPv4 TURN TCP from IPv6 sockets. r=jesup
Nils Ohlmeier [:drno] <drno@ohlmeier.org> - Thu, 28 Jan 2016 10:53:56 -0800 - rev 283401
Push 19510 by gwagner@mozilla.com at Mon, 08 Feb 2016 15:56:48 +0000
Bug 1224845 - close sockets on errors and don't connect to IPv4 TURN TCP from IPv6 sockets. r=jesup