searching for reviewer(hiro)
b8d9e729d5b2637db9962da12633b41fc56e0898: Bug 1260353 - Remove unnecessary method AnimValuesStyleRule::AddPropertiesToSet() r=hiro
Ryo Kato <foobar094@gmail.com> - Tue, 29 Mar 2016 16:12:33 +0900 - rev 290918
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1260353 - Remove unnecessary method AnimValuesStyleRule::AddPropertiesToSet() r=hiro MozReview-Commit-ID: 3rRvYLNCvXE
e8e94146b659519531e03387e470d0ed788628ad: Bug 1244642 - Web-platform tests for AnimationEffectTiming.direction r=hiro
Ryo Kato <foobar094@gmail.com> - Sat, 26 Mar 2016 16:47:40 +0900 - rev 290697
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1244642 - Web-platform tests for AnimationEffectTiming.direction r=hiro MozReview-Commit-ID: Cxvizue8c9H
b51b8d9f8337666436cabe9f3a70727d89904464: Bug 1244642 - Implement AnimationEffectTiming.direction r=hiro
Ryo Kato <foobar094@gmail.com> - Sat, 26 Mar 2016 16:20:25 +0900 - rev 290696
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1244642 - Implement AnimationEffectTiming.direction r=hiro MozReview-Commit-ID: I8t011JVGBb
feb85260ffb750c7e0a3096e1ffd7134249d4e67: Bug 1259883 - Enable a test for player finishing behavior in file_animation-starttime.html r=hiro
emi suzuki <suzuming@gmail.com> - Sat, 26 Mar 2016 17:00:51 +0900 - rev 290569
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1259883 - Enable a test for player finishing behavior in file_animation-starttime.html r=hiro MozReview-Commit-ID: 1GPW9UsEK5E
5a2269c1f44800f43e0c876225f11784a480021b: Bug 1244640 - implement AnimationEffectTiming iterations r=hiro
Rob McAuley <rmcauley@gmail.com> - Sat, 26 Mar 2016 14:41:37 +0900 - rev 290560
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1244640 - implement AnimationEffectTiming iterations r=hiro MozReview-Commit-ID: Iwq6vleUERo
3e142ba20ecad6ee3aab402740a7f8f903089a5b: Bug 1245260 - Add crashtest; r=hiro
Brian Birtles <birtles@gmail.com> - Thu, 24 Mar 2016 09:04:53 +0900 - rev 290220
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1245260 - Add crashtest; r=hiro MozReview-Commit-ID: IBe0zbsCJJy
f45dafb23887313df248d5771d61c00cef724e7f: Bug 1257753 - Extend length of script animation in test to avoid intermittent failures; r=hiro
Brian Birtles <birtles@gmail.com> - Wed, 23 Mar 2016 09:40:31 +0900 - rev 290004
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1257753 - Extend length of script animation in test to avoid intermittent failures; r=hiro MozReview-Commit-ID: DHuWqOGWHqw
1bf7ebb9b6660727fc43f1958b3cbb5ffee5ebef: Bug 1254419 - Return animation property information from getProperties() even if the property is overridden; r=hiro
Brian Birtles <birtles@gmail.com> - Sun, 13 Mar 2016 19:22:35 +0800 - rev 289245
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1254419 - Return animation property information from getProperties() even if the property is overridden; r=hiro I think the reason we originally didn't do this is that the "isRunningOnCompositor" status might be misleading for animations that are being overridden. That is, there are some animations we don't send to the compositor because they are being overridden by another animation (e.g. a CSS animation touching the 'transform' animation will cause a CSS transition on the same property not to run, despite the fact that transitions apply higher in the cascade). This is not merely a performance optimization but means we don't have to do the cascade on the compositor. In the future, once we introduce additive animation, we won't be able to handle this so simply since it an animation will be able to be partially overridden. Instead, consumers of this API will need to look at the 'composite' member of the various animation values to see if an animation is being fully or partially overridden. As a result, this API really should return all running animations, even if they are currently being overridden. MozReview-Commit-ID: DwmbXdCqF32
4f5d2092a6c3d7e8b351db809852c8d6dba1f3ba: Bug 1254419 - Move GetPropertyState alongside GetFrames; r=hiro
Brian Birtles <birtles@gmail.com> - Tue, 15 Mar 2016 21:18:50 +0800 - rev 289242
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1254419 - Move GetPropertyState alongside GetFrames; r=hiro This better matches the order in the WebIDL and, once we rename GetPropertyState to GetProperties it will make sense for GetFrames and GetProperties to be side-by-side. MozReview-Commit-ID: 67s9WGksPFv
5b2891e4650c9b2a1bd5dc83703b19d4a4f681f5: Bug 1246320 part 5 - Simplify KeyframeEffect(ReadOnly) Constructor overloads further; r=hiro
Brian Birtles <birtles@gmail.com> - Sat, 12 Mar 2016 22:14:10 +0900 - rev 288604
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1246320 part 5 - Simplify KeyframeEffect(ReadOnly) Constructor overloads further; r=hiro As well as generally simplifying the different KeyframeEffect(ReadOnly) constructor methods, this patch also means we will use the realm document for parsing timing functions in all cases. Although this currently doesn't have any impact (the current set of timing functions are expected to be parsed identically regardless of the document used) it may become significant if, in future, it becomes possible to register hooks with certain documents for parsing CSS properties as part of the houdini efforts. MozReview-Commit-ID: 4gAZi1G1uAD
e56bc90e163def00e9703a886bec10b200465687: Bug 1246320 part 4 - Pass a document to TimingParams; r=hiro
Brian Birtles <birtles@gmail.com> - Fri, 11 Mar 2016 17:27:34 +0900 - rev 288603
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1246320 part 4 - Pass a document to TimingParams; r=hiro MozReview-Commit-ID: 9Sh8eWHdDD6
f7d44886eff3de4a8dc35ff1878c5c53dc3a6100: Bug 1246320 part 3 - Rework KeyframeEffect(ReadOnly) constructor helpers; r=hiro
Brian Birtles <birtles@gmail.com> - Fri, 11 Mar 2016 17:27:16 +0900 - rev 288602
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1246320 part 3 - Rework KeyframeEffect(ReadOnly) constructor helpers; r=hiro Once we update TimingParams to take a document, we will need to get an appropriate document within the various constructor methods. This complicates these methods and suggests they should be pushed into the .cpp file where we can hide the complexity more easily and templatize the type of the options argument so that we can share the document-fetching code. By moving all uses of the declared template methods to the .cpp file we can drop the explicit instantiations. (We still need to declare the templated methods in the header file since these methods need to be protected methods of KeyframeEffectReadOnly in order to construct a KeyframeEffectReadOnly since its constructor is protected.) MozReview-Commit-ID: 8KrCWrWIb7X
4ef42bdeeabb29139d828ef93af56a0a5ffa8c08: Bug 1246320 part 2 - Pass document to ParseEasing; r=hiro
Brian Birtles <birtles@gmail.com> - Fri, 11 Mar 2016 17:21:03 +0900 - rev 288601
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1246320 part 2 - Pass document to ParseEasing; r=hiro MozReview-Commit-ID: KWW53htO0Jj
6b6df349f7e92e49dc147bca2a43912e48ce851b: Bug 1254881 - Fix animation duration in dom/animation/test/chrome/test_running_on_compositor.html. r=hiro
Ryo Motozawa <motozawa@mozilla-japan.org> - Wed, 09 Mar 2016 01:08:00 -0500 - rev 288199
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1254881 - Fix animation duration in dom/animation/test/chrome/test_running_on_compositor.html. r=hiro MozReview-Commit-ID: Dd42HicB0Ci
1a9234d56ef23f614516143f79a08168cbf2401d: Bug 1244635 - Part4 Add enddelay tests in layout/style/test r=hiro
Ryo Motozawa <motozawa@mozilla-japan.org> - Tue, 08 Mar 2016 10:31:40 +0900 - rev 287796
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 1244635 - Part4 Add enddelay tests in layout/style/test r=hiro MozReview-Commit-ID: EUvAdiPudgZ
c167a14936ac6358270e28deca34478fe3344b02: Bug 1244635 - Part3 Add enddelay tests in testing/web-platform/tests/web-animations r=hiro
Ryo Motozawa <motozawa@mozilla-japan.org> - Tue, 08 Mar 2016 10:31:36 +0900 - rev 287795
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 1244635 - Part3 Add enddelay tests in testing/web-platform/tests/web-animations r=hiro MozReview-Commit-ID: GnIp7BmwPxw
e5a1593c8788bc47cd22474135275d65cd3e155c: Bug 1244635 - Part2 Add enddelay tests in dom/animation/test/chrome r=hiro
Ryo Motozawa <motozawa@mozilla-japan.org> - Tue, 08 Mar 2016 10:31:28 +0900 - rev 287794
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 1244635 - Part2 Add enddelay tests in dom/animation/test/chrome r=hiro MozReview-Commit-ID: Kylwd6UJcXH
46217739afcf8c8285dde7a31083b3a09088127c: Bug 1244635 - Part1 Add enddelay implementation in dom/animation/AnimationEffectTiming.cpp r=bz,hiro
Ryo Motozawa <motozawa@mozilla-japan.org> - Tue, 08 Mar 2016 10:31:10 +0900 - rev 287793
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 1244635 - Part1 Add enddelay implementation in dom/animation/AnimationEffectTiming.cpp r=bz,hiro MozReview-Commit-ID: 7t1fm0zB3V
3374f3adff0d3ededd3bdec631046bfe937afc71: Bug 1244641 - Part 6: Add duration tests in testing/web-platform/tests/web-animations. r=hiro
Ryo Motozawa <motozawa@mozilla-japan.org> - Sat, 27 Feb 2016 06:41:53 +0900 - rev 286335
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 1244641 - Part 6: Add duration tests in testing/web-platform/tests/web-animations. r=hiro MozReview-Commit-ID: Ff400yaXDLV
adc86cbfeb50c343216d67d4726d54cc46e1113d: Bug 1244641 - Part 5: Add duration tests in layout/style/test. r=hiro
Ryo Motozawa <motozawa@mozilla-japan.org> - Sat, 27 Feb 2016 06:41:40 +0900 - rev 286334
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 1244641 - Part 5: Add duration tests in layout/style/test. r=hiro MozReview-Commit-ID: JrsLXlvjJa8
57a37a771e9af2b94f5d7b0f7da1b35724e0ab13: Bug 1244641 - Part 4: Add duration tests in dom/animation/test/chrome. r=hiro
Ryo Motozawa <motozawa@mozilla-japan.org> - Sat, 27 Feb 2016 06:39:58 +0900 - rev 286333
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 1244641 - Part 4: Add duration tests in dom/animation/test/chrome. r=hiro MozReview-Commit-ID: H2XbCfrzn8o
0907eee5c44aa77a04d667a2ac458de5d2f63f5d: Bug 1244641 - Part 3: Notify animation mutation observers from AnimationEffectTiming::SetDuration. r=hiro
Ryo Motozawa <motozawa@mozilla-japan.org> - Sat, 27 Feb 2016 06:39:49 +0900 - rev 286332
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 1244641 - Part 3: Notify animation mutation observers from AnimationEffectTiming::SetDuration. r=hiro MozReview-Commit-ID: LxssvTBRbRF
bb39a42909ea76e5488ce754202bc5281c1f1f83: Bug 1244641 - Part 2: Add duration implementation in dom/animation/AnimationEffectTiming.cpp. r=hiro, r=smaug
Ryo Motozawa <motozawa@mozilla-japan.org> - Sat, 27 Feb 2016 06:39:39 +0900 - rev 286331
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 1244641 - Part 2: Add duration implementation in dom/animation/AnimationEffectTiming.cpp. r=hiro, r=smaug MozReview-Commit-ID: K5wmKo1U2JP
72317916a0f3f4994b2382d150e542646a448640: Bug 1244641 - Part 1: Let AnimationEffectTiming have an effect. r=hiro
Ryo Motozawa <motozawa@mozilla-japan.org> - Sat, 27 Feb 2016 06:39:30 +0900 - rev 286330
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 1244641 - Part 1: Let AnimationEffectTiming have an effect. r=hiro MozReview-Commit-ID: REfKyGs4HK
51bf027a5cebc58fb76356760bd41b3b803de95a: Bug 1245016 - b2g build failure in gfx/layers/ipc/LayerAnimationUtils.h r=hiro
Fabrice Desré <fabrice@mozilla.com> - Tue, 02 Feb 2016 01:53:05 -0800 - rev 282896
Push 19510 by gwagner@mozilla.com at Mon, 08 Feb 2016 15:56:48 +0000
Bug 1245016 - b2g build failure in gfx/layers/ipc/LayerAnimationUtils.h r=hiro
f58e7ca07205514611d65a65aba46cbf3db5cddf: Bug 1238660 part 3 - Add crashtest; r=hiro
Brian Birtles <birtles@gmail.com> - Wed, 13 Jan 2016 13:38:16 +0900 - rev 279742
Push 19289 by cbook@mozilla.com at Wed, 13 Jan 2016 11:01:03 +0000
Bug 1238660 part 3 - Add crashtest; r=hiro
fb40d887724cdae040a4abf28317f479071841fc: Bug 1238660 part 2 - Preserve "wins in cascade" state when updating animations; r=hiro
Brian Birtles <birtles@gmail.com> - Wed, 13 Jan 2016 13:38:16 +0900 - rev 279741
Push 19289 by cbook@mozilla.com at Wed, 13 Jan 2016 11:01:03 +0000
Bug 1238660 part 2 - Preserve "wins in cascade" state when updating animations; r=hiro When updating animations, we shouldn't unnecessarily clobber the "wins in cascade" state of their properties since this can lead to unnecessary restyles when we then decide we need to update the cascade.
9955578aabd17893c5db02fd6ab20599af970e3d: Bug 1238660 part 1 - Make mWinsInCascade initially false; r=hiro
Brian Birtles <birtles@gmail.com> - Wed, 13 Jan 2016 13:38:16 +0900 - rev 279740
Push 19289 by cbook@mozilla.com at Wed, 13 Jan 2016 11:01:03 +0000
Bug 1238660 part 1 - Make mWinsInCascade initially false; r=hiro As of bug 1228229, the mWinsInCascade member of animation properties is set consistently for both animations and transitions such that we only set this to true if an animation is "in effect". When an effect is initially created it is not "in effect" until it is attached to a non-idle animation. We should, therefore, initialize this to false and, when we become in effect, mark the cascade as needing an update.
462a51797af1901934d422606a6a090cdb96bab0: Bug 1226118 part 15 - Remove no-longer-necessary delays from test_running_on_compositor.html; r=hiro
Brian Birtles <birtles@gmail.com> - Fri, 04 Dec 2015 08:34:18 +0900 - rev 275592
Push 18919 by cbook@mozilla.com at Fri, 04 Dec 2015 11:06:02 +0000
Bug 1226118 part 15 - Remove no-longer-necessary delays from test_running_on_compositor.html; r=hiro Since part 3 in this patch series updated the way we clear the "running on compositor" flag, we can update these tests so they no longer wait for this flag (see bug 1226118 comment 21).
8fa1f59e73e3a19160b1cdf77019719fb558e8b5: Bug 1226118 part 7 - Rename and rework KeyframeEffectReadOnly::CanAnimatePropertyOnCompositor to ShouldBlockCompositorAnimations; r=hiro
Brian Birtles <birtles@gmail.com> - Fri, 04 Dec 2015 08:32:53 +0900 - rev 275583
Push 18919 by cbook@mozilla.com at Fri, 04 Dec 2015 11:06:02 +0000
Bug 1226118 part 7 - Rename and rework KeyframeEffectReadOnly::CanAnimatePropertyOnCompositor to ShouldBlockCompositorAnimations; r=hiro KeyframeEffectReadOnly::CanAnimatePropertyOnCompositor has a comment that says it, "Returns true |aProperty| can be run on compositor for |aFrame|" but it does nothing of the sort. What it *does* do is check answer the question, "If there happened to be an animation of |aProperty| on |aFrame|, should we still run animations on the compositor for this element?". This patch renames the method accordingly and moves the step where we iterate over a given effect's animated properties from AnimationCollection::CanPerformOnCompositor to inside this method, making this method a class method rather than a static method at the same time. As noted in the expanded comment, the approach of blocking opacity animations in these situations seems unnecessary but for now this patch just preserves the existing behavior.
fa002bc4a297a3ec769d37c5a2098e50159941fc: Bug 1226118 part 3 - Use EffectSet in CommonAnimationManager::ClearIsRunningOnCompositor; r=hiro, r=dholbert
Brian Birtles <birtles@gmail.com> - Fri, 04 Dec 2015 08:32:53 +0900 - rev 275579
Push 18919 by cbook@mozilla.com at Fri, 04 Dec 2015 11:06:02 +0000
Bug 1226118 part 3 - Use EffectSet in CommonAnimationManager::ClearIsRunningOnCompositor; r=hiro, r=dholbert
8fa6b8ebc6f16636dff0d68db36c4ee37b317f62: Bug 1219145 - nsRefreshDriver::IsJankCritical(). r=hiro
David Rajchenbach-Teller <dteller@mozilla.com> - Fri, 30 Oct 2015 14:35:46 +0100 - rev 274169
Push 18812 by cbook@mozilla.com at Thu, 26 Nov 2015 15:56:59 +0000
Bug 1219145 - nsRefreshDriver::IsJankCritical(). r=hiro To refine its alerts, Performance Stats API needs to be able to know whether a long-running operation is actually causing user-visible jank in the current process. This patch introduces a trivial API that lets clients ask the refresh driver whether any kind of animation is ongoing.
04420ed3c03678d0276c739df3b7e0830eae56e3: Bug 1127380 - Tests for Animation.playbackRate. r=hiro
Jonathan Watt <jwatt@jwatt.org> - Mon, 06 Jul 2015 00:22:00 +0200 - rev 251500
Push 16432 by kwierso@gmail.com at Tue, 07 Jul 2015 00:21:17 +0000
Bug 1127380 - Tests for Animation.playbackRate. r=hiro