searching for reviewer(glandium)
99f8eb253c8769c6752a98be0306249ed05d7731: Bug 1260241 - Implement Fennec packaging in Python. r=glandium
Nick Alexander <nalexander@mozilla.com> - Mon, 28 Mar 2016 20:01:07 -0700 - rev 291315
Push
19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1260241 - Implement Fennec packaging in Python. r=glandium
A few notes:
* This doesn't accommodate general OMNIJAR_NAME definitions. The
current name (assets/omni.ja) is baked into the product in a few
places, and is very unlikely to change, so we just error out if this
isn't true.
* This makes the package-manifest.in file authoritative for what goes
into assets/, libs/, and the APK root. Previously,
package-manifest.in wrote into assets/ and libs/ but
upload-files-APK.mk also had a convoluted DIST_FILES filtering
process to work through before a file actually made it into the APK.
* This is intentional about repackaging. It simplifies the repackage
step rather than trying to make unpackage-then-repackage the same as
just package. I pretty much never get repackaging correct the first
time; this should help. (I've manually tested it.)
* The ALREADY_SZIPPED during repackaging is subsumed by the previous
check if UNPACKAGE is set. The custom linker expects stored, not
deflated, libraries, so there's some small legwork to accommodate
that in mozjar.
MozReview-Commit-ID: JvVtIUSX685
bc439c65ecdcabcf039b9a4c6074380088d8530a: Bug 1260241 - Pre: Add compress option to Jarrer.add. r=glandium
Nick Alexander <nalexander@mozilla.com> - Mon, 28 Mar 2016 19:02:05 -0700 - rev 291314
Push
19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1260241 - Pre: Add compress option to Jarrer.add. r=glandium
MozReview-Commit-ID: FWXeBOi9FTY
cc70dae5693b38d6f5756141f2a45429ea8ffd1f: Bug 1249849: Ensure that we can always reach malloc_decl.h even when MOZ_REPLACE_ALLOC is not defined; r=glandium
Aaron Klotz <aklotz@mozilla.com> - Tue, 29 Mar 2016 13:59:14 -0600 - rev 291240
Push
19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1249849: Ensure that we can always reach malloc_decl.h even when MOZ_REPLACE_ALLOC is not defined; r=glandium
MozReview-Commit-ID: 5ok6K0cLJrt
65a35fd405becf742dd1b057830b755e1f4ce231: Bug 1260402 - Disable PulseAudio only on Gonk for B2G r=glandium
Alexandre Lissy <lissyx@lissyx.dyndns.org> - Tue, 29 Mar 2016 13:08:17 +0200 - rev 291216
Push
19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1260402 - Disable PulseAudio only on Gonk for B2G r=glandium
MozReview-Commit-ID: 8duWq1yDiJW
3713e22cafec9aa6cf0c39d279d22eca355a84f8: Bug 1260427 - Additional nspr/nss related old_configure_options. r=glandium
Hector Zhao <bzhao@mozilla.com> - Tue, 29 Mar 2016 21:57:03 +0800 - rev 291207
Push
19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1260427 - Additional nspr/nss related old_configure_options. r=glandium
MozReview-Commit-ID: Bre9H6hPlz5
0a14d675236ec1f37d1251b7e9ea5f9aa2aea35e: Bug 1181142 - Part 2: Make the minimum jemalloc4 allocation size 16 bytes on Windows 64. r=glandium
Eric Rahm <erahm@mozilla.com> - Thu, 24 Mar 2016 16:26:29 -0700 - rev 291041
Push
19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1181142 - Part 2: Make the minimum jemalloc4 allocation size 16 bytes on Windows 64. r=glandium
45c01e7fbe3fb034e0a2b5bfb6a6a745b19497ff: Bug 1181142 - Part 1: Make the minimum allocation size word sized on all platforms. r=glandium
Eric Rahm <erahm@mozilla.com> - Tue, 07 Jul 2015 17:36:31 -0700 - rev 291040
Push
19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1181142 - Part 1: Make the minimum allocation size word sized on all platforms. r=glandium
Bug 691003 made the minimum allocation size word sized for Linux and OS X, we
now need to do a similar change on Windows as well. For Windows the requirement
is 8-bytes on 32-bit and 16-bytes on 64-bit.
ca78a5af2576347a318789f34060e0abfd5c9640: Bug 1257870 - Require 1.5.0 --with-system-libvpx. r=glandium
Ralph Giles <giles@mozilla.com> - Tue, 22 Mar 2016 13:14:18 -0700 - rev 290770
Push
19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1257870 - Require 1.5.0 --with-system-libvpx. r=glandium
WebRTC code requires VP9E_SET_NOISE_SENSITIVITY from vpx/vp8cx.h
which was added in 1.4. We could feature test, but gating on
the minimum version seems better given the m4 code is to be
replaced by python.
We also depend on VPX_MAX_LAYERS wich is part of the 1.5.0 release.
This dependency was added with an SVC support patch in May 2015,
bug 1237023.
Optional --enable-spatial-svc is handled by the work-around
in
bug 1248335.
MozReview-Commit-ID: 79kg9JSFtJM
81fe08eb86f500d7d79bbdb4690c009b93baeadc: Bug 1259772 - don't pass -fno-reorder-functions to clang on Android; r=glandium
Nathan Froyd <froydnj.com> - Fri, 25 Mar 2016 18:28:32 -0400 - rev 290513
Push
19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1259772 - don't pass -fno-reorder-functions to clang on Android; r=glandium
e40580ed0fe6fab50f1d8d23747c2cf423d93016: bug 1247396 - drop support for MOZ_SHARED_ICU. r=glandium
Ted Mielczarek <ted@mielczarek.org> - Thu, 11 Feb 2016 08:21:16 -0500 - rev 290470
Push
19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
bug 1247396 - drop support for MOZ_SHARED_ICU. r=glandium
MozReview-Commit-ID: 54AQdzJqvvA
4593c32d5b81c5e2f2cd1332a7e49c3fc81cbcb0: Bug 1181142 - Part 1: Make the minimum allocation size word sized on all platforms. r=glandium
Eric Rahm <erahm@mozilla.com> - Tue, 07 Jul 2015 17:36:31 -0700 - rev 290367
Push
19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1181142 - Part 1: Make the minimum allocation size word sized on all platforms. r=glandium
Bug 691003 made the minimum allocation size word sized for Linux and OS X, we
now need to do a similar change on Windows as well. For Windows the requirement
is 8-bytes on 32-bit and 16-bytes on 64-bit.
39fb883bcd1c170c4fc5e80842273898ebb13e67: Bug 1239789 - Add secondary buffers to zxx_stream::StaticAllocator to handle reentrancy. r=glandium
Dylan Roeh <droeh@mozilla.com> - Thu, 24 Mar 2016 17:25:57 -0500 - rev 290360
Push
19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1239789 - Add secondary buffers to zxx_stream::StaticAllocator to handle reentrancy. r=glandium
8060bad4e3e0f3ba6afd3dabe5b0950ccea6fb57: Bug 1258257 - Reduce mozjemalloc page cache size from 4 MiB to 1 MiB. r=glandium.
Nicholas Nethercote <nnethercote@mozilla.com> - Thu, 24 Mar 2016 16:38:45 +1100 - rev 290251
Push
19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1258257 - Reduce mozjemalloc page cache size from 4 MiB to 1 MiB. r=glandium.
This reduces memory usage by up to 3 MiB per process.
MozReview-Commit-ID: Gfs9PIJM4br
c26f9e1dbad7eef1d74ec2e1c7c6aa7fe023a501: Bug 1249849: Make sure the correct implementations of malloc and free are used in DLL blocklist; r=glandium
Aaron Klotz <aklotz@mozilla.com> - Mon, 07 Mar 2016 14:12:31 -0800 - rev 290211
Push
19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1249849: Make sure the correct implementations of malloc and free are used in DLL blocklist; r=glandium
MozReview-Commit-ID: 7piMI6MwOZh
eb458f5d7b326bd0befe11f503b592b15b10e9e7: Bug 1258175 - Remove broken -Wunreachable-code-return and -Wunreachable-code-aggressive checks. r=glandium
Chris Peterson <cpeterson@mozilla.com> - Sat, 19 Mar 2016 00:10:37 -0700 - rev 290039
Push
19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1258175 - Remove broken -Wunreachable-code-return and -Wunreachable-code-aggressive checks. r=glandium
compiler-opts.m4's check for `MOZ_CXX_SUPPORTS_WARNING(-W, unreachable-code-return, ac_cxx_has_wunreachable_code_return)` is broken. The C/C++ code that configure emits for MOZ_CXX_SUPPORTS_WARNING() actually contains a -Wunreachable-code-return warning and, thus, doesn't actually detect that clang supports the -Wunreachable-code-return flag.
This configure code in MOZ_CXX_SUPPORTS_WARNING():
AC_TRY_COMPILE([],
[return(0);],
$3="yes",
$3="no")
generates something like:
int main() {
return(0);
; return 0; }
where the second return, automatically emitted by configure, is unreachable and causes a -Wunreachable-code-return warning.
The fix is to remove the redundant return(0) from MOZ_CXX_SUPPORTS_WARNING(). This allows clang's -Wunreachable-code-return flag to be detected, but then -Wunreachable-code-return breaks other configure checks, including third-party libraries' configure checks (in particular jemalloc) that also have redundant `return(0)`. So all the third-party libraries' configure checks would need to be fixed upstream, which seems like more hassle than the value of the -Wunreachable-code-return warnings.
d07193493b6a48cddda8a3e7aa64650c85ab9e3b: Bug 1258294 - Fix typo in Mulet moz.configure referencing wrong configure file r=glandium
Alexandre Lissy <lissyx@lissyx.dyndns.org> - Mon, 21 Mar 2016 10:42:40 +0100 - rev 289843
Push
19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1258294 - Fix typo in Mulet moz.configure referencing wrong configure file r=glandium
MozReview-Commit-ID: 8tXlm29uyt
1b70e9fe9db0c1829208283251e8edc308eee5f3: Bug 1256995 - Move --with-gradle to mobile/android/moz.configure. r=glandium
Nick Alexander <nalexander@mozilla.com> - Thu, 17 Mar 2016 11:04:08 -0700 - rev 289825
Push
19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1256995 - Move --with-gradle to mobile/android/moz.configure. r=glandium
This also adds a GRADLE_FLAGS environment variable for use in
automation.
Manually tested.
MozReview-Commit-ID: 8nDkqz2VnJn
36595ad87d9cc2dc85b2f4eaebeed57bdd203544: Bug 1258574 - Allow JARReader to read data already in memory; r=glandium
Gregory Szorc <gps@mozilla.com> - Mon, 21 Mar 2016 16:36:22 -0700 - rev 289786
Push
19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1258574 - Allow JARReader to read data already in memory; r=glandium
This will be needed to teach artifact builds to extract files from
omni.ja files whose content is loaded into memory (from a tar
archive).
MozReview-Commit-ID: LH2HkKx5Zj3
852ac8a4ec55b93df8c9740aafaee6b84f539c3d: Bug 1256694 - Loop should use MOZ_APP_MAXVERSION to generate the maximum supported Firefox version number to correctly support security builds (build sytem part). r=glandium
Mark Banner <standard8@mozilla.com> - Fri, 18 Mar 2016 09:31:56 +0000 - rev 289528
Push
19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1256694 - Loop should use MOZ_APP_MAXVERSION to generate the maximum supported Firefox version number to correctly support security builds (build sytem part). r=glandium
c1a7ef0126e5296593e71b0922cd0d6eb12cead4: Bug 1257435 - Package Universal CRT DLLs with jsshell; r=glandium
Gregory Szorc <gps@mozilla.com> - Thu, 17 Mar 2016 15:19:30 -0700 - rev 289501
Push
19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1257435 - Package Universal CRT DLLs with jsshell; r=glandium
Builds with Visual Studio 2015 require the Universal CRT. While the
universal CRT may be present on the target machine, there is no
guarantee of this. So, we have to package these DLLs to ensure target
machines are able to run js.exe.
Similar code to what this commit adds exists in build/win32/Makefile.in.
MozReview-Commit-ID: 8LIk1JlKLiT
48cc9c0818d01e51498959b0607724dfe8c9f4e8: Bug 1257435 - Move MSVC runtime DLL code outside of MOZ_SYSTEM_NSPR block; r=glandium
Gregory Szorc <gps@mozilla.com> - Thu, 17 Mar 2016 18:04:23 -0700 - rev 289500
Push
19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1257435 - Move MSVC runtime DLL code outside of MOZ_SYSTEM_NSPR block; r=glandium
Why it was the old way, I'm not sure.
MozReview-Commit-ID: FMmDbZI0NqL
69703aa2bad7349c95c549588db8bfbb3cac9a35: Bug 1257435 - Reformat make syntax to make easier to read; r=glandium
Gregory Szorc <gps@mozilla.com> - Thu, 17 Mar 2016 18:07:57 -0700 - rev 289499
Push
19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1257435 - Reformat make syntax to make easier to read; r=glandium
MozReview-Commit-ID: Ch86LX8Fx0q
a8bf532690746eae8ef90b9e4a9bcf8cdf30f091: Bug 1256966 - Move NIGHTLY_BUILD and RELEASE_BUILD to Python configure. r=glandium
Chris Manchester <cmanchester@mozilla.com> - Fri, 18 Mar 2016 11:24:11 -0700 - rev 289447
Push
19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1256966 - Move NIGHTLY_BUILD and RELEASE_BUILD to Python configure. r=glandium
MozReview-Commit-ID: 2Z3XMO2n681
25a721c6c7b7d0e89b0f3c5964cdf3f2384cb537: Bug 1257685 - Always read a mozconfig when printing help from python configure. r=glandium
Chris Manchester <cmanchester@mozilla.com> - Fri, 18 Mar 2016 11:24:11 -0700 - rev 289446
Push
19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1257685 - Always read a mozconfig when printing help from python configure. r=glandium
This restores help for project specific options.
MozReview-Commit-ID: 3n0TBnUb0K7
e1e446ee68823667291e2d6136398f1c948b925d: bug 1257607 - Add Version type to moz.configure. r=glandium
Ted Mielczarek <ted@mielczarek.org> - Thu, 17 Mar 2016 11:52:18 -0400 - rev 289423
Push
19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
bug 1257607 - Add Version type to moz.configure. r=glandium
This change adds a `Version` type to moz.configure which is a small
wrapper around `distutils.version.Version`. It's suitable for wrapping
version numbers in configure checks and doing equality or greater-than
less-than comparisons in a sensible way.
MozReview-Commit-ID: BOL6yvemulG
a5bd947546623f30a25113b0bb996d781ff938f2: bug 1257542 - check_prog template should sanity check that progs is not a string. r=glandium
Ted Mielczarek <ted@mielczarek.org> - Thu, 17 Mar 2016 11:04:12 -0400 - rev 289422
Push
19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
bug 1257542 - check_prog template should sanity check that progs is not a string. r=glandium
In Python parens around an expression without a trailing comma is not a tuple,
so ('foo') == 'foo'. This is really easy to screw up with check_progs, which
coerces progs to a list and would give you ['f','o','o'] in this case. This
patch enforces that the progs argument is a tuple or list and errors if it
is not.
MozReview-Commit-ID: 7BJZuF9B8D5
49ffdc680d6d80fc3d6ce159023a77364bb1880b: Bug 1231320: support min_scm_level and default secret specs; r=garndt,glandium,mshal
Dustin J. Mitchell <dustin@mozilla.com> - Tue, 15 Mar 2016 16:10:42 +0000 - rev 289327
Push
19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1231320: support min_scm_level and default secret specs; r=garndt,glandium,mshal
This improves support for fetching secrets to skip fetching, optionally
replacing with a default value, for builds based on trees with SCM levels below
a minimum. In practical terms, this allows try builds to operate without secrets.
MozReview-Commit-ID: 5DYSfzkYZQv
248034b32cbbf9c450a76fc1021e677d19ed8821: Bug 1250709 - Upgrade browser to gcc 4.9.3, r=glandium
Steve Fink <sfink@mozilla.com> - Thu, 11 Feb 2016 16:06:00 -0800 - rev 289030
Push
19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1250709 - Upgrade browser to gcc 4.9.3, r=glandium
652d09c3a912fd9af0aca7d944a5c8a825f56cf5: bug 1256614 - replace mozglue/linker/tests/Makefile.in with a PYTHON_UNIT_TEST. r=glandium
Ted Mielczarek <ted@mielczarek.org> - Tue, 15 Mar 2016 09:02:36 -0400 - rev 289023
Push
19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
bug 1256614 - replace mozglue/linker/tests/Makefile.in with a PYTHON_UNIT_TEST. r=glandium
MozReview-Commit-ID: 4qCDAKEY8b5
3a99126a3b55fc9f4bd327c4ed232cfd4284dcde: Bug 1092004 - Use getdtablesize for non-gonk builds as well. r=glandium
Nathan Toone <nathan@toonetown.com> - Mon, 14 Mar 2016 16:19:12 -0600 - rev 289015
Push
19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1092004 - Use getdtablesize for non-gonk builds as well. r=glandium
When building non-gonk builds, ANDROID_VERSION is not set. Beginning with NDK 11, getdtablesize is no longer included. This means that we should use the stub version of the function that is defined in android_stub.h for all android platforms. This patch moves the function out of the "#if ANDROID_VERSION >=21" block so that all android code can use it.
Adding glandium as the reviewer, because he reviewed the original patch at
bug 1103816.
MozReview-Commit-ID: 2NmUl5XuvDS
29022393615224517283b16adae938128f75e27b: Bug 1257005 - Don't use debug runtime in standalone SpiderMonkey builds; r=glandium
Gregory Szorc <gps@mozilla.com> - Tue, 15 Mar 2016 19:20:35 -0700 - rev 288952
Push
19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1257005 - Don't use debug runtime in standalone SpiderMonkey builds; r=glandium
This patch effectively synchronizes code from old-configure.in to
js/src/old-configure.in. Before, the top-level configure would set
MOZ_NO_DEBUG_RTL when using MOZ_MEMORY on Windows. This would get
inherited when the top-level configure invoked the js/src configure.
Since js/src's configure didn't have the same code, we never set
MOZ_NO_DEBUG_RTL when running a standalone js/src configure. This caused
the debug runtime to be used in standalone SpiderMonkey builds.
There is still some code in the root old-configure.in around CRT
handling that js/src/old-configure.in doesn't have. This will
likely get consolidated as part of the conversion to configure.py.
MozReview-Commit-ID: CD834DhIlLS
a007293e6ab06df203c09a5535f5591667c45af2: Bug 1257005 - Don't use debug runtime in standalone SpiderMonkey builds; r=glandium
Gregory Szorc <gps@mozilla.com> - Tue, 15 Mar 2016 16:27:28 -0700 - rev 288941
Push
19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1257005 - Don't use debug runtime in standalone SpiderMonkey builds; r=glandium
This patch effectively synchronizes code from old-configure.in to
js/src/old-configure.in. Before, the top-level configure would set
MOZ_NO_DEBUG_RTL when using MOZ_MEMORY on Windows. This would get
inherited when the top-level configure invoked the js/src configure.
Since js/src's configure didn't have the same code, we never set
MOZ_NO_DEBUG_RTL when running a standalone js/src configure. This caused
the debug runtime to be used in standalone SpiderMonkey builds.
MozReview-Commit-ID: CD834DhIlLS
c1d3b754cbcdd44fb5234c7c902517f557a6c882: Bug 1256033 - Remove layout/style/test/Makefile.in; r=glandium
Mike Shal <mshal@mozilla.com> - Fri, 11 Mar 2016 19:28:02 -0500 - rev 288906
Push
19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1256033 - Remove layout/style/test/Makefile.in; r=glandium
The css_properties.js rule can be converted into gen-css-properties.py,
which we can install with TEST_HARNESS_FILES instead of the
mochitest.ini manifest.
MozReview-Commit-ID: F7nf71ORWsS
d799cc3c6894621947b494b71b37e2b3ea337175: Bug 1256033 - Allow GENERATED_FILES scripts to depend on other generated files; r=glandium
Mike Shal <mshal@mozilla.com> - Fri, 11 Mar 2016 19:25:24 -0500 - rev 288905
Push
19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1256033 - Allow GENERATED_FILES scripts to depend on other generated files; r=glandium
If we add an ObjDirPath as an input to a GENERATED_FILES script, we
should run it in the misc tier to ensure the dependent files are created
beforehand. We need to use Path objects instead of raw filenames in the
GeneratedFile object so the recursive make backend can distinguish
between source and objdir files.
MozReview-Commit-ID: 9thHTi75zdI
bd4a4166af52256da8e99d90668bb40a82801694: Bug 1253436 - Write out a machine readable file with binaries metadata; r=glandium
Gregory Szorc <gps@mozilla.com> - Mon, 14 Mar 2016 21:06:57 -0700 - rev 288758
Push
19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1253436 - Write out a machine readable file with binaries metadata; r=glandium
This will make it easier for binaries only archive generation to consult
the list of binaries that are relevant to packaging.
This does overlap somewhat with compile databases. Perhaps someday the
logic could converge.
While I was here, I cleaned up writing of the all-tests.json file to
avoid an intermediate string variable.
This patch adds to_dict methods on some frontend data types. There is
room to improve the serialization of these types. For example, we could
use __slots__ to drive the default formatter. We could also leverage a
custom JSONEncoder class that knows how to call to_dict() on instances.
In the spirit of perfect is the enemy of done, I think this should be
deferred to a follow-up bug.
MozReview-Commit-ID: XVnKB1MNqu
e1533121f2e3adbe89e4a799c714d065a44ee5c3: Bug 1253436 - Add __repr__ to BaseLibrary and BaseProgram; r=glandium
Gregory Szorc <gps@mozilla.com> - Fri, 11 Mar 2016 11:22:48 -0800 - rev 288757
Push
19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1253436 - Add __repr__ to BaseLibrary and BaseProgram; r=glandium
Now when we print instances in a debugger, we'll see something like:
<StaticLibrary: other-licenses/snappy/libother-licenses_snappy.a>
<StaticLibrary: toolkit/library/StaticXULComponentsEnd/libStaticXULComponentsEnd.a>
<SharedLibrary: toolkit/library/XUL>
<StaticLibrary: toolkit/library/libxul_s.a>
<HostProgram: config/nsinstall_real>
<Program: memory/replace/logalloc/replay/logalloc-replay>
<SimpleProgram: mfbt/tests/TestArrayUtils>
... instead of the the class name and memory address.
MozReview-Commit-ID: 8zdrM6KfP8U
f1b77ed0c0c4a5d40d4ba854db9ae506d906b070: Bug 1253436 - Remove unused imports; r=glandium
Gregory Szorc <gps@mozilla.com> - Fri, 11 Mar 2016 11:22:28 -0800 - rev 288756
Push
19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1253436 - Remove unused imports; r=glandium
MozReview-Commit-ID: 494hmTwyldH
66445d3d11dea815db8888552910e7f836749d27: Bug 1250709 - Upgrade browser to gcc 4.9.3, r=glandium
Steve Fink <sfink@mozilla.com> - Thu, 11 Feb 2016 16:06:00 -0800 - rev 288753
Push
19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1250709 - Upgrade browser to gcc 4.9.3, r=glandium
4167dfdf10457360c9c94ee6e55b03ef1b92c16d: Bug 1253436 - Write out a machine readable file with binaries metadata; r=glandium
Gregory Szorc <gps@mozilla.com> - Mon, 14 Mar 2016 19:31:35 -0700 - rev 288743
Push
19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1253436 - Write out a machine readable file with binaries metadata; r=glandium
This will make it easier for binaries only archive generation to consult
the list of binaries that are relevant to packaging.
This does overlap somewhat with compile databases. Perhaps someday the
logic could converge.
While I was here, I cleaned up writing of the all-tests.json file to
avoid an intermediate string variable.
This patch adds to_dict methods on some frontend data types. There is
room to improve the serialization of these types. For example, we could
use __slots__ to drive the default formatter. We could also leverage a
custom JSONEncoder class that knows how to call to_dict() on instances.
In the spirit of perfect is the enemy of done, I think this should be
deferred to a follow-up bug.
MozReview-Commit-ID: XVnKB1MNqu
84849ad026c9ba1bbf71c93172b0a03440e51bec: Bug 1253436 - Add __repr__ to BaseLibrary and BaseProgram; r=glandium
Gregory Szorc <gps@mozilla.com> - Fri, 11 Mar 2016 11:22:48 -0800 - rev 288742
Push
19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1253436 - Add __repr__ to BaseLibrary and BaseProgram; r=glandium
Now when we print instances in a debugger, we'll see something like:
<StaticLibrary: other-licenses/snappy/libother-licenses_snappy.a>
<StaticLibrary: toolkit/library/StaticXULComponentsEnd/libStaticXULComponentsEnd.a>
<SharedLibrary: toolkit/library/XUL>
<StaticLibrary: toolkit/library/libxul_s.a>
<HostProgram: config/nsinstall_real>
<Program: memory/replace/logalloc/replay/logalloc-replay>
<SimpleProgram: mfbt/tests/TestArrayUtils>
... instead of the the class name and memory address.
MozReview-Commit-ID: 8zdrM6KfP8U
c4a868c76959d3a2e13af6ca5adb0d629dcb2b34: Bug 1253436 - Remove unused imports; r=glandium
Gregory Szorc <gps@mozilla.com> - Fri, 11 Mar 2016 11:22:28 -0800 - rev 288741
Push
19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1253436 - Remove unused imports; r=glandium
MozReview-Commit-ID: 494hmTwyldH
0737c6bd21e634dccceb7e13fee30e972d7c7835: Bug 1255963 - Detect warnings without space after line number; r=glandium
Gregory Szorc <gps@mozilla.com> - Fri, 11 Mar 2016 22:04:38 -0800 - rev 288725
Push
19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1255963 - Detect warnings without space after line number; r=glandium
I'm not sure when this changed, but at least Visual Studio 2015
doesn't always emit a space between the line number and the ": warning"
text in cl.exe output.
Making the space optional in the regular expression enables one a
VS2015 build to capture 375 warnings instead of 17. We still fail to
capture some warnings (notably generic warnings about bad command
arguments and linker warnings). But that can be dealt with later.
MozReview-Commit-ID: q402CxTrQK
1948da94cad89dfa407b842d361d5d49f6bcfa46: Bug 1254948 - Remove makefiles used to transition from jemalloc_config.c to jemalloc_config.cpp; r=glandium
Ms2ger <Ms2ger@gmail.com> - Thu, 10 Mar 2016 15:53:58 +0100 - rev 288178
Push
19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1254948 - Remove makefiles used to transition from jemalloc_config.c to jemalloc_config.cpp; r=glandium
9f6559ebb5932cdf9e0bd24bf91700f2bfa1a1a4: Bug 1254987 - Get the subconfigure working properly for mail/configure.in. r=glandium
Joshua Cranmer <Pidgeot18@gmail.com> - Wed, 09 Mar 2016 23:19:00 +0100 - rev 288169
Push
19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1254987 - Get the subconfigure working properly for mail/configure.in. r=glandium
ff8e90b810fc6a503d0573d512197a5fc7cf72e0: Bug 1254858: P9. Search libmozav* lib relative to lgpllibs. r=glandium
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 10 Mar 2016 17:56:34 +1100 - rev 288168
Push
19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1254858: P9. Search libmozav* lib relative to lgpllibs. r=glandium
XUL location can't be used as reference as its location varies.
MozReview-Commit-ID: EKGVpjeepIR
bb230d696c72adf0b1387b71ba01ee22c0308aca: Bug 1242632 - Remove TESTING_FILES from moz.build; r=glandium
Mike Shal <mshal@mozilla.com> - Mon, 25 Jan 2016 13:41:22 -0500 - rev 287979
Push
19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1242632 - Remove TESTING_FILES from moz.build; r=glandium
MozReview-Commit-ID: ALy4s6Xpg7f
079e85fe0e4d6271bd38ea6966950afd1b425b4c: Bug 1240149 - Build system changes necessary to run linux artifact builds in automation. r=glandium
Chris Manchester <cmanchester@mozilla.com> - Thu, 11 Feb 2016 18:46:46 -0800 - rev 287975
Push
19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1240149 - Build system changes necessary to run linux artifact builds in automation. r=glandium
MozReview-Commit-ID: CJ0CTBtklCs
9fddd3fdc22a8d82af84ac9b081585d2bea65b04: Bug 1254795 - Add missing --enable flags to old.configure. r=glandium
Patrick Cloke <clokep> - Tue, 08 Mar 2016 18:38:00 +0100 - rev 287914
Push
19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1254795 - Add missing --enable flags to old.configure. r=glandium
bf22fcece06e85cd195d61e37382ffc0084e4d05: Bug 1252639 (part 2) - Move contents of plarenas.h into plarena.h. r=glandium.
Nicholas Nethercote <nnethercote@mozilla.com> - Fri, 04 Mar 2016 10:36:51 +1100 - rev 287787
Push
19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 1252639 (part 2) - Move contents of plarenas.h into plarena.h. r=glandium.
Because the plarenas.h/plarena.h is strange and confusing. But the patch keeps
plarenas.h around in a way that the API doesn't change -- any code that
included plarena.h or plarenas.h should not need changing.
c661f2c5cd878c26e25abc0256b4893d8a249b49: Bug 1252639 (part 1) - Remove the shared PLArena freelist. r=glandium.
Nicholas Nethercote <nnethercote@mozilla.com> - Fri, 04 Mar 2016 10:35:13 +1100 - rev 287786
Push
19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 1252639 (part 1) - Remove the shared PLArena freelist. r=glandium.
It's not useful and just adds complexity.