searching for reviewer(gl)
1c7548ca0a5cdf41ba19239cb4665bf93218c1ae: Bug 1209273 - Part 3: Make CSS autocompletion tests pass. r=gl
Tobias Schneider <tschneider@mozilla.com> - Fri, 01 Apr 2016 22:37:49 -0700 - rev 291495
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1209273 - Part 3: Make CSS autocompletion tests pass. r=gl
2fd5231609577f953a0e932ce297b0a8e109412a: Bug 1143742 - part4: add textarea to valid targets when copying;r=gl
Julian Descottes <jdescottes@mozilla.com> - Wed, 30 Mar 2016 16:39:33 +0200 - rev 291374
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1143742 - part4: add textarea to valid targets when copying;r=gl When opening the context menu (and displaying the "copy" menu entry) or when receiving a copy event, we now check if the current target is a textarea. (multiline inplace editor relies on textarea) Modified existing test to check this new use case. MozReview-Commit-ID: Cgm67JCdN4c
ce42e52ab208465ef8bd5cb48e2fc8e1abe09501: Bug 1143742 - part3: multiline inplace-editor autocomplete behavior;r=gl
Julian Descottes <jdescottes@mozilla.com> - Wed, 30 Mar 2016 22:58:41 +0200 - rev 291373
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1143742 - part3: multiline inplace-editor autocomplete behavior;r=gl The default inplace-editor autocomplete behavior is not userfriendly when combined with a multiline inplace-editor. Navigating up/down might trigger an autocomplete suggestion. Also, the autocomplete popup is not displayed at the correct position and should take the multiline into account. MozReview-Commit-ID: JTiCQ3HK5bn
02c981b1fb557cda132abfc28ed2a92116871a50: Bug 1143742 - part2: multiline inplace-editor should support a maxWidth option;r=gl
Julian Descottes <jdescottes@mozilla.com> - Thu, 31 Mar 2016 00:59:16 +0200 - rev 291372
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1143742 - part2: multiline inplace-editor should support a maxWidth option;r=gl The inplaceEditor now supports a maxWidth configuration option which can either be a number or a method returning a number. This maxWidth will be applied to the hidden element used in order to autosize the input. MozReview-Commit-ID: JTiCQ3HK5bn
54e91ba66491139689a7104ad76b79be0ded042d: Bug 1143742 - part1: multiline inplace editor: cleanup existing tests;r=gl
Julian Descottes <jdescottes@mozilla.com> - Wed, 02 Mar 2016 17:11:09 +0100 - rev 291371
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1143742 - part1: multiline inplace editor: cleanup existing tests;r=gl In preparation for using a multiline editor for property values, tests need to be updated : - some tests used the "input" selector, which will no longer work with a textarea - some tests are relying on EventUtils.sendChar to send keys such as "VK_RETURN". Doing so also applies the shift key modifier, which has a specific behavior with multiline editors MozReview-Commit-ID: HkFxH3Go49E
9ea54d71bf06a175b13f0552920900bcadf2cb0a: Bug 1252925 - Add inactive color var, cleanup toolbar styles. r=gl,bgrins
J. Ryan Stinnett <jryans@gmail.com> - Thu, 24 Mar 2016 11:25:23 -0500 - rev 290817
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1252925 - Add inactive color var, cleanup toolbar styles. r=gl,bgrins MozReview-Commit-ID: Cz02wvkb4Hk
2b4d5580c46da0d6e83cf597cbfc3811b64332d0: Bug 1260235 - Only accept ctrl+f in computed and rule view if it happened in the relevant container;r=gl
Brian Grinstead <bgrinstead@mozilla.com> - Tue, 29 Mar 2016 14:25:02 -0700 - rev 290812
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1260235 - Only accept ctrl+f in computed and rule view if it happened in the relevant container;r=gl MozReview-Commit-ID: 4kMiWcqTra
dbb64aae2a239d1ae85a6591a57058ad29ab90e7: Bug 1255787 - Do not assume sourceMap appears only in external stylesheets; r=gl
Patrick Brosset <pbrosset@mozilla.com> - Tue, 29 Mar 2016 21:30:11 +0200 - rev 290802
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1255787 - Do not assume sourceMap appears only in external stylesheets; r=gl MozReview-Commit-ID: A92DdoAFDGT
9c6650c7e237b5f8473963565f7b6250cfe96a7a: Bug 1209273 - Part 3: Make CSS autocompletion tests pass. r=gl
Tobias Schneider <schneider@jancona.com> - Wed, 16 Mar 2016 13:43:00 -0400 - rev 289476
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1209273 - Part 3: Make CSS autocompletion tests pass. r=gl
043af397fef315bb89edbb63edad2298c5fee6e9: Bug 1254261 - Restore icons by using command button styles. r=gl,bgrins
J. Ryan Stinnett <jryans@gmail.com> - Wed, 09 Mar 2016 14:45:56 -0600 - rev 289065
Push 19656 by gwagner@mozilla.com at Mon, 04 Apr 2016 13:43:23 +0000
Bug 1254261 - Restore icons by using command button styles. r=gl,bgrins MozReview-Commit-ID: FPSk7RaMaxw
ae16b59ad2809f4e6a80af90cc691c789a42c316: Bug 1253901 - Update gcli script versions to jQuery 2.2.1, Lodash 4.6.1, and Underscore 1.8.3. r=gl
Chris Peterson <cpeterson@mozilla.com> - Sat, 05 Mar 2016 00:17:05 -0800 - rev 287551
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 1253901 - Update gcli script versions to jQuery 2.2.1, Lodash 4.6.1, and Underscore 1.8.3. r=gl
b8e594c21349c24f07bf6a63764f3c1bb9734e46: Bug 1253781 - Better perf with pure render. r=gl
J. Ryan Stinnett <jryans@gmail.com> - Fri, 04 Mar 2016 18:03:34 -0600 - rev 287388
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 1253781 - Better perf with pure render. r=gl There are few easy wins that greatly improve our perf with React: * Add the PureRenderMixin to pure components that always render the same thing given the same props and state. This implements React's shouldComponentUpdate as a shallow equality check of the props and state, so render() will be skipped if they match the previous values. * Change action dispatch functions so they are only created once instead of on each render(). If an outer component creates new functions for each render() call, then the PureRenderMixin equality check fails for only the new function instances, even though no data has changed. MozReview-Commit-ID: D96X048nEF4
5496f32b7b5a78ee24039fa4cae5e6f34f14dd2d: Bug 1250523 - Wait for the markup-view to be loaded in browser_markup_load_01.js; r=gl
Patrick Brosset <pbrosset@mozilla.com> - Mon, 29 Feb 2016 14:08:22 +0100 - rev 286376
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 1250523 - Wait for the markup-view to be loaded in browser_markup_load_01.js; r=gl MozReview-Commit-ID: 3BSuNy1DjZk
059d7b0fa76445a5cd675f493783081bb00872ef: Bug 1249888 - try/catch SourceMapConsumer to avoid empty rule-view when source map is invalid; r=gl
Patrick Brosset <pbrosset@mozilla.com> - Sat, 27 Feb 2016 20:39:21 +0100 - rev 286136
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 1249888 - try/catch SourceMapConsumer to avoid empty rule-view when source map is invalid; r=gl
0df0a7abe8a5bc93b36ec4065bde09f65257db59: Bug 1242057 - Enable all responsive probes on release. r=gl p=bsmedberg
J. Ryan Stinnett <jryans@gmail.com> - Tue, 23 Feb 2016 06:25:38 -0600 - rev 286122
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 1242057 - Enable all responsive probes on release. r=gl p=bsmedberg MozReview-Commit-ID: 6J0bwym78gs
825cd61d323da7ec9bdd516a2fc01e937ff1611b: Bug 1246677 - 10 - Removed addStyle from head.js since it was unused; r=gl
Patrick Brosset <pbrosset@mozilla.com> - Fri, 12 Feb 2016 14:28:54 +0100 - rev 286085
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 1246677 - 10 - Removed addStyle from head.js since it was unused; r=gl MozReview-Commit-ID: EgoEzxnILrJ
ce103dd1d95b3f3d4ed9fb121453a86e61122312: Bug 1246677 - 8 - Use addProperty and remove code duplication; r=gl
Patrick Brosset <pbrosset@mozilla.com> - Thu, 18 Feb 2016 11:00:38 +0100 - rev 286083
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 1246677 - 8 - Use addProperty and remove code duplication; r=gl MozReview-Commit-ID: KQXgdZxdiw9
684054d29f9b49e6445d74a9ac83e04f311d0c7f: Bug 1250398 - Disable APZ for source editors. r=gl
J. Ryan Stinnett <jryans@gmail.com> - Fri, 19 Feb 2016 20:08:10 -0600 - rev 286063
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 1250398 - Disable APZ for source editors. r=gl MozReview-Commit-ID: JmUuoobDr7y
e73efeaf2ec8332e30cbc8d224c3dc15dc38b686: Bug 1250434 - Bump up devtools tab width a bit to fix text overflow on Win7;r=gl
Brian Grinstead <bgrinstead@mozilla.com> - Wed, 24 Feb 2016 08:27:51 -0800 - rev 285678
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 1250434 - Bump up devtools tab width a bit to fix text overflow on Win7;r=gl MozReview-Commit-ID: AEp8Qhr1vXy
254c6ce06541ff04ed083dbc58623a4a2cebb110: Bug 1249650 - Give the toolbox tool container default styling to prevent flash of incorrect background when webconsole opens;r=gl
Brian Grinstead <bgrinstead@mozilla.com> - Wed, 24 Feb 2016 08:26:09 -0800 - rev 285677
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 1249650 - Give the toolbox tool container default styling to prevent flash of incorrect background when webconsole opens;r=gl MozReview-Commit-ID: 8X88NCyr7NR
a6d3a7a5e4ea08c41080c8a097fa08a0459db76e: Bug 1246677 - 10 - Removed addStyle from head.js since it was unused; r=gl
Patrick Brosset <pbrosset@mozilla.com> - Fri, 12 Feb 2016 14:28:54 +0100 - rev 285655
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 1246677 - 10 - Removed addStyle from head.js since it was unused; r=gl MozReview-Commit-ID: EgoEzxnILrJ
e450c5329a06f5a38933eed2f9541570f79ecb6f: Bug 1246677 - 8 - Use addProperty and remove code duplication; r=gl
Patrick Brosset <pbrosset@mozilla.com> - Thu, 18 Feb 2016 11:00:38 +0100 - rev 285653
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 1246677 - 8 - Use addProperty and remove code duplication; r=gl MozReview-Commit-ID: KQXgdZxdiw9
05f74b15d9cf3b53d2295f17f52524f81b8fc72b: Bug 1237885 - fix add-rules_01 intermittent by splitting in two tests;r=gl
Julian Descottes <jdescottes@mozilla.com> - Fri, 12 Feb 2016 12:35:51 +0100 - rev 285038
Push 19612 by gwagner@mozilla.com at Wed, 09 Mar 2016 16:35:37 +0000
Bug 1237885 - fix add-rules_01 intermittent by splitting in two tests;r=gl Intermittent test add-rules_01 has been split in two test. The original test was checking trying to create a set of rules first using the "add rule" button and then using the context menu. add-rules_01 only tests using the "add rule" button now. The context-menu tests have been moved to add-rules_05. Both tests are well under 45 seconds on Linux debug.
1e61354fe41ee770d61de5199a6f0977ae0437c3: Bug 1245947: Make devtools tabs smaller by default;r=gl
Brian Grinstead <bgrinstead@mozilla.com> - Mon, 15 Feb 2016 10:58:10 -0800 - rev 284473
Push 19537 by kwierso@gmail.com at Wed, 17 Feb 2016 19:16:23 +0000
Bug 1245947: Make devtools tabs smaller by default;r=gl MozReview-Commit-ID: KUHJtZxeMyI
fd4b62ebe725c28631be99c005060b7d57718c31: Bug 1241126 - ruleview: no new-prop editor on prev. editor blur;r=gl
Julian Descottes <jdescottes@mozilla.com> - Wed, 20 Jan 2016 18:55:39 +0100 - rev 282722
Push 19510 by gwagner@mozilla.com at Mon, 08 Feb 2016 15:56:48 +0000
Bug 1241126 - ruleview: no new-prop editor on prev. editor blur;r=gl Add a flag to check if the ruleview was displaying an editor before creating a newProperty editor. A new property editor is now only displayed if no other editor was previously displayed. Added new mochitest to check this use case.
8be5815e1c1ecb3bd3f03fccc93b5683ffa79c88: Bug 1241126 - ruleview property: open editor for prop. name on click on ":";r=gl
Julian Descottes <jdescottes@mozilla.com> - Fri, 22 Jan 2016 10:30:36 +0100 - rev 282721
Push 19510 by gwagner@mozilla.com at Mon, 08 Feb 2016 15:56:48 +0000
Bug 1241126 - ruleview property: open editor for prop. name on click on ":";r=gl When clicking on the ":" next to the name of a property, the editor is now opened for the name of the property instead of the value, Added a test to check this behaviour as well.
5a4ae5f447746a7d8472385c9195ba027ea24d88: Bug 1214177 - Allow focus inside HTML docs of inspector.xul; r=gl
Julian Descottes <jdescottes@mozilla.com> - Thu, 28 Jan 2016 01:44:36 +0100 - rev 282712
Push 19510 by gwagner@mozilla.com at Mon, 08 Feb 2016 15:56:48 +0000
Bug 1214177 - Allow focus inside HTML docs of inspector.xul; r=gl After Bug 1238133, HTML documents are directly loaded inside XUL elements. They inherit a -moz-user-focus: ignore; coming from minimal-xul.css. Usually this is overridden by xul.css, which restores -moz-user-focus: normal; on iframe, browser and some other elements. This commit adds a new class to all inspector tab panel elements including html, and a new CSS rule to override the default -moz-user-focus. Also added a new test case dedicated to this.
158e783ff542e1fdd7521304d9d482c944923e18: Bug 1241527 - 5 - Use ruleview-changed event to fix remaining pending requests in tests; r=gl
Patrick Brosset <pbrosset@mozilla.com> - Mon, 25 Jan 2016 16:22:07 +0100 - rev 281763
Push 19510 by gwagner@mozilla.com at Mon, 08 Feb 2016 15:56:48 +0000
Bug 1241527 - 5 - Use ruleview-changed event to fix remaining pending requests in tests; r=gl
906f6d928a6ddb3e9f8ac5c63ba5450b6b716022: Bug 1241527 - 4 - Use ruleview-changed event to avoid pending requests in browser_rules_multiple* tests; r=gl
Patrick Brosset <pbrosset@mozilla.com> - Fri, 22 Jan 2016 16:52:51 +0100 - rev 281499
Push 19421 by kwierso@gmail.com at Mon, 25 Jan 2016 22:06:58 +0000
Bug 1241527 - 4 - Use ruleview-changed event to avoid pending requests in browser_rules_multiple* tests; r=gl
68b6b0e7b20d38c1d3df8eb0f54c9d7d6302c7d1: Bug 1241527 - 3 - Fix typo in hideTooltipAndWaitForRuleviewChanged; r=gl
Patrick Brosset <pbrosset@mozilla.com> - Fri, 22 Jan 2016 16:35:22 +0100 - rev 281498
Push 19421 by kwierso@gmail.com at Mon, 25 Jan 2016 22:06:58 +0000
Bug 1241527 - 3 - Fix typo in hideTooltipAndWaitForRuleviewChanged; r=gl
77907e30ffd7497ea272d19ae1cfcfe7a4d68ebe: Bug 1241527 - 2 - Use ruleview-changed event to avoid pending requests when browser_rules_search-filter* tests end; r=gl
Patrick Brosset <pbrosset@mozilla.com> - Fri, 22 Jan 2016 16:30:22 +0100 - rev 281497
Push 19421 by kwierso@gmail.com at Mon, 25 Jan 2016 22:06:58 +0000
Bug 1241527 - 2 - Use ruleview-changed event to avoid pending requests when browser_rules_search-filter* tests end; r=gl
4632b46da8a647ba620ddc8f40889ee53706dd0b: Bug 1241527 - 1 - Fix some unhandled rejected promises in colorpicker, cubicbezier and cssfilter ruleview tests; r=gl
Patrick Brosset <pbrosset@mozilla.com> - Thu, 21 Jan 2016 17:35:04 +0100 - rev 281366
Push 19408 by philringnalda@gmail.com at Sun, 24 Jan 2016 02:31:06 +0000
Bug 1241527 - 1 - Fix some unhandled rejected promises in colorpicker, cubicbezier and cssfilter ruleview tests; r=gl
83844eb33969cc1fdcb44d2fb5c73b4782091ab7: Bug 1120406 - Indicate which nodes have a pseudo-class lock applied in the markup view;r=gl,r=pbrosset
Brian Grinstead <bgrinstead@mozilla.com> - Tue, 01 Sep 2015 11:45:53 -0700 - rev 260391
Push 17271 by ryanvm@gmail.com at Wed, 02 Sep 2015 01:21:39 +0000
Bug 1120406 - Indicate which nodes have a pseudo-class lock applied in the markup view;r=gl,r=pbrosset
69d9848dd6a5807f67edf4ac377fbe26d29a5c23: Bug 1150578 - Adjust the bluegrey color for DevTools theme;r=gl
Brian Grinstead <bgrinstead@mozilla.com> - Thu, 02 Jul 2015 14:13:34 -0700 - rev 251239
Push 16402 by cbook@mozilla.com at Fri, 03 Jul 2015 10:20:56 +0000
Bug 1150578 - Adjust the bluegrey color for DevTools theme;r=gl
a6424bfa8f39b4405846fd8b2600319e125f3237: Bug 1050940 - Nearly permanent on Linux debug browser_ruleview_keyframes-rule_02.js | Test timed out - Test timed out or Added opacity property should have been used. - Got 1, expected 0 r=gl
Gabriel Luong <gabriel.luong@gmail.com> - Fri, 08 Aug 2014 14:30:10 -0700 - rev 198647
Push 9578 by kwierso@gmail.com at Fri, 08 Aug 2014 21:44:09 +0000
Bug 1050940 - Nearly permanent on Linux debug browser_ruleview_keyframes-rule_02.js | Test timed out - Test timed out or Added opacity property should have been used. - Got 1, expected 0 r=gl CLOSED TREE