Bug 1473837 - AddonInstall should flush the jar cache for the temporary xpi file before trying to remove it. r=kmag default tip
authorLuca Greco <lgreco@mozilla.com>
Fri, 16 Aug 2019 21:49:33 +0000
changeset 488657 c4f020146cf861d73392c67e1f68ca494e0c7770
parent 488656 a5710687f9b44562f9ee54907ce81beb386da41b
push id92883
push userluca.greco@alcacoop.it
push dateSun, 18 Aug 2019 20:16:40 +0000
treeherderautoland@c4f020146cf8 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerskmag
bugs1473837
milestone70.0a1
Bug 1473837 - AddonInstall should flush the jar cache for the temporary xpi file before trying to remove it. r=kmag Differential Revision: https://phabricator.services.mozilla.com/D41360
toolkit/mozapps/extensions/internal/XPIInstall.jsm
--- a/toolkit/mozapps/extensions/internal/XPIInstall.jsm
+++ b/toolkit/mozapps/extensions/internal/XPIInstall.jsm
@@ -1474,16 +1474,17 @@ class AddonInstall {
       return;
     }
 
     try {
       this.logger.debug(
         `removeTemporaryFile: ${this.sourceURI.spec} removing temp file ` +
           this.file.path
       );
+      flushJarCache(this.file);
       this.file.remove(true);
       this.ownsTempFile = false;
     } catch (e) {
       this.logger.warn(
         `Failed to remove temporary file ${this.file.path} for addon ` +
           this.sourceURI.spec,
         e
       );