Bug 1476475 - Use -W4 for certverifier with clang-cl. r=froydnj
authorXidorn Quan <me@upsuper.org>
Fri, 20 Jul 2018 16:34:56 +1000
changeset 427719 ffb7bfbfc32868f7f31d86c28d305e4c23343e76
parent 427718 54c01f0092e1f1edcede61fd08042e99d76d5c30
child 427720 795f30107e2a31c04163a53397c4ed693b235e25
push id66692
push userxquan@mozilla.com
push dateSun, 22 Jul 2018 22:55:17 +0000
treeherderautoland@ffb7bfbfc328 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersfroydnj
bugs1476475
milestone63.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1476475 - Use -W4 for certverifier with clang-cl. r=froydnj MozReview-Commit-ID: 9OVJ2CFO0Qb
security/certverifier/moz.build
--- a/security/certverifier/moz.build
+++ b/security/certverifier/moz.build
@@ -56,17 +56,24 @@ LOCAL_INCLUDES += [
 DIRS += [
     '../pkix',
 ]
 
 TEST_DIRS += [
     'tests/gtest',
 ]
 
-CXXFLAGS += ['-Wall']
+if CONFIG['CC_TYPE'] == 'clang-cl':
+    # -Wall on clang-cl maps to -Weverything, which turns on way too
+    # much, so we're using -W4 instead, which is mapped to clang's
+    # -Wall -Wextra.
+    CXXFLAGS += ['-W4']
+else:
+    CXXFLAGS += ['-Wall']
+
 if CONFIG['CC_TYPE'] in ('msvc', 'clang-cl'):
     # -Wall with Visual C++ enables too many problematic warnings
     CXXFLAGS += [
         '-wd4324', # structure was padded due to __declspec(align())
         '-wd4355', # 'this' used in base member initializer list
         '-wd4464', # relative include path contains '..'
         '-wd4480', # nonstandard extension used: specifying underlying type for
                    # enum 'enum'