Bug 1568461 - Fix subtest alerting for youtube-playback tests r=rwood,perftest-reviewers
authorMarian Raiciof <mraiciof@mozilla.com>
Fri, 23 Aug 2019 09:28:04 +0000
changeset 489575 faf2a38a5c062b9c986e1bad3d422e6db9cf498e
parent 489574 c8fcbaade215ecf3cd353b4196787d8c5826527a
child 489576 ca7aac654642ea5b4e58e052680f6c3fd7eef635
push id93450
push usermraiciof@mozilla.com
push dateFri, 23 Aug 2019 09:32:01 +0000
treeherderautoland@faf2a38a5c06 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersrwood, perftest-reviewers
bugs1568461
milestone70.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1568461 - Fix subtest alerting for youtube-playback tests r=rwood,perftest-reviewers The alert_on values from the test INI were not being passed into the test settings json via manifest.py, this patch will fix this. Differential Revision: https://phabricator.services.mozilla.com/D43049
testing/raptor/raptor/output.py
--- a/testing/raptor/raptor/output.py
+++ b/testing/raptor/raptor/output.py
@@ -873,16 +873,21 @@ class Output(object):
                 _subtests[name] = {
                     'name': name,
                     'unit': unit,
                     'lowerIsBetter': lower_is_better,
                     'replicates': [],
                 }
 
             _subtests[name]['replicates'].append(value)
+            if self.subtest_alert_on is not None:
+                if name in self.subtest_alert_on:
+                    LOG.info("turning on subtest alerting for measurement type: %s"
+                             % name)
+                    _subtests[name]['shouldAlert'] = True
 
         for pagecycle in data:
             for _sub, _value in pagecycle[0].iteritems():
                 try:
                     percent_dropped = float(_value['droppedFrames']) / _value['decodedFrames'] \
                                       * 100.0
                 except ZeroDivisionError:
                     # if no frames have been decoded the playback failed completely