Bug 1562745 - Make OSX10.14 debug tests actually use debug builds. r=jmaher
☠☠ backed out by 942002d2bf09 ☠ ☠
authorGeoff Brown <gbrown@mozilla.com>
Fri, 05 Jul 2019 12:56:54 +0000
changeset 481478 f9c0c52368d637bcd8aeb3dc4a767ef5f914c0a5
parent 481477 a030c27bb1c1b523b16d1b3da70ed1dac1ef0310
child 481479 4544e7e71ba01f4415986f781b88040af90127d5
push id89232
push usergbrown@mozilla.com
push dateFri, 05 Jul 2019 18:13:16 +0000
treeherderautoland@f9c0c52368d6 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjmaher
bugs1562745
milestone69.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1562745 - Make OSX10.14 debug tests actually use debug builds. r=jmaher As far as I can tell, the intermittent suite_start failures are due to stdout/stderr output interleaving -- a known issue for reftest logging, without a clear way forward. Let's work around it the same way we did on Windows. Differential Revision: https://phabricator.services.mozilla.com/D37023
layout/tools/reftest/runreftest.py
taskcluster/ci/test/reftest.yml
taskcluster/ci/test/test-platforms.yml
--- a/layout/tools/reftest/runreftest.py
+++ b/layout/tools/reftest/runreftest.py
@@ -760,17 +760,17 @@ class RefTest(object):
 
         kp_kwargs = {
             'kill_on_timeout': False,
             'cwd': SCRIPT_DIRECTORY,
             'onTimeout': [timeoutHandler],
             'processOutputLine': [self.outputHandler],
         }
 
-        if mozinfo.isWin:
+        if mozinfo.isWin or mozinfo.isMac:
             # Prevents log interleaving on Windows at the expense of losing
             # true log order. See bug 798300 and bug 1324961 for more details.
             kp_kwargs['processStderrLine'] = [self.outputHandler]
 
         if interactive:
             # If an interactive debugger is attached,
             # don't use timeouts, and don't capture ctrl-c.
             timeout = None
--- a/taskcluster/ci/test/reftest.yml
+++ b/taskcluster/ci/test/reftest.yml
@@ -85,18 +85,18 @@ jsreftest:
             android-hw.*/(opt|pgo)?: 6
             windows.*\/opt: 2
             windows10-64-asan/opt: 3
             windows10-64-ccov/debug: 5
             linux64-ccov/.*: 5
             linux64-qr/opt: 4
             linux64-qr/debug: 5
             linux64/debug: 5
-            macosx.*-64-ccov/debug: 5
-            macosx.*-64(-shippable)?/.*: 2
+            macosx.*-64(-ccov)/debug: 5
+            macosx.*-64(-shippable)?/opt: 2
             default: 3
     max-run-time:
         by-test-platform:
             android-em.*: 7200
             windows10-64-ccov/debug: 7200
             macosx.*64-ccov/debug: 7200
             linux.*64-ccov/debug: 7200
             default: 3600
--- a/taskcluster/ci/test/test-platforms.yml
+++ b/taskcluster/ci/test/test-platforms.yml
@@ -278,17 +278,17 @@ macosx1014-64-shippable/opt:
         - awsy
         - raptor-chromium
         - raptor-firefox
         - raptor-profiling
         - marionette-media-tests
         - web-platform-tests-wdspec-headless
 
 macosx1014-64/debug:
-    build-platform: macosx64-shippable/opt
+    build-platform: macosx64/debug
     test-sets:
         - macosx1014-64-tests
         # - marionette-media-tests
 
 macosx1014-64-devedition/opt:
     build-platform: macosx64-devedition-nightly/opt
     test-sets:
         - macosx1014-64-tests