author | Julian Descottes <jdescottes@mozilla.com> |
Tue, 10 Oct 2017 19:49:04 +0200 | |
changeset 385364 | f580e00e8f62b7c53844d97948b396e6a1752f7f |
parent 385363 | 4c86b1f93b8482ea3097a4edb51bb8c0e8dc67fc |
child 385365 | e3834abf326e8dd949dc28475cb3606d890c50a1 |
push id | 52991 |
push user | jdescottes@mozilla.com |
push date | Tue, 10 Oct 2017 18:23:05 +0000 |
treeherder | autoland@f580e00e8f62 [default view] [failures only] |
perfherder | [talos] [build metrics] [platform microbench] (compared to previous push) |
reviewers | rpl |
bugs | 1407326 |
milestone | 58.0a1 |
first release with | nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
|
last release without | nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
|
--- a/browser/components/extensions/ext-devtools-panels.js +++ b/browser/components/extensions/ext-devtools-panels.js @@ -83,17 +83,16 @@ class ParentDevToolsPanel { const extensionName = this.context.extension.name; this.toolbox.addAdditionalTool({ id: this.id, url: "about:blank", icon: icon, label: title, tooltip: `DevTools Panel added by "${extensionName}" add-on.`, - invertIconForLightTheme: false, visibilityswitch: `devtools.webext-${this.id}.enabled`, isTargetSupported: target => target.isLocalTab, build: (window, toolbox) => { if (toolbox !== this.toolbox) { throw new Error("Unexpected toolbox received on addAdditionalTool build property"); } const destroy = this.buildPanel(window);
--- a/browser/components/extensions/test/browser/browser_ext_devtools_panel.js +++ b/browser/components/extensions/test/browser/browser_ext_devtools_panel.js @@ -209,19 +209,16 @@ add_task(async function test_devtools_pa is(toolboxAdditionalTools.length, 1, "Got the expected number of toolbox specific panel registered."); await testThemeSwitching(extension); const panelDef = toolboxAdditionalTools[0]; const panelId = panelDef.id; - is(panelDef.invertIconForLightTheme, false, - "devtools.panel.create set invertIconForLightTheme to false by default"); - await gDevTools.showToolbox(target, panelId); const {devtoolsPageTabId} = await extension.awaitMessage("devtools_panel_shown"); const devtoolsPanelTabId = await extension.awaitMessage("devtools_panel_inspectedWindow_tabId"); is(devtoolsPanelTabId, devtoolsPageTabId, "Got the same devtools.inspectedWindow.tabId from devtools page and panel"); is(await extension.awaitMessage("initial_theme_panel"), "light", "The initial theme is reported as expected from a devtools panel.");