Bug 1716046 - Add "left" and "right" as invalid values to align-* and place-* properties in property_database.js. r=emilio
authorTing-Yu Lin <tlin@mozilla.com>
Fri, 11 Jun 2021 23:05:02 +0000
changeset 582910 f3bce321b3e5c1d277e61e7ebf7c776b1c1e5ab8
parent 582909 1a73cdcee34418639a30d3c278f59aef0d348fff
child 582911 a6ec3acd5daf3837939903c145553cab2d44cdcd
push id144850
push useraethanyc@gmail.com
push dateFri, 11 Jun 2021 23:14:44 +0000
treeherderautoland@f3bce321b3e5 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersemilio
bugs1716046
milestone91.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1716046 - Add "left" and "right" as invalid values to align-* and place-* properties in property_database.js. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D117556
layout/style/test/property_database.js
--- a/layout/style/test/property_database.js
+++ b/layout/style/test/property_database.js
@@ -9354,16 +9354,18 @@ var gCSSProperties = {
       "normal safe start",
       "unsafe end start",
       "end start safe",
       "space-between unsafe",
       "stretch safe",
       "auto",
       "first",
       "last",
+      "left",
+      "right",
     ],
   },
   "align-items": {
     domProp: "alignItems",
     inherited: false,
     type: CSS_TYPE_LONGHAND,
     initial_values: ["normal"],
     other_values: [
@@ -9390,16 +9392,18 @@ var gCSSProperties = {
       "end legacy",
       "unsafe",
       "unsafe baseline",
       "normal unsafe",
       "safe left unsafe",
       "safe stretch",
       "end end",
       "auto",
+      "left",
+      "right",
     ],
   },
   "align-self": {
     domProp: "alignSelf",
     inherited: false,
     type: CSS_TYPE_LONGHAND,
     initial_values: ["auto"],
     other_values: [
@@ -9411,17 +9415,25 @@ var gCSSProperties = {
       "stretch",
       "first baseline",
       "last baseline",
       "baseline",
       "unsafe center",
       "self-start",
       "safe self-end",
     ],
-    invalid_values: ["space-between", "abc", "30px", "stretch safe", "safe"],
+    invalid_values: [
+      "space-between",
+      "abc",
+      "30px",
+      "stretch safe",
+      "safe",
+      "left",
+      "right",
+    ],
   },
   "justify-content": {
     domProp: "justifyContent",
     inherited: false,
     type: CSS_TYPE_LONGHAND,
     initial_values: ["normal"],
     other_values: [
       "start",
@@ -9561,17 +9573,25 @@ var gCSSProperties = {
       "space-evenly",
       "flex-start",
       "end",
       "unsafe start",
       "safe center",
       "baseline",
       "last baseline",
     ],
-    invalid_values: ["none", "center safe", "right / end"],
+    invalid_values: [
+      "none",
+      "center safe",
+      "right / end",
+      "left",
+      "right",
+      "left left",
+      "right right",
+    ],
   },
   "place-items": {
     domProp: "placeItems",
     inherited: false,
     type: CSS_TYPE_TRUE_SHORTHAND,
     subproperties: ["align-items", "justify-items"],
     initial_values: ["normal"],
     other_values: [
@@ -9587,16 +9607,20 @@ var gCSSProperties = {
     ],
     invalid_values: [
       "space-between",
       "start space-evenly",
       "none",
       "end/end",
       "center safe",
       "auto start",
+      "left",
+      "right",
+      "left left",
+      "right right",
     ],
   },
   "place-self": {
     domProp: "placeSelf",
     inherited: false,
     type: CSS_TYPE_TRUE_SHORTHAND,
     subproperties: ["align-self", "justify-self"],
     initial_values: ["auto"],
@@ -9616,16 +9640,20 @@ var gCSSProperties = {
     invalid_values: [
       "space-between",
       "start space-evenly",
       "none",
       "end safe",
       "auto legacy left",
       "legacy left",
       "auto/auto",
+      "left",
+      "right",
+      "left left",
+      "right right",
     ],
   },
   flex: {
     domProp: "flex",
     inherited: false,
     type: CSS_TYPE_TRUE_SHORTHAND,
     subproperties: ["flex-grow", "flex-shrink", "flex-basis"],
     initial_values: ["0 1 auto", "auto 0 1", "0 auto", "auto 0"],