Sync Bug 1399245: Fix mozilla/normandy#1036: Remove OSX-specific close button CSS for Heartbeat bar. r=Gijs
authorMichael Kelly <mkelly@mozilla.com>
Tue, 12 Sep 2017 13:27:12 -0700
changeset 380403 f2bd9e8d0975b435bd437b001d94200d43cab5ff
parent 380402 a104181ac18b7d25cb058790d09a024d24f0a333
child 380404 9771577eeeaefd398137f1dba84da326e7974691
push id51057
push usermkelly@mozilla.com
push dateWed, 13 Sep 2017 01:40:23 +0000
treeherderautoland@9771577eeeae [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersGijs
bugs1399245
milestone57.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Sync Bug 1399245: Fix mozilla/normandy#1036: Remove OSX-specific close button CSS for Heartbeat bar. r=Gijs Due to changes in browser styles for Photon, the fix is no longer necessary, and in fact makes the close button look wrong. Without the fix, the close button looks and behaves the same as the tab bar close buttons. MozReview-Commit-ID: 89tCvQAq1OR
browser/extensions/shield-recipe-client/skin/osx/Heartbeat.css
--- a/browser/extensions/shield-recipe-client/skin/osx/Heartbeat.css
+++ b/browser/extensions/shield-recipe-client/skin/osx/Heartbeat.css
@@ -4,21 +4,8 @@
 
 /* Notification overrides for Heartbeat UI */
 
 notification.heartbeat {
   background-image: linear-gradient(-179deg, #FBFBFB 0%, #EBEBEB 100%) !important;
   border-bottom: 1px solid #C1C1C1 !important;
   height: 40px;
 }
-
-/* In themes/osx/global/notification.css the close icon is inverted because notifications
-   on OSX are usually dark. Heartbeat is light, so override that behaviour. */
-
-notification.heartbeat[type="info"] .close-icon:not(:hover) {
-  -moz-image-region: rect(0, 16px, 16px, 0) !important;
-}
-
-@media (min-resolution: 2dppx) {
-  notification.heartbeat[type="info"] .close-icon:not(:hover) {
-    -moz-image-region: rect(0, 32px, 32px, 0) !important;
-  }
-}