Bug 1595656 - isUserFacingLogin should only exclude the FxA one, not legacy extension ones. r=sfoster
☠☠ backed out by 141a109d768e ☠ ☠
authorMatthew Noorenberghe <mozilla@noorenberghe.ca>
Wed, 20 Nov 2019 22:55:12 +0000
changeset 503122 ef8d5090979a392b69500f0a43402d42a2fea529
parent 503121 095697ce7a2e134fd5a17f85bc25073243187484
child 503123 061c92c4b95c161ed9baedbb84aa27e2b0a99028
push id101129
push usermozilla@noorenberghe.ca
push dateWed, 20 Nov 2019 23:11:27 +0000
treeherderautoland@061c92c4b95c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerssfoster
bugs1595656
milestone72.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1595656 - isUserFacingLogin should only exclude the FxA one, not legacy extension ones. r=sfoster We shouldn't hide data saved by legacy extensions, the user should remain in control of them since they may contain credentials they want to delete. Differential Revision: https://phabricator.services.mozilla.com/D53833
toolkit/components/passwordmgr/LoginHelper.jsm
--- a/toolkit/components/passwordmgr/LoginHelper.jsm
+++ b/toolkit/components/passwordmgr/LoginHelper.jsm
@@ -1100,17 +1100,17 @@ this.LoginHelper = {
     Services.obs.notifyObservers(
       dataObject,
       "passwordmgr-storage-changed",
       changeType
     );
   },
 
   isUserFacingLogin(login) {
-    return !login.origin.startsWith("chrome://");
+    return login.origin != "chrome://FirefoxAccounts"; // FXA_PWDMGR_HOST
   },
 
   async getAllUserFacingLogins() {
     try {
       let logins = await Services.logins.getAllLoginsAsync();
       return logins.filter(this.isUserFacingLogin);
     } catch (e) {
       if (e.result == Cr.NS_ERROR_ABORT) {