Bug 567169: Followup changeset 4a3e8596e8fc - addresses review comments I neglected to process when pushing the patch. a=blocking-betaN
authorBas Schouten <bschouten@mozilla.com>
Fri, 30 Jul 2010 21:31:15 +0200
changeset 48428 ee3ab2be004033aa352e9a3ca86e96f6cd49844a
parent 48427 a4494a32a9110a6d4c3dc30aea2b3419744ab6e6
child 48429 71d27f203ef5a506ce1cfb792e2f79ddd30db286
push id14729
push userbschouten@mozilla.com
push dateFri, 30 Jul 2010 19:32:02 +0000
treeherderautoland@ee3ab2be0040 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersblocking-betaN
bugs567169
milestone2.0b3pre
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 567169: Followup changeset 4a3e8596e8fc - addresses review comments I neglected to process when pushing the patch. a=blocking-betaN
content/canvas/src/nsCanvasRenderingContext2D.cpp
--- a/content/canvas/src/nsCanvasRenderingContext2D.cpp
+++ b/content/canvas/src/nsCanvasRenderingContext2D.cpp
@@ -3515,17 +3515,17 @@ nsCanvasRenderingContext2D::DrawImage(ns
                 ShadowFinalize(blur);
             }
         }
 
         mThebes->SetPattern(pattern);
         DirtyAllStyles();
 
         /* Direct2D isn't very good at clipping so use Fill() when we can */
-        if (CurrentState().globalAlpha = 1. && mThebes->CurrentOperator() == gfxContext::OPERATOR_OVER) {
+        if (CurrentState().globalAlpha == 1.0f && mThebes->CurrentOperator() == gfxContext::OPERATOR_OVER) {
             mThebes->Rectangle(clip);
             mThebes->Fill();
         } else {
             /* we need to use to clip instead of fill for globalAlpha */
             mThebes->Clip(clip);
             mThebes->Paint(CurrentState().globalAlpha);
         }
         dirty = mThebes->UserToDevice(clip);