Bug 1510030 - Don't return the current opacity value from update_opacity_binding. r=gw
☠☠ backed out by 7a5cb26a2d51 ☠ ☠
authorHiroyuki Ikezoe <hikezoe.birchill@mozilla.com>
Wed, 26 Feb 2020 09:25:13 +0000
changeset 515788 edc3c212be1fefa3b05200d1d7665be28e40167e
parent 515787 149f61b5d2d6cf38b37b98aaa3a1dd483d615187
child 515789 c3e6c17ba7b0cae28b49a99836a5814264fd4825
push id108449
push userhikezoe.birchill@mozilla.com
push dateThu, 27 Feb 2020 00:34:01 +0000
treeherderautoland@1bf2a082ca62 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersgw
bugs1510030
milestone75.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1510030 - Don't return the current opacity value from update_opacity_binding. r=gw The return value is not used at all. Differential Revision: https://phabricator.services.mozilla.com/D63600
gfx/wr/webrender/src/prim_store/mod.rs
--- a/gfx/wr/webrender/src/prim_store/mod.rs
+++ b/gfx/wr/webrender/src/prim_store/mod.rs
@@ -4301,23 +4301,20 @@ pub fn get_line_decoration_size(
         LineOrientation::Vertical => LayoutSize::new(perpendicular, parallel),
     })
 }
 
 fn update_opacity_binding(
     opacity_bindings: &mut OpacityBindingStorage,
     opacity_binding_index: OpacityBindingIndex,
     scene_properties: &SceneProperties,
-) -> f32 {
-    if opacity_binding_index == OpacityBindingIndex::INVALID {
-        1.0
-    } else {
+) {
+    if opacity_binding_index != OpacityBindingIndex::INVALID {
         let binding = &mut opacity_bindings[opacity_binding_index];
         binding.update(scene_properties);
-        binding.current
     }
 }
 
 /// Trait for primitives that are directly internable.
 /// see SceneBuilder::add_primitive<P>
 pub trait InternablePrimitive: intern::Internable<InternData = PrimitiveSceneData> + Sized {
     /// Build a new key from self with `info`.
     fn into_key(