Bug 1579546 - remove `SK_BUILD_FOR_ANDROID_NDK` define; r=lsalzman
authorNathan Froyd <froydnj@mozilla.com>
Fri, 06 Sep 2019 21:42:27 +0000
changeset 492146 ea140be277eea5e729f338611f60676bbb1826e8
parent 492145 9e38d12a61b2106f08bdffac0de627757a40769a
child 492147 07f0801f694047accad5ce116e61d515dca834d8
push id94771
push usernfroyd@mozilla.com
push dateSat, 07 Sep 2019 19:57:42 +0000
treeherderautoland@ea140be277ee [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerslsalzman
bugs1579546
milestone71.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1579546 - remove `SK_BUILD_FOR_ANDROID_NDK` define; r=lsalzman This define is unused, modulo some apparently dead patches in the gfx/skia/patches/archive/ directory. Differential Revision: https://phabricator.services.mozilla.com/D45086
toolkit/moz.configure
--- a/toolkit/moz.configure
+++ b/toolkit/moz.configure
@@ -820,23 +820,16 @@ def skia(value):
         die('--disable-skia is not supported anymore')
     else:
         return True
 
 set_config('MOZ_ENABLE_SKIA', skia)
 set_define('MOZ_ENABLE_SKIA', skia)
 set_define('USE_SKIA', skia)
 
-@depends(skia, target)
-def skia_android(skia, target):
-    if skia and target.os == 'Android':
-        return True
-
-set_define('SK_BUILD_FOR_ANDROID_NDK', skia_android)
-
 option('--enable-skia-pdf', help='Enable Skia PDF')
 
 @depends('--enable-skia-pdf', skia, target, milestone)
 def skia_pdf(value, skia, target, milestone):
     if value.origin == 'default':
         if not skia:
             return None
         if milestone.is_nightly and target.os != 'WINNT':