Bug 1386160 - Add separators for each level 1 header to match the Photon visual spec. r=jaws
authorEvan Tseng <evan@tseng.io>
Fri, 04 Aug 2017 16:01:27 +0800
changeset 374069 ea0c21ef7e3ccddefb2f9bc88a9fcff5b2c91be9
parent 374068 01b5b211063ca2d7f9328f0d033623b97d61ad7c
child 374070 cff0baa2b08dfa3f7386995a9773a0b09a5f11b7
push id48515
push userrchien@mozilla.com
push dateFri, 11 Aug 2017 02:25:47 +0000
treeherderautoland@ea0c21ef7e3c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjaws
bugs1386160
milestone57.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1386160 - Add separators for each level 1 header to match the Photon visual spec. r=jaws MozReview-Commit-ID: 7iyZuFgqrSQ
browser/themes/shared/incontentprefs/preferences.inc.css
--- a/browser/themes/shared/incontentprefs/preferences.inc.css
+++ b/browser/themes/shared/incontentprefs/preferences.inc.css
@@ -90,32 +90,28 @@ caption > label {
   min-width: 145px;
 }
 
 /* Subcategory title */
 
 /**
  * The first subcategory title for each category should not have margin-top.
  */
-#generalCategory,
-#searchCategory,
-#browserPrivacyCategory,
-#firefoxAccountCategory {
-  margin-top: 0;
+
+.subcategory:not([hidden]) ~ .subcategory {
+  margin-top: 32px;
+  padding-top: 15px;
+  border-top: 1px solid rgba(12, 12, 13, 0.15);
 }
 
 .header-name {
   font-size: 2rem;
   font-weight: 300;
 }
 
-.subcategory {
-  margin-top: 48px;
-}
-
 /* Category List */
 
 #categories {
   max-height: 100vh;
 }
 
 #categories > scrollbox {
   overflow-x: hidden !important;