Bug 1640716 - correct string substitution in mozbuild/frontend/reader.py r=jmaher
authoregao <egao@mozilla.com>
Tue, 26 May 2020 09:57:17 +0000
changeset 532229 e803948bb3cd52dae5566bfc517e3d04f06252e7
parent 532228 4acc76fa4ceaa0af1979228a178ee7698fb46954
child 532230 65266126fcb81f9efbb7666a02743b99a64f9ee3
push id117080
push useregao@mozilla.com
push dateTue, 26 May 2020 18:36:59 +0000
treeherderautoland@e803948bb3cd [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjmaher
bugs1640716
milestone78.0a1
first release with
nightly linux32
e803948bb3cd / 78.0a1 / 20200526213752 / files
nightly linux64
e803948bb3cd / 78.0a1 / 20200526213752 / files
nightly mac
e803948bb3cd / 78.0a1 / 20200526213752 / files
nightly win32
e803948bb3cd / 78.0a1 / 20200526213752 / files
nightly win64
e803948bb3cd / 78.0a1 / 20200526213752 / files
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
releases
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1640716 - correct string substitution in mozbuild/frontend/reader.py r=jmaher Changes: Current in-tree code will simply print `{path}` as many times as it reads a path. This change will ensure that paths that have been read are output to the screen, which is much more useful. Differential Revision: https://phabricator.services.mozilla.com/D76729
python/mozbuild/mozbuild/frontend/reader.py
--- a/python/mozbuild/mozbuild/frontend/reader.py
+++ b/python/mozbuild/mozbuild/frontend/reader.py
@@ -1086,21 +1086,21 @@ class BuildReader(object):
 
         except Exception as e:
             raise BuildReaderError(list(self._execution_stack),
                                    sys.exc_info()[2], other_error=e)
 
     def _read_mozbuild(self, path, config, descend, metadata):
         path = mozpath.normpath(path)
         log(self._log, logging.DEBUG, 'read_mozbuild', {'path': path},
-            'Reading file: {path}')
+            'Reading file: {path}'.format(path=path))
 
         if path in self._read_files:
             log(self._log, logging.WARNING, 'read_already', {'path': path},
-                'File already read. Skipping: {path}')
+                'File already read. Skipping: {path}'.format(path=path))
             return
 
         self._read_files.add(path)
 
         time_start = time.time()
 
         topobjdir = config.topobjdir