Bug 1382827 - |mach try --artifact| should remove |--artifact| if "-nightly" platforms are requested. r=chmanchester
authorEd Lee <edilee@mozilla.com>
Thu, 20 Jul 2017 13:37:31 -0700
changeset 370190 df26ae1f7cbf95159b04ca68097029d56303d57e
parent 370189 9aa5577c8716fa2f4dbbb0497cb9425245568e46
child 370191 d8ce629418ee90a1555ddfeb7fdb6a12f20ee266
push id46982
push useredilee@gmail.com
push dateFri, 21 Jul 2017 18:52:14 +0000
treeherderautoland@df26ae1f7cbf [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerschmanchester
bugs1382827
milestone56.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1382827 - |mach try --artifact| should remove |--artifact| if "-nightly" platforms are requested. r=chmanchester MozReview-Commit-ID: Dqle5sBlZNr
testing/tools/autotry/autotry.py
--- a/testing/tools/autotry/autotry.py
+++ b/testing/tools/autotry/autotry.py
@@ -406,16 +406,21 @@ class AutoTry(object):
                     for test in flavor_tests:
                         paths.add("%s:%s" % (flavor, test))
                     suites[job_name] = tests.get(suite, [])
 
         # intersection implies tests are expected
         if intersection and not suites:
             raise ValueError("No tests found matching filters")
 
+        if extras.get('artifact') and any([p.endswith("-nightly") for p in platforms]):
+            print('You asked for |--artifact| but "-nightly" platforms don\'t have artifacts. '
+                  'Running without |--artifact| instead.')
+            del extras['artifact'];
+
         if extras.get('artifact'):
             rejected = []
             for suite in suites.keys():
                 if any([suite.startswith(c) for c in self.compiled_suites]):
                     rejected.append(suite)
             if rejected:
                 raise ValueError("You can't run {} with "
                                  "--artifact option.".format(', '.join(rejected)))