Bug 1559994 - Add notifySaved argument to promptToChangePassword on nsILoginManagerPrompter.
authorMatthew Noorenberghe <mozilla@noorenberghe.ca>
Sat, 13 Jul 2019 06:01:51 +0000
changeset 482708 dd1dbf88a31b37b955b736431a77cf65dae42780
parent 482707 1f4a148d28f847957a3c9f601e7ab4d34a0cbfa0
child 482709 3e793ca066f227fcc3c25e31925d3729ca8593f8
push id89925
push usermozilla@noorenberghe.ca
push dateSat, 13 Jul 2019 06:02:51 +0000
treeherderautoland@dd1dbf88a31b [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1559994
milestone70.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1559994 - Add notifySaved argument to promptToChangePassword on nsILoginManagerPrompter. Differential Revision: https://phabricator.services.mozilla.com/D37974
toolkit/components/passwordmgr/LoginManagerParent.jsm
toolkit/components/passwordmgr/nsILoginManagerPrompter.idl
--- a/toolkit/components/passwordmgr/LoginManagerParent.jsm
+++ b/toolkit/components/passwordmgr/LoginManagerParent.jsm
@@ -733,17 +733,17 @@ this.LoginManagerParent = {
     log(
       "_onGeneratedPasswordFilled: show dismissed save-password notification"
     );
     let browser = browsingContext.top.embedderElement;
     let prompter = this._getPrompter(browser, openerTopWindowID);
     prompter.promptToSavePassword(
       formLogin,
       true, // dimissed prompt
-      shouldSaveLogin // attention
+      shouldSaveLogin // notifySaved
     );
   },
 
   /**
    * Maps all the <browser> elements for tabs in the parent process to the
    * current state used to display tab-specific UI.
    *
    * This mapping is not updated in case a web page is moved to a different
--- a/toolkit/components/passwordmgr/nsILoginManagerPrompter.idl
+++ b/toolkit/components/passwordmgr/nsILoginManagerPrompter.idl
@@ -69,17 +69,18 @@ interface nsILoginManagerPrompter : nsIS
    * @param aNewLogin
    *        The new login.
    * @param dismissed
    *        A boolean value indicating whether the save logins doorhanger should
    *        be dismissed automatically when shown.
    */
   void promptToChangePassword(in nsILoginInfo aOldLogin,
                               in nsILoginInfo aNewLogin,
-                              in boolean dismissed);
+                              [optional] in boolean dismissed,
+                              [optional] in boolean notifySaved);
 
   /**
    * Ask the user if they want to change the password for one of
    * multiple logins, when the caller can't determine exactly which
    * login should be changed. If the user consents, modifyLogin() will
    * be called.
    *
    * @param logins