Backed out changeset f2530502f6c4 (bug 1266808) for test_imagebitmap_close.html&/test_imagebitmap_cropping.html failures
authorBogdan Tara <btara@mozilla.com>
Fri, 27 Sep 2019 12:14:29 +0300
changeset 495249 dc80991796e0d65a3a92db25139ac332fbc0e219
parent 495248 14e2e5325cec207461a9185adb1804bcb56d1fb2
child 495250 abc8072a0b3b863ade7382ece5b768665b35e347
push id96551
push userbtara@mozilla.com
push dateFri, 27 Sep 2019 09:14:53 +0000
treeherderautoland@dc80991796e0 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1266808
milestone71.0a1
backs outf2530502f6c4790ba778f1ceab633fcf161fc2f6
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset f2530502f6c4 (bug 1266808) for test_imagebitmap_close.html&/test_imagebitmap_cropping.html failures
dom/canvas/CanvasRenderingContext2D.cpp
testing/web-platform/meta/2dcontext/imagebitmap/createImageBitmap-drawImage-closed.html.ini
--- a/dom/canvas/CanvasRenderingContext2D.cpp
+++ b/dom/canvas/CanvasRenderingContext2D.cpp
@@ -4370,17 +4370,16 @@ void CanvasRenderingContext2D::DrawImage
     if (canvas->IsWriteOnly()) {
       SetWriteOnly();
     }
   } else if (aImage.IsImageBitmap()) {
     ImageBitmap& imageBitmap = aImage.GetAsImageBitmap();
     srcSurf = imageBitmap.PrepareForDrawTarget(mTarget);
 
     if (!srcSurf) {
-      aError.Throw(NS_ERROR_DOM_INVALID_STATE_ERR);
       return;
     }
 
     if (imageBitmap.IsWriteOnly()) {
       SetWriteOnly();
     }
 
     imgSize = intrinsicImgSize =
new file mode 100644
--- /dev/null
+++ b/testing/web-platform/meta/2dcontext/imagebitmap/createImageBitmap-drawImage-closed.html.ini
@@ -0,0 +1,4 @@
+[createImageBitmap-drawImage-closed.html]
+  [attempt to draw a closed ImageBitmap to a 2d canvas throws INVALID_STATE_ERR]
+    expected: FAIL
+