Backed out changeset 827a1c12a137 (bug 1538158) for bc failures at browser_action_searchengine.js.
authorBrindusan Cristian <cbrindusan@mozilla.com>
Thu, 28 Mar 2019 14:46:16 +0200
changeset 466574 db92f218cea95be1596b1be70ccb80db7024eae7
parent 466573 72493e9686d8ab6aef64694fea8f36b165efab4a
child 466575 a597a0295d90209160e08dfa6d715e39f63415f0
child 466629 1ef00231db5339e9208c4ceda5e570a69eff8af4
push id81675
push usercbrindusan@mozilla.com
push dateThu, 28 Mar 2019 12:46:53 +0000
treeherderautoland@db92f218cea9 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1538158
milestone68.0a1
backs out827a1c12a137e05172d6f24c509ad9acc62035c0
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset 827a1c12a137 (bug 1538158) for bc failures at browser_action_searchengine.js.
browser/components/urlbar/UrlbarInput.jsm
browser/components/urlbar/tests/browser/browser.ini
browser/components/urlbar/tests/browser/browser_dropmarker.js
--- a/browser/components/urlbar/UrlbarInput.jsm
+++ b/browser/components/urlbar/UrlbarInput.jsm
@@ -532,17 +532,17 @@ class UrlbarInput {
       return;
     }
 
     if (resetSearchState) {
       this._resetSearchState();
     }
 
     if (!searchString) {
-      searchString = this.valueIsTyped ? this.textValue : "";
+      searchString = this.textValue;
     } else if (!this.textValue.startsWith(searchString)) {
       throw new Error("The current value doesn't start with the search string");
     }
     this._lastSearchString = searchString;
 
     // TODO (Bug 1522902): This promise is necessary for tests, because some
     // tests are not listening for completion when starting a query through
     // other methods than startQuery (input events for example).
--- a/browser/components/urlbar/tests/browser/browser.ini
+++ b/browser/components/urlbar/tests/browser/browser.ini
@@ -28,17 +28,16 @@ skip-if = os != "mac" # Mac only feature
 [browser_autoFill_caretNotAtEnd.js]
 [browser_autoFill_placeholder.js]
 [browser_autoFill_preserve.js]
 [browser_autoFill_trimURLs.js]
 [browser_autoFill_typed.js]
 [browser_canonizeURL.js]
 [browser_caret_navigation.js]
 [browser_dragdropURL.js]
-[browser_dropmarker.js]
 [browser_keepStateAcrossTabSwitches.js]
 [browser_keyword_override.js]
 [browser_keyword_select_and_type.js]
 [browser_keyword.js]
 support-files =
   print_postdata.sjs
 [browser_locationBarCommand.js]
 [browser_locationBarExternalLoad.js]
deleted file mode 100644
--- a/browser/components/urlbar/tests/browser/browser_dropmarker.js
+++ /dev/null
@@ -1,19 +0,0 @@
-/* Any copyright is dedicated to the Public Domain.
- * http://creativecommons.org/publicdomain/zero/1.0/
- */
-
-"use strict";
-
-add_task(async function() {
-  await BrowserTestUtils.withNewTab({ gBrowser, url: "http://example.com/" }, async () => {
-    await UrlbarTestUtils.promisePopupOpen(window, () => {
-      let historyDropMarker =
-        window.document.getAnonymousElementByAttribute(gURLBar.textbox, "anonid", "historydropmarker");
-      EventUtils.synthesizeMouseAtCenter(historyDropMarker, {}, window);
-    });
-    let queryContext = await gURLBar.lastQueryContextPromise;
-    is(queryContext.searchString, "",
-       "Clicking the history dropmarker should initiate an empty search instead of searching for the loaded URL");
-    await UrlbarTestUtils.promisePopupClose(window);
-  });
-});