Bug 1494187 - Run the manifest download steps before trying to update the manifest, r=ato
authorJames Graham <james@hoppipolla.co.uk>
Thu, 27 Sep 2018 14:37:47 +0100
changeset 438713 daf8260b674ded70fddf2c8161d76563f95ef2d4
parent 438712 b96612d7ee8811a94132f6f0b7e8e0a9e36e8ffa
child 438714 0167fcc847d836cf24161016a33cdc684e4a3745
push id70086
push usertoros@mozilla.com
push dateFri, 28 Sep 2018 15:41:28 +0000
treeherderautoland@dbe2506cadd0 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersato
bugs1494187
milestone64.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1494187 - Run the manifest download steps before trying to update the manifest, r=ato This ensures that we always start from a partial manifest where possible and also ensures that the configuration files are correctly created (a refactor to create these irrespective of whether we do a download would make sense, but this fixes the immediate problem) Depends on D7088 Differential Revision: https://phabricator.services.mozilla.com/D7089
testing/web-platform/mach_commands.py
--- a/testing/web-platform/mach_commands.py
+++ b/testing/web-platform/mach_commands.py
@@ -430,16 +430,17 @@ class MachCommands(MachCommandBase):
     def create_wpt(self, **params):
         return self.create_web_platform_test(**params)
 
     @Command("wpt-manifest-update",
              category="testing",
              parser=create_parser_manifest_update)
     def wpt_manifest_update(self, **params):
         self.setup()
+        self.wpt_manifest_download(**params)
         wpt_manifest_updater = self._spawn(WPTManifestUpdater)
         return wpt_manifest_updater.run_update(**params)
 
     @Command("wpt-manifest-download",
              category="testing",
              parser=create_parser_manifest_download)
     def wpt_manifest_download(self, **params):
         self.setup()