Bug 1531975 - just do a gfxCriticalNote on buffer-provider over-production instead of an error r=nical
☠☠ backed out by 4dc7ad52faf2 ☠ ☠
authorLee Salzman <lsalzman@mozilla.com>
Thu, 07 Mar 2019 16:08:34 +0000
changeset 462919 da9a99c4896c2576a72d6ef9798ea11d9153dddc
parent 462918 0fc3a7dd1b3e266fca5d936e84d1b709c8d34aaa
child 462920 664fd8f4cc02b58208f2e49b7c8aac0aac9a1e09
push id79919
push userlsalzman@mozilla.com
push dateThu, 07 Mar 2019 16:13:02 +0000
treeherderautoland@da9a99c4896c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersnical
bugs1531975
milestone67.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1531975 - just do a gfxCriticalNote on buffer-provider over-production instead of an error r=nical Differential Revision: https://phabricator.services.mozilla.com/D22518
gfx/layers/PersistentBufferProvider.cpp
--- a/gfx/layers/PersistentBufferProvider.cpp
+++ b/gfx/layers/PersistentBufferProvider.cpp
@@ -299,17 +299,17 @@ PersistentBufferProviderShared::BorrowDr
           gfxCriticalNote << "Managed to allocate after flush.";
           mBack = Some(i);
           tex = mTextures[i];
           break;
         }
       }
 
       if (!tex) {
-        gfxCriticalError() << "Unexpected BufferProvider over-production.";
+        gfxCriticalNote() << "Unexpected BufferProvider over-production.";
         // It would be pretty bad to keep piling textures up at this point so we
         // call NotifyInactive to remove some of our textures.
         NotifyInactive();
         // Give up now. The caller can fall-back to a non-shared buffer
         // provider.
         return nullptr;
       }
     }