Bug 1411290 - Make menulist label text visible for popup permission in identity manager in localized builds. r=johannh
authorPrathiksha <prathikshaprasadsuman@gmail.com>
Tue, 24 Oct 2017 22:49:55 +0530
changeset 388704 d60b8971ecd96bb95ad77a5656d1dd381178e27a
parent 388703 29c198c5db81b6aaed8a8b0cf8543b2948b952b1
child 388705 5312d9984be1c8f2b18a00d89667985c66e8716a
push id54225
push userdgottwald@mozilla.com
push dateFri, 27 Oct 2017 10:36:23 +0000
treeherderautoland@d60b8971ecd9 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjohannh
bugs1411290
milestone58.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1411290 - Make menulist label text visible for popup permission in identity manager in localized builds. r=johannh MozReview-Commit-ID: 1Vx2uBqzPNc
browser/base/content/browser.js
browser/themes/shared/notification-icons.inc.css
--- a/browser/base/content/browser.js
+++ b/browser/base/content/browser.js
@@ -8036,16 +8036,17 @@ var gIdentityHandler = {
     nameLabel.setAttribute("class", "identity-popup-permission-label");
     nameLabel.textContent = SitePermissions.getPermissionLabel(aPermission.id);
 
     if (aPermission.id == "popup") {
       let menulist = document.createElement("menulist");
       let menupopup = document.createElement("menupopup");
       let block = document.createElement("vbox");
       block.setAttribute("id", "identity-popup-popup-container");
+      menulist.setAttribute("sizetopopup", "none");
       menulist.setAttribute("class", "identity-popup-popup-menulist");
       menulist.setAttribute("id", "identity-popup-popup-menulist");
 
       for (let state of SitePermissions.getAvailableStates(aPermission.id)) {
         let menuitem = document.createElement("menuitem");
         if (state == SitePermissions.getDefault(aPermission.id)) {
           menuitem.setAttribute("value", 0);
         } else {
--- a/browser/themes/shared/notification-icons.inc.css
+++ b/browser/themes/shared/notification-icons.inc.css
@@ -152,17 +152,17 @@ html|*#webRTC-previewVideo {
 }
 
 .popup-subitem {
   list-style-image: url("chrome://browser/skin/notification-icons/popup-subitem.svg");
   margin-inline-start: 30px;
 }
 
 .identity-popup-popup-menulist {
-  width: 72px;
+  min-width: 6.5em;
 }
 
 /* EME */
 
 .popup-notification-icon[popupid="drmContentPlaying"],
 .drm-icon {
   list-style-image: url("chrome://browser/skin/drm-icon.svg");
 }