Bug 1597903 - Add an error message when differences are found in diffoscope. r=froydnj
authorMike Hommey <mh+mozilla@glandium.org>
Thu, 21 Nov 2019 15:03:00 +0000
changeset 503360 cd6b79c74b231e777dc89b0734dbc1611acea097
parent 503359 e2cdd6a01a70e979c24447436f56a3b2b9e39fa8
child 503361 bfe4bccb67304f3b6b2db3fdb3a3bd762e53cac0
push id101289
push usermh@glandium.org
push dateFri, 22 Nov 2019 12:21:32 +0000
treeherderautoland@cd6b79c74b23 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersfroydnj
bugs1597903
milestone72.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1597903 - Add an error message when differences are found in diffoscope. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D54068
taskcluster/docker/diffoscope/get_and_diffoscope
--- a/taskcluster/docker/diffoscope/get_and_diffoscope
+++ b/taskcluster/docker/diffoscope/get_and_diffoscope
@@ -45,28 +45,34 @@ case "$ORIG_URL" in
 	;;
 esac
 
 # Builds are 99% of the time differing in some small ways, so it's not
 # really useful to report a failure (at least not until we actually
 # care about the builds being 100% identical).
 POST=true
 
+fail() {
+	set +x
+	echo "TEST-UNEXPECTED-FAIL | Builds differ. See the diff.html or diff.txt artifact"
+	exit 1
+}
+
 for option; do
 	case "$option" in
 	--unpack)
 		CURDIR=$PWD
 		for dir in a b; do
 			# Need to run mach python from inside the gecko source.
 			# See bug #1533642.
 			(cd $GECKO_PATH && ./mach python toolkit/mozapps/installer/unpack.py --omnijar $OMNIJAR $CURDIR/$dir)
 		done
 		;;
 	--fail)
-		POST="exit 1"
+		POST="fail"
 		;;
 	*)
 		echo "Unsupported option: $option" >&2
 		exit 1
 	esac
 done
 
 if [ -n "$PRE_DIFF" ]; then