Backed out changeset 193d05c4b3fc (bug 1325148)
authorSebastian Hengst <archaeopteryx@coole-files.de>
Tue, 27 Dec 2016 15:14:18 +0100
changeset 327367 cb81231a73fbae2ae5d110a534e940e65697c394
parent 327366 9278da08b49c7788784c2b8383629ed3a685bd12
child 327368 afa60933f33519b9a901213338a69ab383165790
push id35473
push userarchaeopteryx@coole-files.de
push dateTue, 27 Dec 2016 14:15:34 +0000
treeherderautoland@afa60933f335 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1325148
milestone53.0a1
backs out193d05c4b3fc4d1e929cf6e9d930807b7cfe8d24
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset 193d05c4b3fc (bug 1325148)
layout/tools/reftest/runreftest.py
--- a/layout/tools/reftest/runreftest.py
+++ b/layout/tools/reftest/runreftest.py
@@ -364,27 +364,17 @@ class RefTest(object):
             ix = v.find("=")
             if ix <= 0:
                 print "Error: syntax error in --setenv=" + v
                 return None
             browserEnv[v[:ix]] = v[ix + 1:]
 
         # Enable leaks detection to its own log file.
         self.leakLogFile = os.path.join(profileDir, "runreftest_leaks.log")
-
-        # Leak checking was broken in reftest unnoticed for a length of time. During
-        # this time, a leak slipped into the crashtest suite. The leak checking was
-        # fixed by bug 1325148, but it couldn't land until the regression in crashtest
-        # was also fixed or backed out. Rather than waiting and risking new regressions,
-        # temporarily disable leak checking in crashtest. Fix is tracked by bug 1325215.
-        if options.suite == 'crashtest' and mozinfo.info['os'] == 'linux':
-            self.log.warning('WARNING | leakcheck disabled due to bug 1325215')
-        else:
-            browserEnv["XPCOM_MEM_BLOAT_LOG"] = self.leakLogFile
-
+        browserEnv["XPCOM_MEM_BLOAT_LOG"] = self.leakLogFile
         return browserEnv
 
     def killNamedOrphans(self, pname):
         """ Kill orphan processes matching the given command name """
         self.log.info("Checking for orphan %s processes..." % pname)
 
         def _psInfo(line):
             if pname in line: