Bug 1646811 - servo: Implement visibility for layout_2020.
authorMatthias Deiml <matthias@deiml.net>
Thu, 18 Jun 2020 18:13:59 +0000
changeset 536370 cb3a0bb7571a752bb87866cdc721e75f9314416a
parent 536369 82715114ac5bfa857f871162685409cb763c12fc
child 536371 04f8394b23bb2fcc2f19d6baf1a31a66be6bc297
push id119420
push userealvarez@mozilla.com
push dateThu, 18 Jun 2020 18:18:12 +0000
treeherderautoland@206011a5cc20 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1646811
milestone79.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1646811 - servo: Implement visibility for layout_2020. Depends on D80240 Differential Revision: https://phabricator.services.mozilla.com/D80241
servo/components/style/properties/longhands/inherited_box.mako.rs
--- a/servo/components/style/properties/longhands/inherited_box.mako.rs
+++ b/servo/components/style/properties/longhands/inherited_box.mako.rs
@@ -4,20 +4,18 @@
 
 <%namespace name="helpers" file="/helpers.mako.rs" />
 
 <% data.new_style_struct("InheritedBox", inherited=True, gecko_name="Visibility") %>
 
 // TODO: collapse. Well, do tables first.
 ${helpers.single_keyword(
     "visibility",
-    "visible hidden",
+    "visible hidden collapse",
     engines="gecko servo-2013 servo-2020",
-    servo_2020_pref="layout.2020.unimplemented",
-    extra_gecko_values="collapse",
     gecko_ffi_name="mVisible",
     animation_value_type="ComputedValue",
     spec="https://drafts.csswg.org/css-box/#propdef-visibility",
     gecko_enum_prefix="StyleVisibility",
 )}
 
 // CSS Writing Modes Level 3
 // https://drafts.csswg.org/css-writing-modes-3