Bug 1405151: Ensure that crashes appear correctly in Socorro in the case of SIGABRT crashes on macOS. r=ted
authorStephen A Pohl <spohl.mozilla.bugs@gmail.com>
Fri, 13 Oct 2017 16:29:22 -0400
changeset 386256 cafd9cdafeb71fe486fc078cc1ae16e8c2c75e01
parent 386255 19fee71d7e277ee56f7674ca7d40bea8eb5d7945
child 386257 95dff4968a191f64341700d28fa954d898cd8367
push id53313
push userarchaeopteryx@coole-files.de
push dateSat, 14 Oct 2017 10:39:31 +0000
treeherderautoland@169bde8f9f3c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersted
bugs1405151
milestone58.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1405151: Ensure that crashes appear correctly in Socorro in the case of SIGABRT crashes on macOS. r=ted
toolkit/crashreporter/breakpad-client/mac/crash_generation/crash_generation_client.cc
--- a/toolkit/crashreporter/breakpad-client/mac/crash_generation/crash_generation_client.cc
+++ b/toolkit/crashreporter/breakpad-client/mac/crash_generation/crash_generation_client.cc
@@ -41,17 +41,17 @@ bool CrashGenerationClient::RequestDumpF
     mach_port_t crashing_thread) {
   // The server will send a message to this port indicating that it
   // has finished its work.
   ReceivePort acknowledge_port;
 
   MachSendMessage message(kDumpRequestMessage);
   message.AddDescriptor(mach_task_self());            // this task
   message.AddDescriptor(crashing_thread);             // crashing thread
-  message.AddDescriptor(mach_thread_self());          // handler thread
+  message.AddDescriptor(MACH_PORT_NULL);              // handler thread
   message.AddDescriptor(acknowledge_port.GetPort());  // message receive port
 
   ExceptionInfo info;
   info.exception_type = exception_type;
   info.exception_code = exception_code;
   info.exception_subcode = exception_subcode;
   message.SetData(&info, sizeof(info));