Bug 1552643 - P2. Clarify the requirements section. r=njn
☠☠ backed out by af54b2de7028 ☠ ☠
authorJean-Yves Avenard <jyavenard@mozilla.com>
Sat, 25 May 2019 02:03:06 +0000
changeset 475558 caadcd7e02d3a66f7169745414b77891200e1546
parent 475557 aa7086ab09beca98a3b54329ee7825e03b6ee968
child 475559 e30c1aa75529e8920aeec4030db6f348397d11fd
push id86364
push userjyavenard@mozilla.com
push dateSat, 25 May 2019 02:13:29 +0000
treeherderautoland@e30c1aa75529 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersnjn
bugs1552643
milestone69.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1552643 - P2. Clarify the requirements section. r=njn Differential Revision: https://phabricator.services.mozilla.com/D32252
modules/libpref/init/StaticPrefList.h
--- a/modules/libpref/init/StaticPrefList.h
+++ b/modules/libpref/init/StaticPrefList.h
@@ -9,18 +9,20 @@
 //
 // If a pref is listed here and also in a prefs data file such as all.js, the
 // value from the latter will override the value given here. For vanilla
 // browser builds such overrides are discouraged, but they are necessary for
 // some configurations (e.g. Thunderbird).
 //
 // The file is separated into sections, where the sections are determined by
 // the first segment of the prefnames within (e.g. "network.predictor.enabled"
-// is within the "Network" section). Sections should be kept in alphabetical
+// is within the "Network" section). Sections must be kept in alphabetical
 // order, but prefs within sections need not be.
+// Please follow the existing naming convention when considering adding a new
+// pref and whether you need a new section.
 //
 // Normal prefs
 // ------------
 // Definitions of normal prefs in this file have the following form.
 //
 //   PREF(<pref-name-string>, <cpp-type>, <default-value>)
 //
 // - <pref-name-string> is the name of the pref, as it appears in about:config.