Bug 1638724 - Check for extension id instead of extension. r=esawin
☠☠ backed out by 078f263b3757 ☠ ☠
authorAgi Sferro <agi@sferro.dev>
Tue, 07 Jul 2020 16:57:01 +0000
changeset 539176 ca9ad40caa79625a5fca604e3af6488497115a6d
parent 539175 8824d1cadb7ae779956c87bd5d00f6f8a4c5113c
child 539177 1b5170ba3082d1e22b2306cdc329755c19215529
push id120980
push userasferro@mozilla.com
push dateTue, 07 Jul 2020 18:09:11 +0000
treeherderautoland@ca9ad40caa79 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersesawin
bugs1638724
milestone80.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1638724 - Check for extension id instead of extension. r=esawin Differential Revision: https://phabricator.services.mozilla.com/D82443
mobile/android/geckoview/src/androidTest/java/org/mozilla/geckoview/test/WebExtensionTest.kt
--- a/mobile/android/geckoview/src/androidTest/java/org/mozilla/geckoview/test/WebExtensionTest.kt
+++ b/mobile/android/geckoview/src/androidTest/java/org/mozilla/geckoview/test/WebExtensionTest.kt
@@ -550,17 +550,17 @@ class WebExtensionTest : BaseSessionTest
     fun testBrowserTabsCreateWithCookieStoreId() {
         val tabsCreateResult = GeckoResult<Void>()
         var tabsExtension: WebExtension? = null
         val tabDelegate = object : WebExtension.TabDelegate {
             override fun onNewTab(source: WebExtension, details: WebExtension.CreateTabDetails): GeckoResult<GeckoSession> {
                 assertEquals(details.url, "https://www.mozilla.org/en-US/")
                 assertEquals(details.active, true)
                 assertEquals(details.cookieStoreId, "1")
-                assertEquals(tabsExtension!!, source)
+                assertEquals(tabsExtension!!.id!!, source.id)
                 tabsCreateResult.complete(null)
                 return GeckoResult.fromValue(null)
             }
         }
 
         tabsExtension = sessionRule.waitForResult(controller.installBuiltIn(TABS_CREATE_2_BACKGROUND))
         tabsExtension.setTabDelegate(tabDelegate)
         sessionRule.waitForResult(tabsCreateResult)