Bug 1770210 - Fix missing borders for some popups on Windows when HCM is enabled r=Gijs
authorItiel <itiel_yn8@walla.com>
Mon, 23 May 2022 11:24:46 +0000
changeset 618532 c957d9e0d9fc155122dd12aa1d58dca8b2012d32
parent 618531 a703c001c31e6b9d88924318292975dd45c13a80
child 618533 4f52e4fea5f65419c0d6a65a58205491c4ec04c1
push id163315
push useritiel_yn8@walla.com
push dateMon, 23 May 2022 11:27:10 +0000
treeherderautoland@c957d9e0d9fc [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersGijs
bugs1770210
milestone102.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1770210 - Fix missing borders for some popups on Windows when HCM is enabled r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D146831
browser/themes/shared/customizableui/panelUI-shared.css
browser/themes/shared/urlbarView.css
toolkit/themes/windows/global/global.css
--- a/browser/themes/shared/customizableui/panelUI-shared.css
+++ b/browser/themes/shared/customizableui/panelUI-shared.css
@@ -243,17 +243,16 @@ toolbarseparator + .panel-subview-body,
 #PlacesToolbar menupopup[placespopup=true]::part(content),
 #PlacesToolbar menupopup[placespopup=true]::part(arrowscrollbox),
 #PlacesToolbar menupopup {
   border-radius: var(--arrowpanel-border-radius);
 }
 
 #PlacesToolbar menupopup[placespopup=true]::part(arrowscrollbox) {
   padding: var(--panel-subview-body-padding);
-  border: 0;
   background: var(--arrowpanel-background) !important;
   color: var(--arrowpanel-color) !important;
 }
 
 #confirmation-hint {
   --arrowpanel-background: #0060df;
   --arrowpanel-border-color: #0060df;
   --arrowpanel-color: #fff;
--- a/browser/themes/shared/urlbarView.css
+++ b/browser/themes/shared/urlbarView.css
@@ -851,17 +851,22 @@
 
 #PopupSearchAutoComplete {
   --panel-color: var(--toolbar-field-focus-color);
   --panel-background: var(--toolbar-field-focus-background-color);
   --panel-border-color: var(--arrowpanel-border-color);
 }
 
 #PopupSearchAutoComplete::part(content)  {
-  /* Remove the top border since the panel is flush with the input. */
-  border-top-width: 0;
   --panel-padding: var(--panel-subview-body-padding);
 }
 
+@media not (prefers-contrast) {
+  #PopupSearchAutoComplete::part(content)  {
+    /* Remove the top border since the panel is flush with the input. */
+   border-top-width: 0;
+  }
+}
+
 #PopupSearchAutoComplete .autocomplete-richlistitem[selected] {
   background: var(--autocomplete-popup-highlight-background);
   color: var(--autocomplete-popup-highlight-color);
 }
--- a/toolkit/themes/windows/global/global.css
+++ b/toolkit/themes/windows/global/global.css
@@ -52,16 +52,17 @@
   }
 }
 
 @media (prefers-contrast) {
   :root {
     /* In high-contrast mode on Windows, ThreeDLightShadow provides more
        contrast than ThreeDShadow. See bug 1022564. */
     --arrowpanel-border-color: ThreeDLightShadow;
+    --menu-border-color: ThreeDLightShadow;
   }
 }
 
 /* ::::: Alert icons :::::*/
 
 .message-icon,
 .alert-dialog #infoIcon,
 .alert-icon,