Bug 1598520 - Add more logging to DocumentChannel. r=mayhemer,jya
☠☠ backed out by c8ce8b91465a ☠ ☠
authorMatt Woodrow <mwoodrow@mozilla.com>
Thu, 19 Dec 2019 21:49:01 +0000
changeset 507971 c769e733f588048e053b2304b573ce48813a27d8
parent 507970 45287a2ec4767f11896ca939ec688a84dfad4855
child 507972 583dac2feebcd26095d5c18e88424a553cba4b91
push id103719
push userrmaries@mozilla.com
push dateThu, 19 Dec 2019 22:58:39 +0000
treeherderautoland@d26936e3f756 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmayhemer, jya
bugs1598520
milestone73.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1598520 - Add more logging to DocumentChannel. r=mayhemer,jya Differential Revision: https://phabricator.services.mozilla.com/D57589
netwerk/ipc/DocumentChannelChild.cpp
netwerk/ipc/DocumentLoadListener.cpp
--- a/netwerk/ipc/DocumentChannelChild.cpp
+++ b/netwerk/ipc/DocumentChannelChild.cpp
@@ -424,16 +424,20 @@ IPCResult DocumentChannelChild::RecvRedi
   }
 
   // scopeExit will call CrossProcessRedirectFinished(rv) here
   return IPC_OK();
 }
 
 NS_IMETHODIMP
 DocumentChannelChild::OnRedirectVerifyCallback(nsresult aStatusCode) {
+  LOG(
+      ("DocumentChannelChild OnRedirectVerifyCallback [this=%p, "
+       "aRv=0x%08" PRIx32 " ]",
+       this, static_cast<uint32_t>(aStatusCode)));
   nsCOMPtr<nsIChannel> redirectChannel = std::move(mRedirectChannel);
   RedirectToRealChannelResolver redirectResolver = std::move(mRedirectResolver);
 
   // If we've already shut down, then just notify the parent that
   // we're done.
   if (NS_FAILED(mStatus)) {
     redirectChannel->SetNotificationCallbacks(nullptr);
     Maybe<LoadInfoArgs> dummy;
--- a/netwerk/ipc/DocumentLoadListener.cpp
+++ b/netwerk/ipc/DocumentLoadListener.cpp
@@ -419,16 +419,20 @@ void DocumentLoadListener::RedirectToRea
 
 NS_IMETHODIMP
 DocumentLoadListener::ReadyToVerify(nsresult aResultCode) {
   FinishReplacementChannelSetup(NS_SUCCEEDED(aResultCode));
   return NS_OK;
 }
 
 void DocumentLoadListener::FinishReplacementChannelSetup(bool aSucceeded) {
+  LOG(
+      ("DocumentLoadListener FinishReplacementChannelSetup [this=%p, "
+       "aSucceeded=%d]",
+       this, aSucceeded));
   nsresult rv;
 
   if (mDoingProcessSwitch) {
     DisconnectChildListeners(NS_BINDING_ABORTED, NS_BINDING_ABORTED);
   }
 
   nsCOMPtr<nsIParentChannel> redirectChannel;
   if (mRedirectChannelId) {
@@ -531,16 +535,17 @@ void DocumentLoadListener::FinishReplace
     }
   }
 
   ResumeSuspendedChannel(redirectChannel);
 }
 
 void DocumentLoadListener::ResumeSuspendedChannel(
     nsIStreamListener* aListener) {
+  LOG(("DocumentLoadListener ResumeSuspendedChannel [this=%p]", this));
   RefPtr<nsHttpChannel> httpChannel = do_QueryObject(mChannel);
   if (httpChannel) {
     httpChannel->SetApplyConversion(mOldApplyConversion);
   }
 
   // If we failed to suspend the channel, then we might have received
   // some messages while the redirected was being handled.
   // Manually send them on now.