Bug 1428917 - Remove broken RTL support for inspector breadcrumbs in RTL locales r=gl
authorItiel <itiel_yn8@walla.com>
Wed, 14 Aug 2019 14:58:25 +0000
changeset 487929 c7020788e8b67eefb983ea9209cfe2db8e8a063e
parent 487928 771185e8e4dc342f4343d81bf98d852f8a640328
child 487930 997d1568d944a892bb94c0e2a79f99966b8b097d
push id92549
push usergluong@mozilla.com
push dateWed, 14 Aug 2019 14:59:03 +0000
treeherderautoland@c7020788e8b6 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersgl
bugs1428917
milestone70.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1428917 - Remove broken RTL support for inspector breadcrumbs in RTL locales r=gl Since the 2 code panels above are LTR and in english characters only, it doesn't make sense to break the flow and make the bottom part RTL, so this removes RTL support altogether and forces LTR on html-arrowscrollbox-inner. Differential Revision: https://phabricator.services.mozilla.com/D41287
devtools/client/themes/breadcrumbs.css
devtools/client/themes/inspector.css
--- a/devtools/client/themes/breadcrumbs.css
+++ b/devtools/client/themes/breadcrumbs.css
@@ -109,32 +109,16 @@
   border-width: 0;
 }
 
 .breadcrumbs-widget-item:first-child::before {
   /* The first crumb does not need any separator before itself */
   content: unset;
 }
 
-.breadcrumbs-widget-item:dir(rtl)::before {
-  transform: scaleX(-1);
-}
-
-/* RTL support: move the images that were on the left to the right,
- * and move images that were on the right to the left.
- */
-.breadcrumbs-widget-item:dir(rtl) {
-  padding: 0 20px 0 8px;
-}
-
-.breadcrumbs-widget-item:dir(rtl),
-.breadcrumbs-widget-item[checked] + .breadcrumbs-widget-item:dir(rtl) {
-  background-position: center right;
-}
-
 .breadcrumbs-widget-item:not(:first-child)::before {
   content: url(chrome://devtools/skin/images/breadcrumbs-divider.svg);
   background: none;
   position: relative;
   left: -3px;
   margin: 0 4px 0 -1px;
   top: -1px;
 }
--- a/devtools/client/themes/inspector.css
+++ b/devtools/client/themes/inspector.css
@@ -142,16 +142,17 @@ window {
   display: flex;
   align-items: center;
 }
 
 #inspector-breadcrumbs .html-arrowscrollbox-inner {
   flex: 1;
   display: flex;
   overflow: hidden;
+  direction: ltr;
 }
 
 #inspector-breadcrumbs .breadcrumbs-widget-item {
   white-space: nowrap;
   flex-shrink: 0;
 }
 
 #inspector-rules-container,