Bug 831100 - use std::string. Extra reviews. r=ehsan,vladan.
authorRafael Ávila de Espíndola <respindola@mozilla.com>
Thu, 17 Jan 2013 09:48:37 -0500
changeset 119150 c6f827a03d8834c1b528937b8fd2bc953fb710a8
parent 119149 8eb23e5170d0f327db14c11b8806aa8c452ed975
child 119151 143e6064d88ce42ca87a8cb2a36f2b036beb51b9
push id24195
push userMs2ger@gmail.com
push dateSat, 19 Jan 2013 16:10:11 +0000
treeherderautoland@02e12a80aef9 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersehsan, vladan
bugs831100
milestone21.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 831100 - use std::string. Extra reviews. r=ehsan,vladan.
tools/profiler/shared-libraries.h
--- a/tools/profiler/shared-libraries.h
+++ b/tools/profiler/shared-libraries.h
@@ -9,29 +9,28 @@
 
 #ifndef MOZ_ENABLE_PROFILER_SPS
 #error This header does not have a useful implementation on your platform!
 #endif
 
 #include <algorithm>
 #include <vector>
 #include <string>
-#include <string.h>
 #include <stdlib.h>
 #include <mozilla/StandardInteger.h>
 #include <nsID.h>
 
 class SharedLibrary {
 public:
 
   SharedLibrary(unsigned long aStart,
                 unsigned long aEnd,
                 unsigned long aOffset,
-                const std::string &aBreakpadId,
-                const std::string &aName)
+                const std::string& aBreakpadId,
+                const std::string& aName)
     : mStart(aStart)
     , mEnd(aEnd)
     , mOffset(aOffset)
     , mBreakpadId(aBreakpadId)
     , mName(aName)
   {}
 
   SharedLibrary(const SharedLibrary& aEntry)