Bug 1595982 - fix incorrect import in python3 codepath inside mozharness/base/python.py r=aki
authorEdwin Takahashi <egao@mozilla.com>
Wed, 20 Nov 2019 22:44:27 +0000
changeset 503117 c6ded1c53db84195b45cd3a23009e1d9c4533913
parent 503116 66d38b28491e4c1e9bdf1ce767c31b50ebda518d
child 503118 10dde27b429c4303af3cf5dc7b340b8361f70722
push id101126
push useregao@mozilla.com
push dateWed, 20 Nov 2019 22:51:40 +0000
treeherderautoland@c6ded1c53db8 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersaki
bugs1595982
milestone72.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1595982 - fix incorrect import in python3 codepath inside mozharness/base/python.py r=aki I mistakenly attempted to `import urllib.urlparse` instead of `urllib.parse`, which caused a bunch of tests running under python3.5 tox to be blocked on this. This correction allows tox on python3.5 to run all 167 tests, allowing me to cross-check further python3 conversion work. Differential Revision: https://phabricator.services.mozilla.com/D54041
testing/mozharness/mozharness/base/python.py
--- a/testing/mozharness/mozharness/base/python.py
+++ b/testing/mozharness/mozharness/base/python.py
@@ -11,17 +11,17 @@ import errno
 import json
 import os
 import socket
 import sys
 import traceback
 try:
     import urlparse
 except ImportError:
-    import urllib.urlparse as urlparse
+    import urllib.parse as urlparse
 
 from six import string_types
 
 import mozharness
 from mozharness.base.errors import VirtualenvErrorList
 from mozharness.base.log import FATAL, WARNING
 from mozharness.base.script import (PostScriptAction, PostScriptRun,
                                     PreScriptAction, ScriptMixin)